* [mmotm:master 326/350] undefined reference to `tty_write_message'
@ 2014-02-26 6:46 kbuild test robot
2014-02-26 7:07 ` Josh Triplett
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2014-02-26 6:46 UTC (permalink / raw)
To: Josh Triplett
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner, kbuild-all
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: a6a1126d3535f0bd8d7c56810061541a4f5595af
commit: 5837644fad4fdcc7a812eb1f3a215d8196628627 [326/350] kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT
config: make ARCH=ia64 allnoconfig
All error/warnings:
arch/ia64/kernel/built-in.o: In function `ia64_handle_unaligned':
>> (.text+0x1b882): undefined reference to `tty_write_message'
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mmotm:master 326/350] undefined reference to `tty_write_message'
2014-02-26 6:46 [mmotm:master 326/350] undefined reference to `tty_write_message' kbuild test robot
@ 2014-02-26 7:07 ` Josh Triplett
2014-02-26 10:15 ` Josh Triplett
0 siblings, 1 reply; 5+ messages in thread
From: Josh Triplett @ 2014-02-26 7:07 UTC (permalink / raw)
To: kbuild test robot
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner, kbuild-all
On Wed, Feb 26, 2014 at 02:46:45PM +0800, kbuild test robot wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: a6a1126d3535f0bd8d7c56810061541a4f5595af
> commit: 5837644fad4fdcc7a812eb1f3a215d8196628627 [326/350] kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT
> config: make ARCH=ia64 allnoconfig
>
> All error/warnings:
>
> arch/ia64/kernel/built-in.o: In function `ia64_handle_unaligned':
> >> (.text+0x1b882): undefined reference to `tty_write_message'
Looks like ia64 is broken with CONFIG_TTY=n. Why in the world does
arch/ia64/kernel/unaligned.c call tty_write_message on the tty of the
current process? That's just *wrong*.
Would anything go horribly wrong if the tty_write_message just went
away, leaving only the printk? (Bonus: no need to sprintf first.)
- Josh Triplett
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ia64: select CONFIG_TTY for use of tty_write_message in unaligned
2014-02-26 7:07 ` Josh Triplett
2014-02-26 10:15 ` Josh Triplett
@ 2014-02-26 10:15 ` Josh Triplett
0 siblings, 0 replies; 5+ messages in thread
From: Josh Triplett @ 2014-02-26 10:15 UTC (permalink / raw)
To: kbuild test robot, Linux Memory Management List, Andrew Morton,
Johannes Weiner, kbuild-all, Tony Luck, Fenghua Yu, linux-ia64,
linux-kernel
arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.
Minimal fix, on the basis that few people on ia64 will care deeply about
kernel size enough to turn off TTY. Ideally, I'd instead suggest
dropping the tty_write_message entirely, and just leaving the printk.
Bonus: no need to sprintf first.
arch/ia64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 0c8e553..6b83c66 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -44,6 +44,7 @@ config IA64
select HAVE_MOD_ARCH_SPECIFIC
select MODULES_USE_ELF_RELA
select ARCH_USE_CMPXCHG_LOCKREF
+ select TTY
default y
help
The Itanium Processor Family is Intel's 64-bit successor to
--
1.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ia64: select CONFIG_TTY for use of tty_write_message in unaligned
@ 2014-02-26 10:15 ` Josh Triplett
0 siblings, 0 replies; 5+ messages in thread
From: Josh Triplett @ 2014-02-26 10:15 UTC (permalink / raw)
To: kbuild test robot, Linux Memory Management List, Andrew Morton,
Johannes Weiner, kbuild-all, Tony Luck, Fenghua Yu, linux-ia64,
linux-kernel
arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.
Minimal fix, on the basis that few people on ia64 will care deeply about
kernel size enough to turn off TTY. Ideally, I'd instead suggest
dropping the tty_write_message entirely, and just leaving the printk.
Bonus: no need to sprintf first.
arch/ia64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 0c8e553..6b83c66 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -44,6 +44,7 @@ config IA64
select HAVE_MOD_ARCH_SPECIFIC
select MODULES_USE_ELF_RELA
select ARCH_USE_CMPXCHG_LOCKREF
+ select TTY
default y
help
The Itanium Processor Family is Intel's 64-bit successor to
--
1.9.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ia64: select CONFIG_TTY for use of tty_write_message in unaligned
@ 2014-02-26 10:15 ` Josh Triplett
0 siblings, 0 replies; 5+ messages in thread
From: Josh Triplett @ 2014-02-26 10:15 UTC (permalink / raw)
To: kbuild test robot, Linux Memory Management List, Andrew Morton,
Johannes Weiner, kbuild-all, Tony Luck, Fenghua Yu, linux-ia64,
linux-kernel
arch/ia64/kernel/unaligned.c uses tty_write_message to print an
unaligned access exception to the TTY of the current user process.
Enable TTY to prevent a build error.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.
Minimal fix, on the basis that few people on ia64 will care deeply about
kernel size enough to turn off TTY. Ideally, I'd instead suggest
dropping the tty_write_message entirely, and just leaving the printk.
Bonus: no need to sprintf first.
arch/ia64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 0c8e553..6b83c66 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -44,6 +44,7 @@ config IA64
select HAVE_MOD_ARCH_SPECIFIC
select MODULES_USE_ELF_RELA
select ARCH_USE_CMPXCHG_LOCKREF
+ select TTY
default y
help
The Itanium Processor Family is Intel's 64-bit successor to
--
1.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-26 10:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 6:46 [mmotm:master 326/350] undefined reference to `tty_write_message' kbuild test robot
2014-02-26 7:07 ` Josh Triplett
2014-02-26 10:15 ` [PATCH] ia64: select CONFIG_TTY for use of tty_write_message in unaligned Josh Triplett
2014-02-26 10:15 ` Josh Triplett
2014-02-26 10:15 ` Josh Triplett
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.