* [ebtables PATCH (resent)] arptables: long option "--set-counters" were missing
@ 2014-02-28 12:32 Jesper Dangaard Brouer
2014-03-02 21:16 ` Bart De Schuymer
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2014-02-28 12:32 UTC (permalink / raw)
To: Bart De Schuymer; +Cc: netdev
The long option "--set-counters" where missing in option parsing.
And the corresponding short option "-c" were not mentioned in
the help usage text.
Also update the arptables man page with a description
of the parameter.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
Resending patch... didn't get any response from Bart De Schuymer last time...
userspace/arptables/arptables.8 | 8 ++++++++
userspace/arptables/arptables.c | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/userspace/arptables/arptables.8 b/userspace/arptables/arptables.8
index 0b6b62e..78b2c60 100644
--- a/userspace/arptables/arptables.8
+++ b/userspace/arptables/arptables.8
@@ -215,6 +215,14 @@ The target of the rule. This is one of the following values:
a target extension (see
.BR "TARGET EXTENSIONS" ")"
or a user-defined chain name.
+.TP
+.BI "-c, --set-counters " "PKTS BYTES"
+This enables the administrator to initialize the packet and byte
+counters of a rule (during
+.B INSERT,
+.B APPEND,
+.B REPLACE
+operations).
.SS RULE-SPECIFICATIONS
The following command line arguments make up a rule specification (as used
diff --git a/userspace/arptables/arptables.c b/userspace/arptables/arptables.c
index 4da6fea..3fb8ed5 100644
--- a/userspace/arptables/arptables.c
+++ b/userspace/arptables/arptables.c
@@ -152,6 +152,7 @@ static struct option original_opts[] = {
{ "help", 2, 0, 'h' },
{ "line-numbers", 0, 0, '0' },
{ "modprobe", 1, 0, 'M' },
+ { "set-counters", 1, 0, 'c' },
{ 0 }
};
@@ -529,7 +530,7 @@ exit_printhelp(void)
" --line-numbers print line numbers when listing\n"
" --exact -x expand numbers (display exact values)\n"
" --modprobe=<command> try to insert modules using this command\n"
-" --set-counters PKTS BYTES set the counter during insert/append\n"
+" --set-counters -c PKTS BYTES set the counter during insert/append\n"
"[!] --version -V print package version.\n");
printf(" opcode strings: \n");
for (i = 0; i < NUMOPCODES; i++)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ebtables PATCH (resent)] arptables: long option "--set-counters" were missing
2014-02-28 12:32 [ebtables PATCH (resent)] arptables: long option "--set-counters" were missing Jesper Dangaard Brouer
@ 2014-03-02 21:16 ` Bart De Schuymer
0 siblings, 0 replies; 2+ messages in thread
From: Bart De Schuymer @ 2014-03-02 21:16 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: netdev
Jesper Dangaard Brouer schreef op 28/02/2014 13:32:
> The long option "--set-counters" where missing in option parsing.
> And the corresponding short option "-c" were not mentioned in
> the help usage text.
>
> Also update the arptables man page with a description
> of the parameter.
Applied.
Thanks,
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-02 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 12:32 [ebtables PATCH (resent)] arptables: long option "--set-counters" were missing Jesper Dangaard Brouer
2014-03-02 21:16 ` Bart De Schuymer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.