[PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

[PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

[Jonathan Cameron]

Issue highlighted by smatch warning:

CHECK   drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
interrupted, ret must be signed.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fugang Duan <B38611@freescale.com>
---
 drivers/iio/adc/vf610_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 37f542e..44799eb5 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,
 {
 	struct vf610_adc *info = iio_priv(indio_dev);
 	unsigned int hc_cfg;
-	unsigned long ret;
+	long ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
-- 
1.9.0

RE: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

[fugang.duan]

From: Jonathan Cameron <jic23@kernel.org>
Data: Sunday, March 02, 2014 6:03 AM

>To: linux-iio@vger.kernel.org
>Cc: Jonathan Cameron; Dan Carpenter; Duan Fugang-B38611
>Subject: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait
>for completion
>
>Issue highlighted by smatch warning:
>
>CHECK   drivers/iio/adc/vf610_adc.c
>drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never
>less than zero.
>
>As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
>interrupted, ret must be signed.
>
>Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>Cc: Dan Carpenter <dan.carpenter@oracle.com>
>Cc: Fugang Duan <B38611@freescale.com>
>---
> drivers/iio/adc/vf610_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
>37f542e..44799eb5 100644
>--- a/drivers/iio/adc/vf610_adc.c
>+++ b/drivers/iio/adc/vf610_adc.c
>@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,  {
> 	struct vf610_adc *info = iio_priv(indio_dev);
> 	unsigned int hc_cfg;
>-	unsigned long ret;
>+	long ret;
>
> 	switch (mask) {
> 	case IIO_CHAN_INFO_RAW:
>--
>1.9.0
>
>

Acked-by: Fugang Duan <B38611@freescale.com>

Re: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

[Jonathan Cameron]

On 02/03/14 01:36, fugang.duan@freescale.com wrote:
> From: Jonathan Cameron <jic23@kernel.org>
> Data: Sunday, March 02, 2014 6:03 AM
>
>> To: linux-iio@vger.kernel.org
>> Cc: Jonathan Cameron; Dan Carpenter; Duan Fugang-B38611
>> Subject: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait
>> for completion
>>
>> Issue highlighted by smatch warning:
>>
>> CHECK   drivers/iio/adc/vf610_adc.c
>> drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never
>> less than zero.
>>
>> As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
>> interrupted, ret must be signed.
>>
>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
> Acked-by: Fugang Duan <B38611@freescale.com>
Applied to the togreg branch of iio.git.