* [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
@ 2014-02-26 23:51 Peter Maydell
2014-02-26 23:56 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2014-02-26 23:51 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini, Andreas Färber, patches
The function qobject_from_json() doesn't actually allow its
argument to be a format string -- it passes a NULL va_list*
to qobject_from_jsonv(), and the parser code will then never
actually intepret %-escape sequences (it tests whether the
va_list pointer is NULL and will stop with a parse error).
The spurious attribute markup causes clang warnings in some
of the test cases where we programmatically construct JSON
to feed to qobject_from_json():
tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
string literal (potentially insecure) [-Wformat-security]
data->obj = qobject_from_json(json_string);
^~~~~~~~~~~
Remove the incorrect attribute.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/qapi/qmp/qjson.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qapi/qmp/qjson.h b/include/qapi/qmp/qjson.h
index 73351ed..ee4d31a 100644
--- a/include/qapi/qmp/qjson.h
+++ b/include/qapi/qmp/qjson.h
@@ -19,7 +19,7 @@
#include "qapi/qmp/qobject.h"
#include "qapi/qmp/qstring.h"
-QObject *qobject_from_json(const char *string) GCC_FMT_ATTR(1, 0);
+QObject *qobject_from_json(const char *string);
QObject *qobject_from_jsonf(const char *string, ...) GCC_FMT_ATTR(1, 2);
QObject *qobject_from_jsonv(const char *string, va_list *ap) GCC_FMT_ATTR(1, 0);
--
1.8.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
2014-02-26 23:51 [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration Peter Maydell
@ 2014-02-26 23:56 ` Eric Blake
2014-03-02 13:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-02 22:51 ` [Qemu-devel] " Andreas Färber
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2014-02-26 23:56 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Andreas Färber, patches
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
On 02/26/2014 04:51 PM, Peter Maydell wrote:
> The function qobject_from_json() doesn't actually allow its
> argument to be a format string -- it passes a NULL va_list*
> to qobject_from_jsonv(), and the parser code will then never
> actually intepret %-escape sequences (it tests whether the
> va_list pointer is NULL and will stop with a parse error).
>
> The spurious attribute markup causes clang warnings in some
> of the test cases where we programmatically construct JSON
> to feed to qobject_from_json():
>
> tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
> string literal (potentially insecure) [-Wformat-security]
> data->obj = qobject_from_json(json_string);
> ^~~~~~~~~~~
>
> Remove the incorrect attribute.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/qapi/qmp/qjson.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
2014-02-26 23:51 [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration Peter Maydell
2014-02-26 23:56 ` Eric Blake
@ 2014-03-02 13:21 ` Michael Tokarev
2014-03-02 22:51 ` [Qemu-devel] " Andreas Färber
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-03-02 13:21 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-trivial, Paolo Bonzini, Andreas Färber, qemu-devel, patches
27.02.2014 03:51, Peter Maydell пишет:
> The function qobject_from_json() doesn't actually allow its
> argument to be a format string -- it passes a NULL va_list*
> to qobject_from_jsonv(), and the parser code will then never
> actually intepret %-escape sequences (it tests whether the
> va_list pointer is NULL and will stop with a parse error).
>
> The spurious attribute markup causes clang warnings in some
> of the test cases where we programmatically construct JSON
> to feed to qobject_from_json():
>
> tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
> string literal (potentially insecure) [-Wformat-security]
> data->obj = qobject_from_json(json_string);
> ^~~~~~~~~~~
>
> Remove the incorrect attribute.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
2014-02-26 23:51 [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration Peter Maydell
2014-02-26 23:56 ` Eric Blake
2014-03-02 13:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-03-02 22:51 ` Andreas Färber
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Färber @ 2014-03-02 22:51 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, patches
Am 27.02.2014 00:51, schrieb Peter Maydell:
> The function qobject_from_json() doesn't actually allow its
> argument to be a format string -- it passes a NULL va_list*
> to qobject_from_jsonv(), and the parser code will then never
> actually intepret %-escape sequences (it tests whether the
"interpret"
> va_list pointer is NULL and will stop with a parse error).
>
> The spurious attribute markup causes clang warnings in some
> of the test cases where we programmatically construct JSON
> to feed to qobject_from_json():
>
> tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
> string literal (potentially insecure) [-Wformat-security]
> data->obj = qobject_from_json(json_string);
> ^~~~~~~~~~~
>
> Remove the incorrect attribute.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Otherwise
Reviewed-by: Andreas Färber <afaerber@suse.de>
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-02 22:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 23:51 [Qemu-devel] [PATCH] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration Peter Maydell
2014-02-26 23:56 ` Eric Blake
2014-03-02 13:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-02 22:51 ` [Qemu-devel] " Andreas Färber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.