From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008
Date: Thu, 06 Mar 2014 10:59:44 -0700 [thread overview]
Message-ID: <5318B790.8090808@wwwdotorg.org> (raw)
In-Reply-To: <1393932664-13319-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/04/2014 04:31 AM, Wei Ni wrote:
> Add dt node to describe the thermal zone for the nct1008.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + thermal-zones {
> + nct1008-local {
> + polling-delay-passive = <2000>; /* milliseconds */
> + polling-delay = <0>; /* milliseconds */
A delay of 0 implies that software continually polls this zone, thus
consuming an entire CPU. Is this really what you want?
> +
> + thermal-sensors = <&nct1008 0>;
> + };
This zone (and the other) is missing the required (per the binding
documentation) trips and cooling-maps sub-nodes.
I've also sent a query in response to the thermal-zones binding so see
whether or not it can be fixed so that software doesn't bind against the
node name, but rather against a compatible property like almost
everything else. Let's see what the response is there before reposting
this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>, khali@linux-fr.org, linux@roeck-us.net
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008
Date: Thu, 06 Mar 2014 10:59:44 -0700 [thread overview]
Message-ID: <5318B790.8090808@wwwdotorg.org> (raw)
In-Reply-To: <1393932664-13319-4-git-send-email-wni@nvidia.com>
On 03/04/2014 04:31 AM, Wei Ni wrote:
> Add dt node to describe the thermal zone for the nct1008.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + thermal-zones {
> + nct1008-local {
> + polling-delay-passive = <2000>; /* milliseconds */
> + polling-delay = <0>; /* milliseconds */
A delay of 0 implies that software continually polls this zone, thus
consuming an entire CPU. Is this really what you want?
> +
> + thermal-sensors = <&nct1008 0>;
> + };
This zone (and the other) is missing the required (per the binding
documentation) trips and cooling-maps sub-nodes.
I've also sent a query in response to the thermal-zones binding so see
whether or not it can be fixed so that software doesn't bind against the
node name, but rather against a compatible property like almost
everything else. Let's see what the response is there before reposting
this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [lm-sensors] [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008
Date: Thu, 06 Mar 2014 17:59:44 +0000 [thread overview]
Message-ID: <5318B790.8090808@wwwdotorg.org> (raw)
In-Reply-To: <1393932664-13319-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/04/2014 04:31 AM, Wei Ni wrote:
> Add dt node to describe the thermal zone for the nct1008.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + thermal-zones {
> + nct1008-local {
> + polling-delay-passive = <2000>; /* milliseconds */
> + polling-delay = <0>; /* milliseconds */
A delay of 0 implies that software continually polls this zone, thus
consuming an entire CPU. Is this really what you want?
> +
> + thermal-sensors = <&nct1008 0>;
> + };
This zone (and the other) is missing the required (per the binding
documentation) trips and cooling-maps sub-nodes.
I've also sent a query in response to the thermal-zones binding so see
whether or not it can be fixed so that software doesn't bind against the
node name, but rather against a compatible property like almost
everything else. Let's see what the response is there before reposting
this patch.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2014-03-06 17:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 11:31 [PATCH v2 0/3] expose lm90 to thermal fw Wei Ni
2014-03-04 11:31 ` [lm-sensors] " Wei Ni
2014-03-04 11:31 ` Wei Ni
[not found] ` <1393932664-13319-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-04 11:31 ` [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes Wei Ni
2014-03-04 11:31 ` [lm-sensors] " Wei Ni
2014-03-04 11:31 ` Wei Ni
2014-03-04 11:31 ` [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008 Wei Ni
2014-03-04 11:31 ` [lm-sensors] " Wei Ni
2014-03-04 11:31 ` Wei Ni
2014-03-04 22:06 ` Stephen Warren
2014-03-04 22:06 ` [lm-sensors] " Stephen Warren
[not found] ` <53164E78.5010708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-04 22:23 ` Guenter Roeck
2014-03-04 22:23 ` [lm-sensors] " Guenter Roeck
2014-03-04 22:23 ` Guenter Roeck
[not found] ` <20140304222357.GA6125-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-03-05 2:30 ` Wei Ni
2014-03-05 2:30 ` [lm-sensors] " Wei Ni
2014-03-05 2:30 ` Wei Ni
[not found] ` <53168C5B.6070003-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-05 2:58 ` Stephen Warren
2014-03-05 2:58 ` [lm-sensors] " Stephen Warren
2014-03-05 2:58 ` Stephen Warren
[not found] ` <531692D2.6040204-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-05 3:07 ` Wei Ni
2014-03-05 3:07 ` [lm-sensors] " Wei Ni
2014-03-05 3:07 ` Wei Ni
[not found] ` <531694EB.50906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-05 3:14 ` Stephen Warren
2014-03-05 3:14 ` [lm-sensors] " Stephen Warren
2014-03-05 3:14 ` Stephen Warren
[not found] ` <531696A9.6060906-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-05 4:26 ` Wei Ni
2014-03-05 4:26 ` [lm-sensors] " Wei Ni
2014-03-05 4:26 ` Wei Ni
[not found] ` <5316A785.8030504-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-05 4:30 ` Wei Ni
2014-03-05 4:30 ` [lm-sensors] " Wei Ni
2014-03-05 4:30 ` Wei Ni
[not found] ` <1393932664-13319-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-06 17:59 ` Stephen Warren [this message]
2014-03-06 17:59 ` [lm-sensors] " Stephen Warren
2014-03-06 17:59 ` Stephen Warren
[not found] ` <5318B790.8090808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-07 3:45 ` Wei Ni
2014-03-07 3:45 ` [lm-sensors] " Wei Ni
2014-03-07 3:45 ` Wei Ni
[not found] ` <531940C5.3040102-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-07 4:23 ` Stephen Warren
2014-03-07 4:23 ` [lm-sensors] " Stephen Warren
2014-03-07 4:23 ` Stephen Warren
2014-03-04 11:31 ` [PATCH v2 2/3] hwmon: lm90: expose to thermal fw via DT nodes Wei Ni
2014-03-04 11:31 ` [lm-sensors] " Wei Ni
2014-03-04 11:31 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318B790.8090808@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.