[PATCH 0/1] dbus: fix a hard dependency about dbus-ptest

[PATCH 0/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

The following changes since commit a01af0202558e6ed9d16590b3a8d1dd1b95c0374:

  recipes: bump PRs (2014-03-05 17:36:37 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/dbus
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/dbus

Chong Lu (1):
  dbus: fix a hard dependency about dbus-ptest

 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 5 ++++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)

-- 
1.8.1.2

[PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
issue will increase size for most small images.
This patch fixes this problem.

[YOCTO #5702]

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 5 ++++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)

diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb b/meta/recipes-core/dbus/dbus-test_1.6.18.bb
similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 677ff78..292bef6 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -6,7 +6,6 @@ LICENSE = "AFL-2 | GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
                     file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
 DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
 RDEPENDS_dbus_class-native = ""
 RDEPENDS_dbus_class-nativesdk = ""
 
@@ -151,3 +150,7 @@ do_install_class-nativesdk() {
 	rm -rf ${D}${localstatedir}/run
 }
 BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES += "dbus-ptest"
+ALLOW_EMPTY_${PN}-ptest = "1"
+RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}"
-- 
1.8.1.2

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Burton, Ross]

On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> +PACKAGES += "dbus-ptest"
> +ALLOW_EMPTY_${PN}-ptest = "1"
> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}"

Nice idea, but wouldn't a more correct solution be to have dbus-ptest
added to PACKAGES conditionally (instead of always generating
dbus-ptest and conditionally adding the dependency)?

Ross

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

On 03/06/2014 06:04 PM, Burton, Ross wrote:
> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>> +PACKAGES += "dbus-ptest"
>> +ALLOW_EMPTY_${PN}-ptest = "1"
>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}"
> Nice idea, but wouldn't a more correct solution be to have dbus-ptest
> added to PACKAGES conditionally (instead of always generating
> dbus-ptest and conditionally adding the dependency)?
>
> Ross
>
>
Hi Ross,

Do you mean using PACKAGES += "${@base_contains('IMAGE_FEATURES', 
'ptest-pkgs', 'dbus-ptest-ptest', 'dbus-ptest', d)}" or something else?


Best Regards
Chong

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Burton, Ross]

On 7 March 2014 02:13, Chong Lu <Chong.Lu@windriver.com> wrote:
> Do you mean using PACKAGES += "${@base_contains('IMAGE_FEATURES',
> 'ptest-pkgs', 'dbus-ptest-ptest', 'dbus-ptest', d)}" or something else?

Clearly I wasn't thinking clearly last week.  You can't check
IMAGE_FEATURES in a non-image recipe so this isn't a good solution.

Ross

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]


On 03/06/2014 06:04 PM, Burton, Ross wrote:
> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>> +PACKAGES += "dbus-ptest"
>> +ALLOW_EMPTY_${PN}-ptest = "1"
>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs', 'dbus-test-ptest', 'dbus-test', d)}"
Hi Ross,

Do you have any suggestion about this issue?
If we don't check IMAGE_FEATURES, I have no way to resolve this problem 
that only build but not install ptest. I'm very confused.

Best Regards
Chong

> Nice idea, but wouldn't a more correct solution be to have dbus-ptest
> added to PACKAGES conditionally (instead of always generating
> dbus-ptest and conditionally adding the dependency)?
>
> Ross
> Clearly I wasn't thinking clearly last week.  You can't check
> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
>
> Ross
>
>


[-- Attachment #2: Type: text/html, Size: 1872 bytes --]

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Paul Eggleton]

On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
> On 03/06/2014 06:04 PM, Burton, Ross wrote:
> > On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> >> +PACKAGES += "dbus-ptest"
> >> +ALLOW_EMPTY_${PN}-ptest = "1"
> >> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs',
> >> 'dbus-test-ptest', 'dbus-test', d)}"
> >
> > Clearly I wasn't thinking clearly last week.  You can't check
> > IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
> 
> Do you have any suggestion about this issue?
> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
> that only build but not install ptest. I'm very confused.

This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is in 
DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter if 
the dependency between dbus-ptest and dbus-ptest-ptest exists because dbus-
ptest itself shouldn't be in the image, so dbus-ptest-ptest shouldn't be 
pulled in either. Does that make sense?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Paul Eggleton]

On Thursday 13 March 2014 10:01:10 Paul Eggleton wrote:
> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
> > On 03/06/2014 06:04 PM, Burton, Ross wrote:
> > > On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> > >> +PACKAGES += "dbus-ptest"
> > >> +ALLOW_EMPTY_${PN}-ptest = "1"
> > >> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
> > >> 'ptest-pkgs',
> > >> 'dbus-test-ptest', 'dbus-test', d)}"
> > > 
> > > Clearly I wasn't thinking clearly last week.  You can't check
> > > IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
> > 
> > Do you have any suggestion about this issue?
> > If we don't check IMAGE_FEATURES, I have no way to resolve this problem
> > that only build but not install ptest. I'm very confused.
> 
> This should check DISTRO_FEATURES, not IMAGE_FEATURES.

Actually even a check on DISTRO_FEATURES may not be needed; if ${PN}-ptest is 
not in PACKAGES then RDEPENDS_${PN}-ptest should be ignored completely.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

On 03/13/2014 06:01 PM, Paul Eggleton wrote:
> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>> +PACKAGES += "dbus-ptest"
>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES', 'ptest-pkgs',
>>>> 'dbus-test-ptest', 'dbus-test', d)}"
>>> Clearly I wasn't thinking clearly last week.  You can't check
>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
>> Do you have any suggestion about this issue?
>> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
>> that only build but not install ptest. I'm very confused.
> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is in
> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter if
> the dependency between dbus-ptest and dbus-ptest-ptest exists because dbus-
> ptest itself shouldn't be in the image, so dbus-ptest-ptest shouldn't be
> pulled in either. Does that make sense?
>
> Cheers,
> Paul
>
Hi Paul,

Thanks for your reply!
But I still have a question.

I try to following way:

# git diff
diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb 
b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
index bc260de..50dfe54 100644
--- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
+++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
@@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"

  RDEPENDS_${PN} += "make"
  RDEPENDS_${PN}-dev = ""
+ALLOW_EMPTY_${PN} = "1"

  SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
             file://tmpdir.patch \
diff --git a/meta/recipes-core/dbus/dbus.inc 
b/meta/recipes-core/dbus/dbus.inc
index 677ff78..ba7f3cb 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
  LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
  DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 
'dbus-ptest-ptest', '', d)}"
+RDEPENDS_dbus = "dbus-ptest"
  RDEPENDS_dbus_class-native = ""
  RDEPENDS_dbus_class-nativesdk = ""

In local.conf, I set following thing:
+EXTRA_IMAGE_FEATURES += "ptest-pkgs"
+CORE_IMAGE_EXTRA_INSTALL += "dbus"

Then, I run "bitbake core-image-minimal" command.
Finally, I start target through runqemu.
But dbus ptest is not installed.

I alway try to many ways to fix this issue, but the result is not 
satisfactory.

I think the point of this defect is the following question:
If we only want to build dbus-ptest (generate dbus-ptest-ptest-***.rpm), 
but not install it. How to resolve it?

Best Regards
Chong

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Paul Eggleton]

On Friday 14 March 2014 17:14:27 Chong Lu wrote:
> On 03/13/2014 06:01 PM, Paul Eggleton wrote:
> > On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
> >> On 03/06/2014 06:04 PM, Burton, Ross wrote:
> >>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> >>>> +PACKAGES += "dbus-ptest"
> >>>> +ALLOW_EMPTY_${PN}-ptest = "1"
> >>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
> >>>> 'ptest-pkgs',
> >>>> 'dbus-test-ptest', 'dbus-test', d)}"
> >>> 
> >>> Clearly I wasn't thinking clearly last week.  You can't check
> >>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
> >> 
> >> Do you have any suggestion about this issue?
> >> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
> >> that only build but not install ptest. I'm very confused.
> > 
> > This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is
> > in
> > DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter
> > if the dependency between dbus-ptest and dbus-ptest-ptest exists because
> > dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest
> > shouldn't be pulled in either. Does that make sense?
> > 
> > Cheers,
> > Paul
> 
> Hi Paul,
> 
> Thanks for your reply!
> But I still have a question.
> 
> I try to following way:
> 
> # git diff
> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> index bc260de..50dfe54 100644
> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"
> 
>   RDEPENDS_${PN} += "make"
>   RDEPENDS_${PN}-dev = ""
> +ALLOW_EMPTY_${PN} = "1"
> 
>   SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
>              file://tmpdir.patch \
> diff --git a/meta/recipes-core/dbus/dbus.inc
> b/meta/recipes-core/dbus/dbus.inc
> index 677ff78..ba7f3cb 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb
> 3c" DEPENDS = "expat virtual/libintl"
> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
> 'dbus-ptest-ptest', '', d)}"
> +RDEPENDS_dbus = "dbus-ptest"

The line above is the problem. You *cannot* do this or dbus-ptest (and 
therefore dbus-ptest-ptest) will always be installed whether you want it or 
not. You need to remove this line.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

On 03/14/2014 06:12 PM, Paul Eggleton wrote:
> On Friday 14 March 2014 17:14:27 Chong Lu wrote:
>> On 03/13/2014 06:01 PM, Paul Eggleton wrote:
>>> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
>>>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
>>>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>>>> +PACKAGES += "dbus-ptest"
>>>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
>>>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
>>>>>> 'ptest-pkgs',
>>>>>> 'dbus-test-ptest', 'dbus-test', d)}"
>>>>> Clearly I wasn't thinking clearly last week.  You can't check
>>>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
>>>> Do you have any suggestion about this issue?
>>>> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
>>>> that only build but not install ptest. I'm very confused.
>>> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is
>>> in
>>> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't matter
>>> if the dependency between dbus-ptest and dbus-ptest-ptest exists because
>>> dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest
>>> shouldn't be pulled in either. Does that make sense?
>>>
>>> Cheers,
>>> Paul
>> Hi Paul,
>>
>> Thanks for your reply!
>> But I still have a question.
>>
>> I try to following way:
>>
>> # git diff
>> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>> index bc260de..50dfe54 100644
>> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"
>>
>>    RDEPENDS_${PN} += "make"
>>    RDEPENDS_${PN}-dev = ""
>> +ALLOW_EMPTY_${PN} = "1"
>>
>>    SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
>>               file://tmpdir.patch \
>> diff --git a/meta/recipes-core/dbus/dbus.inc
>> b/meta/recipes-core/dbus/dbus.inc
>> index 677ff78..ba7f3cb 100644
>> --- a/meta/recipes-core/dbus/dbus.inc
>> +++ b/meta/recipes-core/dbus/dbus.inc
>> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
>>    LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb
>> 3c" DEPENDS = "expat virtual/libintl"
>> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
>> 'dbus-ptest-ptest', '', d)}"
>> +RDEPENDS_dbus = "dbus-ptest"
> The line above is the problem. You *cannot* do this or dbus-ptest (and
> therefore dbus-ptest-ptest) will always be installed whether you want it or
> not. You need to remove this line.
>
> Cheers,
> Paul
>
Hi Paul,

Do you mean the patch we only need to remove RDEPENDS_dbus = 
"${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', 
d)}" in dbus.inc ?
If do this, we can't build and install dbus-ptest through `bitbake dbus' 
command.
How to relate between dbus and dbus-ptest?

Best Regards
Chong

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Paul Eggleton]

On Monday 17 March 2014 10:09:28 Chong Lu wrote:
> On 03/14/2014 06:12 PM, Paul Eggleton wrote:
> > On Friday 14 March 2014 17:14:27 Chong Lu wrote:
> >> On 03/13/2014 06:01 PM, Paul Eggleton wrote:
> >>> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
> >>>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
> >>>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> >>>>>> +PACKAGES += "dbus-ptest"
> >>>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
> >>>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
> >>>>>> 'ptest-pkgs',
> >>>>>> 'dbus-test-ptest', 'dbus-test', d)}"
> >>>>> 
> >>>>> Clearly I wasn't thinking clearly last week.  You can't check
> >>>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
> >>>> 
> >>>> Do you have any suggestion about this issue?
> >>>> If we don't check IMAGE_FEATURES, I have no way to resolve this problem
> >>>> that only build but not install ptest. I'm very confused.
> >>> 
> >>> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest is
> >>> in
> >>> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't
> >>> matter
> >>> if the dependency between dbus-ptest and dbus-ptest-ptest exists because
> >>> dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest
> >>> shouldn't be pulled in either. Does that make sense?
> >>> 
> >>> Cheers,
> >>> Paul
> >> 
> >> Hi Paul,
> >> 
> >> Thanks for your reply!
> >> But I still have a question.
> >> 
> >> I try to following way:
> >> 
> >> # git diff
> >> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> index bc260de..50dfe54 100644
> >> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"
> >> 
> >>    RDEPENDS_${PN} += "make"
> >>    RDEPENDS_${PN}-dev = ""
> >> 
> >> +ALLOW_EMPTY_${PN} = "1"
> >> 
> >>    SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz
> >>    \
> >>    
> >>               file://tmpdir.patch \
> >> 
> >> diff --git a/meta/recipes-core/dbus/dbus.inc
> >> b/meta/recipes-core/dbus/dbus.inc
> >> index 677ff78..ba7f3cb 100644
> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
> >> 
> >>    LIC_FILES_CHKSUM =
> >>    "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >> 
> >> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a97453
> >> 8bb 3c" DEPENDS = "expat virtual/libintl"
> >> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
> >> 'dbus-ptest-ptest', '', d)}"
> >> +RDEPENDS_dbus = "dbus-ptest"
> > 
> > The line above is the problem. You *cannot* do this or dbus-ptest (and
> > therefore dbus-ptest-ptest) will always be installed whether you want it
> > or not. You need to remove this line.
> 
> Do you mean the patch we only need to remove RDEPENDS_dbus =
> "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '',
> d)}" in dbus.inc ?
> If do this, we can't build and install dbus-ptest through `bitbake dbus'
> command.
> How to relate between dbus and dbus-ptest?

Assuming you rename the current dbus-ptest recipe to dbus-test:

1) If the dbus recipe refers to dbus-test-ptest elsewhere (i.e. 
RDEPENDS_dbus-ptest = "dbus-test-ptest") then dbus-ptest will be built as 
needed.

2) If dbus is part of the image and ptest-pkgs is in IMAGE_FEATURES, the dbus-
ptest package (and therefore the dbus-test-ptest) will be brought in 
automatically. The relationship between dbus and dbus-ptest is solely on the 
name, you do not need to add any RDEPENDS for that part.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Paul Eggleton]

On Monday 17 March 2014 10:44:44 Paul Eggleton wrote:
> On Monday 17 March 2014 10:09:28 Chong Lu wrote:
> > On 03/14/2014 06:12 PM, Paul Eggleton wrote:
> > > On Friday 14 March 2014 17:14:27 Chong Lu wrote:
> > >> On 03/13/2014 06:01 PM, Paul Eggleton wrote:
> > >>> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
> > >>>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
> > >>>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
> > >>>>>> +PACKAGES += "dbus-ptest"
> > >>>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
> > >>>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
> > >>>>>> 'ptest-pkgs',
> > >>>>>> 'dbus-test-ptest', 'dbus-test', d)}"
> > >>>>> 
> > >>>>> Clearly I wasn't thinking clearly last week.  You can't check
> > >>>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
> > >>>> 
> > >>>> Do you have any suggestion about this issue?
> > >>>> If we don't check IMAGE_FEATURES, I have no way to resolve this
> > >>>> problem
> > >>>> that only build but not install ptest. I'm very confused.
> > >>> 
> > >>> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest
> > >>> is
> > >>> in
> > >>> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't
> > >>> matter
> > >>> if the dependency between dbus-ptest and dbus-ptest-ptest exists
> > >>> because
> > >>> dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest
> > >>> shouldn't be pulled in either. Does that make sense?
> > >>> 
> > >>> Cheers,
> > >>> Paul
> > >> 
> > >> Hi Paul,
> > >> 
> > >> Thanks for your reply!
> > >> But I still have a question.
> > >> 
> > >> I try to following way:
> > >> 
> > >> # git diff
> > >> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> > >> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> > >> index bc260de..50dfe54 100644
> > >> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> > >> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> > >> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"
> > >> 
> > >>    RDEPENDS_${PN} += "make"
> > >>    RDEPENDS_${PN}-dev = ""
> > >> 
> > >> +ALLOW_EMPTY_${PN} = "1"
> > >> 
> > >>    SRC_URI =
> > >>    "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz
> > >>    \
> > >>    
> > >>               file://tmpdir.patch \
> > >> 
> > >> diff --git a/meta/recipes-core/dbus/dbus.inc
> > >> b/meta/recipes-core/dbus/dbus.inc
> > >> index 677ff78..ba7f3cb 100644
> > >> --- a/meta/recipes-core/dbus/dbus.inc
> > >> +++ b/meta/recipes-core/dbus/dbus.inc
> > >> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
> > >> 
> > >>    LIC_FILES_CHKSUM =
> > >>    "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> > >> 
> > >> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974
> > >> 53
> > >> 8bb 3c" DEPENDS = "expat virtual/libintl"
> > >> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
> > >> 'dbus-ptest-ptest', '', d)}"
> > >> +RDEPENDS_dbus = "dbus-ptest"
> > > 
> > > The line above is the problem. You *cannot* do this or dbus-ptest (and
> > > therefore dbus-ptest-ptest) will always be installed whether you want it
> > > or not. You need to remove this line.
> > 
> > Do you mean the patch we only need to remove RDEPENDS_dbus =
> > "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '',
> > d)}" in dbus.inc ?
> > If do this, we can't build and install dbus-ptest through `bitbake dbus'
> > command.
> > How to relate between dbus and dbus-ptest?
> 
> Assuming you rename the current dbus-ptest recipe to dbus-test:
> 
> 1) If the dbus recipe refers to dbus-test-ptest elsewhere (i.e.
> RDEPENDS_dbus-ptest = "dbus-test-ptest") then dbus-ptest will be built as
> needed.

Sorry that should have been "dbus-test will be built as needed".

> 2) If dbus is part of the image and ptest-pkgs is in IMAGE_FEATURES, the
> dbus- ptest package (and therefore the dbus-test-ptest) will be brought in
> automatically. The relationship between dbus and dbus-ptest is solely on
> the name, you do not need to add any RDEPENDS for that part.

I should also mention that we need a fix for this soon in order to make the 1.6 
release (and we *really* don't want to release 1.6 with this issue.)

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] dbus: fix a hard dependency about dbus-ptest

[Chong Lu]

On 03/17/2014 07:05 PM, Paul Eggleton wrote:
> On Monday 17 March 2014 10:44:44 Paul Eggleton wrote:
>> On Monday 17 March 2014 10:09:28 Chong Lu wrote:
>>> On 03/14/2014 06:12 PM, Paul Eggleton wrote:
>>>> On Friday 14 March 2014 17:14:27 Chong Lu wrote:
>>>>> On 03/13/2014 06:01 PM, Paul Eggleton wrote:
>>>>>> On Thursday 13 March 2014 17:54:03 Chong Lu wrote:
>>>>>>> On 03/06/2014 06:04 PM, Burton, Ross wrote:
>>>>>>>> On 6 March 2014 08:06, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>>>>>>> +PACKAGES += "dbus-ptest"
>>>>>>>>> +ALLOW_EMPTY_${PN}-ptest = "1"
>>>>>>>>> +RDEPENDS_${PN}-ptest = "${@base_contains('IMAGE_FEATURES',
>>>>>>>>> 'ptest-pkgs',
>>>>>>>>> 'dbus-test-ptest', 'dbus-test', d)}"
>>>>>>>> Clearly I wasn't thinking clearly last week.  You can't check
>>>>>>>> IMAGE_FEATURES in a non-image recipe so this isn't a good solution.
>>>>>>> Do you have any suggestion about this issue?
>>>>>>> If we don't check IMAGE_FEATURES, I have no way to resolve this
>>>>>>> problem
>>>>>>> that only build but not install ptest. I'm very confused.
>>>>>> This should check DISTRO_FEATURES, not IMAGE_FEATURES. Assuming ptest
>>>>>> is
>>>>>> in
>>>>>> DISTRO_FEATURES, even if ptest is not in IMAGE_FEATURES it doesn't
>>>>>> matter
>>>>>> if the dependency between dbus-ptest and dbus-ptest-ptest exists
>>>>>> because
>>>>>> dbus- ptest itself shouldn't be in the image, so dbus-ptest-ptest
>>>>>> shouldn't be pulled in either. Does that make sense?
>>>>>>
>>>>>> Cheers,
>>>>>> Paul
>>>>> Hi Paul,
>>>>>
>>>>> Thanks for your reply!
>>>>> But I still have a question.
>>>>>
>>>>> I try to following way:
>>>>>
>>>>> # git diff
>>>>> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>>>>> b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>>>>> index bc260de..50dfe54 100644
>>>>> --- a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>>>>> +++ b/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>>>>> @@ -9,6 +9,7 @@ DEPENDS = "python-pygobject dbus dbus-glib"
>>>>>
>>>>>     RDEPENDS_${PN} += "make"
>>>>>     RDEPENDS_${PN}-dev = ""
>>>>>
>>>>> +ALLOW_EMPTY_${PN} = "1"
>>>>>
>>>>>     SRC_URI =
>>>>>     "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz
>>>>>     \
>>>>>     
>>>>>                file://tmpdir.patch \
>>>>>
>>>>> diff --git a/meta/recipes-core/dbus/dbus.inc
>>>>> b/meta/recipes-core/dbus/dbus.inc
>>>>> index 677ff78..ba7f3cb 100644
>>>>> --- a/meta/recipes-core/dbus/dbus.inc
>>>>> +++ b/meta/recipes-core/dbus/dbus.inc
>>>>> @@ -6,7 +6,7 @@ LICENSE = "AFL-2 | GPLv2+"
>>>>>
>>>>>     LIC_FILES_CHKSUM =
>>>>>     "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>>>>>
>>>>> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974
>>>>> 53
>>>>> 8bb 3c" DEPENDS = "expat virtual/libintl"
>>>>> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
>>>>> 'dbus-ptest-ptest', '', d)}"
>>>>> +RDEPENDS_dbus = "dbus-ptest"
>>>> The line above is the problem. You *cannot* do this or dbus-ptest (and
>>>> therefore dbus-ptest-ptest) will always be installed whether you want it
>>>> or not. You need to remove this line.
>>> Do you mean the patch we only need to remove RDEPENDS_dbus =
>>> "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '',
>>> d)}" in dbus.inc ?
>>> If do this, we can't build and install dbus-ptest through `bitbake dbus'
>>> command.
>>> How to relate between dbus and dbus-ptest?
>> Assuming you rename the current dbus-ptest recipe to dbus-test:
>>
>> 1) If the dbus recipe refers to dbus-test-ptest elsewhere (i.e.
>> RDEPENDS_dbus-ptest = "dbus-test-ptest") then dbus-ptest will be built as
>> needed.
> Sorry that should have been "dbus-test will be built as needed".
>
>> 2) If dbus is part of the image and ptest-pkgs is in IMAGE_FEATURES, the
>> dbus- ptest package (and therefore the dbus-test-ptest) will be brought in
>> automatically. The relationship between dbus and dbus-ptest is solely on
>> the name, you do not need to add any RDEPENDS for that part.
> I should also mention that we need a fix for this soon in order to make the 1.6
> release (and we *really* don't want to release 1.6 with this issue.)
>
> Thanks,
> Paul
>
Thanks a lot. I will send a V2, please check it.

Chong