* [PATCH] lkdtm: include cacheflush.h
@ 2014-02-14 23:58 Kees Cook
2014-03-21 18:31 ` Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2014-02-14 23:58 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Fengguang Wu, Arnd Bergmann
Some architectures need cacheflush.h explicitly included (mips) for
use of flush_icache_range():
config: make ARCH=mips allmodconfig
All error/warnings:
>> ERROR: "flush_icache_range" undefined!
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/misc/lkdtm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
index 47ed2d321351..2ebd52e05773 100644
--- a/drivers/misc/lkdtm.c
+++ b/drivers/misc/lkdtm.c
@@ -46,6 +46,7 @@
#include <linux/debugfs.h>
#include <linux/vmalloc.h>
#include <linux/mman.h>
+#include <asm/cacheflush.h>
#ifdef CONFIG_IDE
#include <linux/ide.h>
--
1.7.9.5
--
Kees Cook
Chrome OS Security
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] lkdtm: include cacheflush.h
2014-02-14 23:58 [PATCH] lkdtm: include cacheflush.h Kees Cook
@ 2014-03-21 18:31 ` Paul Gortmaker
2014-03-21 19:33 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2014-03-21 18:31 UTC (permalink / raw)
To: Kees Cook
Cc: Greg Kroah-Hartman, LKML, Fengguang Wu, Arnd Bergmann, linux-next
On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@chromium.org> wrote:
> Some architectures need cacheflush.h explicitly included (mips) for
> use of flush_icache_range():
>
> config: make ARCH=mips allmodconfig
> All error/warnings:
> >> ERROR: "flush_icache_range" undefined!
The linux-next builds still fail with a similar error:
http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
I'm not sure if it ever was a compile error, or if it was always
a missing export symbol type error as it is apparently now.
Paul.
--
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/misc/lkdtm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
> index 47ed2d321351..2ebd52e05773 100644
> --- a/drivers/misc/lkdtm.c
> +++ b/drivers/misc/lkdtm.c
> @@ -46,6 +46,7 @@
> #include <linux/debugfs.h>
> #include <linux/vmalloc.h>
> #include <linux/mman.h>
> +#include <asm/cacheflush.h>
>
> #ifdef CONFIG_IDE
> #include <linux/ide.h>
> --
> 1.7.9.5
>
>
> --
> Kees Cook
> Chrome OS Security
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lkdtm: include cacheflush.h
2014-03-21 18:31 ` Paul Gortmaker
@ 2014-03-21 19:33 ` Kees Cook
2014-03-21 19:36 ` Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2014-03-21 19:33 UTC (permalink / raw)
To: Paul Gortmaker, Greg Kroah-Hartman
Cc: LKML, Fengguang Wu, Arnd Bergmann, linux-next
On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@chromium.org> wrote:
>> Some architectures need cacheflush.h explicitly included (mips) for
>> use of flush_icache_range():
>>
>> config: make ARCH=mips allmodconfig
>> All error/warnings:
>> >> ERROR: "flush_icache_range" undefined!
>
> The linux-next builds still fail with a similar error:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
>
> I'm not sure if it ever was a compile error, or if it was always
> a missing export symbol type error as it is apparently now.
It seems no one picked up this fix? Greg, you normally take my lkdtm work...
-Kees
>
> Paul.
> --
>
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> drivers/misc/lkdtm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>> index 47ed2d321351..2ebd52e05773 100644
>> --- a/drivers/misc/lkdtm.c
>> +++ b/drivers/misc/lkdtm.c
>> @@ -46,6 +46,7 @@
>> #include <linux/debugfs.h>
>> #include <linux/vmalloc.h>
>> #include <linux/mman.h>
>> +#include <asm/cacheflush.h>
>>
>> #ifdef CONFIG_IDE
>> #include <linux/ide.h>
>> --
>> 1.7.9.5
>>
>>
>> --
>> Kees Cook
>> Chrome OS Security
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lkdtm: include cacheflush.h
2014-03-21 19:33 ` Kees Cook
@ 2014-03-21 19:36 ` Paul Gortmaker
2014-03-22 15:32 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2014-03-21 19:36 UTC (permalink / raw)
To: Kees Cook, Greg Kroah-Hartman
Cc: LKML, Fengguang Wu, Arnd Bergmann, linux-next
On 14-03-21 03:33 PM, Kees Cook wrote:
> On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@chromium.org> wrote:
>>> Some architectures need cacheflush.h explicitly included (mips) for
>>> use of flush_icache_range():
>>>
>>> config: make ARCH=mips allmodconfig
>>> All error/warnings:
>>> >> ERROR: "flush_icache_range" undefined!
>>
>> The linux-next builds still fail with a similar error:
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
>>
>> I'm not sure if it ever was a compile error, or if it was always
>> a missing export symbol type error as it is apparently now.
>
> It seems no one picked up this fix? Greg, you normally take my lkdtm work...
No, the "fix" is there, in linux-next, but it doesn't work. :)
Paul.
--
>
> -Kees
>
>>
>> Paul.
>> --
>>
>>>
>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>> ---
>>> drivers/misc/lkdtm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>>> index 47ed2d321351..2ebd52e05773 100644
>>> --- a/drivers/misc/lkdtm.c
>>> +++ b/drivers/misc/lkdtm.c
>>> @@ -46,6 +46,7 @@
>>> #include <linux/debugfs.h>
>>> #include <linux/vmalloc.h>
>>> #include <linux/mman.h>
>>> +#include <asm/cacheflush.h>
>>>
>>> #ifdef CONFIG_IDE
>>> #include <linux/ide.h>
>>> --
>>> 1.7.9.5
>>>
>>>
>>> --
>>> Kees Cook
>>> Chrome OS Security
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lkdtm: include cacheflush.h
2014-03-21 19:36 ` Paul Gortmaker
@ 2014-03-22 15:32 ` Kees Cook
0 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2014-03-22 15:32 UTC (permalink / raw)
To: Paul Gortmaker
Cc: Greg Kroah-Hartman, LKML, Fengguang Wu, Arnd Bergmann, linux-next
On Fri, Mar 21, 2014 at 1:36 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On 14-03-21 03:33 PM, Kees Cook wrote:
>> On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker
>> <paul.gortmaker@windriver.com> wrote:
>>> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@chromium.org> wrote:
>>>> Some architectures need cacheflush.h explicitly included (mips) for
>>>> use of flush_icache_range():
>>>>
>>>> config: make ARCH=mips allmodconfig
>>>> All error/warnings:
>>>> >> ERROR: "flush_icache_range" undefined!
>>>
>>> The linux-next builds still fail with a similar error:
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
>>>
>>> I'm not sure if it ever was a compile error, or if it was always
>>> a missing export symbol type error as it is apparently now.
>>
>> It seems no one picked up this fix? Greg, you normally take my lkdtm work...
>
> No, the "fix" is there, in linux-next, but it doesn't work. :)
Oh! So it is. Does anyone have a MIPS builder available to figure out
the right fix? I'll try to get a cross builder set up for this.
A more careful look at this would seem to indicate the problem is the
lack of an EXPORT, rather than the missing declaration. I'll dig in to
this.
Sorry for the noise!
-Kees
>
> Paul.
> --
>
>>
>> -Kees
>>
>>>
>>> Paul.
>>> --
>>>
>>>>
>>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>>> ---
>>>> drivers/misc/lkdtm.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>>>> index 47ed2d321351..2ebd52e05773 100644
>>>> --- a/drivers/misc/lkdtm.c
>>>> +++ b/drivers/misc/lkdtm.c
>>>> @@ -46,6 +46,7 @@
>>>> #include <linux/debugfs.h>
>>>> #include <linux/vmalloc.h>
>>>> #include <linux/mman.h>
>>>> +#include <asm/cacheflush.h>
>>>>
>>>> #ifdef CONFIG_IDE
>>>> #include <linux/ide.h>
>>>> --
>>>> 1.7.9.5
>>>>
>>>>
>>>> --
>>>> Kees Cook
>>>> Chrome OS Security
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>> Please read the FAQ at http://www.tux.org/lkml/
>>
>>
>>
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-22 15:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 23:58 [PATCH] lkdtm: include cacheflush.h Kees Cook
2014-03-21 18:31 ` Paul Gortmaker
2014-03-21 19:33 ` Kees Cook
2014-03-21 19:36 ` Paul Gortmaker
2014-03-22 15:32 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.