All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>,
	Jean Delvare <jdelvare@suse.de>
Cc: David Dajun Chen <david.chen@diasemi.com>,
	LINUX-DOC <linux-doc@vger.kernel.org>,
	LINUX-KERNEL <linux-kernel@vger.kernel.org>,
	LM-SENSORS <lm-sensors@lm-sensors.org>,
	Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Landley <rob@landley.net>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [RFC V1 1/3] hwmon: da9063: HWMON driver
Date: Sun, 23 Mar 2014 20:39:25 -0700	[thread overview]
Message-ID: <532FA8ED.2090201@roeck-us.net> (raw)
In-Reply-To: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com>

On 03/23/2014 01:37 PM, Opensource [Steve Twiss] wrote:
> From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
>
> Add the HWMON driver for DA9063
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
> ---
> Checks performed with linux-next/next-20140321/scripts/checkpatch.pl
>   da9063-hwmon.c            total: 0 errors, 0 warnings, 456 lines checked
>   Kconfig                   total: 1 errors, 3 warnings, 1643 lines checked
>   Makefile                  total: 0 errors, 0 warnings, 154 lines checked
>   registers.h               total: 0 errors, 0 warnings, 1066 lines checked
> There are errors and warning in Kconfig, however they are not caused
> by this patch.
>
> This is the hardware monitor driver component for DA9063 PMIC.
>
> The manual measurement allows monitoring of the system voltage
> VSYS, the auxiliary channels ADCIN1, ADCIN2 and ADCIN3, VBBAT
> measures of the backup battery voltage and a Tjunc value for the
> internal junction temperature sensor.
>

At least this part belongs into the summary.

After browsing through patch 2/3, I got suspicious and tried to compile
the driver after applying this patch.

Here is the result:

drivers/hwmon/da9063-hwmon.c: In function 'da9063_adc_manual_read':
drivers/hwmon/da9063-hwmon.c:155:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
drivers/hwmon/da9063-hwmon.c: In function 'da9063_hwmon_probe':
drivers/hwmon/da9063-hwmon.c:386:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:387:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:388:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:417:50: error: 'struct da9063' has no member named 't_offset'
make[1]: *** [drivers/hwmon/da9063-hwmon.o] Error 1
make: *** [drivers/hwmon/da9063-hwmon.ko] Error 2

Please make sure that each patch, if applied one after another, compiles.
Patch 1/3 must not depend on patch 2/3.

Thanks,
Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>,
	Jean Delvare <jdelvare@suse.de>
Cc: David Dajun Chen <david.chen@diasemi.com>,
	LINUX-DOC <linux-doc@vger.kernel.org>,
	LINUX-KERNEL <linux-kernel@vger.kernel.org>,
	LM-SENSORS <lm-sensors@lm-sensors.org>,
	Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Landley <rob@landley.net>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [lm-sensors] [RFC V1 1/3] hwmon: da9063: HWMON driver
Date: Mon, 24 Mar 2014 03:39:25 +0000	[thread overview]
Message-ID: <532FA8ED.2090201@roeck-us.net> (raw)
In-Reply-To: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com>

On 03/23/2014 01:37 PM, Opensource [Steve Twiss] wrote:
> From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
>
> Add the HWMON driver for DA9063
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
> ---
> Checks performed with linux-next/next-20140321/scripts/checkpatch.pl
>   da9063-hwmon.c            total: 0 errors, 0 warnings, 456 lines checked
>   Kconfig                   total: 1 errors, 3 warnings, 1643 lines checked
>   Makefile                  total: 0 errors, 0 warnings, 154 lines checked
>   registers.h               total: 0 errors, 0 warnings, 1066 lines checked
> There are errors and warning in Kconfig, however they are not caused
> by this patch.
>
> This is the hardware monitor driver component for DA9063 PMIC.
>
> The manual measurement allows monitoring of the system voltage
> VSYS, the auxiliary channels ADCIN1, ADCIN2 and ADCIN3, VBBAT
> measures of the backup battery voltage and a Tjunc value for the
> internal junction temperature sensor.
>

At least this part belongs into the summary.

After browsing through patch 2/3, I got suspicious and tried to compile
the driver after applying this patch.

Here is the result:

drivers/hwmon/da9063-hwmon.c: In function 'da9063_adc_manual_read':
drivers/hwmon/da9063-hwmon.c:155:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
drivers/hwmon/da9063-hwmon.c: In function 'da9063_hwmon_probe':
drivers/hwmon/da9063-hwmon.c:386:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:387:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:388:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata'
drivers/hwmon/da9063-hwmon.c:417:50: error: 'struct da9063' has no member named 't_offset'
make[1]: *** [drivers/hwmon/da9063-hwmon.o] Error 1
make: *** [drivers/hwmon/da9063-hwmon.ko] Error 2

Please make sure that each patch, if applied one after another, compiles.
Patch 1/3 must not depend on patch 2/3.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-03-24  3:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23 20:37 [RFC V1 0/3] da9063: Addition of HWMON support for DA9063 Opensource [Steve Twiss]
2014-03-23 20:37 ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 1/3] hwmon: da9063: HWMON driver Opensource [Steve Twiss]
2014-03-23 20:37   ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-24  3:27   ` Guenter Roeck
2014-03-24  3:27     ` [lm-sensors] " Guenter Roeck
2014-03-24  3:39   ` Guenter Roeck [this message]
2014-03-24  3:39     ` Guenter Roeck
2014-03-24  7:48     ` Opensource [Steve Twiss]
2014-03-24  7:48       ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-24  9:24       ` Lee Jones
2014-03-24  9:24         ` [lm-sensors] " Lee Jones
2014-03-24  7:52   ` Lee Jones
2014-03-24  7:52     ` [lm-sensors] " Lee Jones
2014-03-24  8:12     ` Opensource [Steve Twiss]
2014-03-24  8:12       ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 2/3] mfd: da9063: Add HWMON dependencies Opensource [Steve Twiss]
2014-03-23 20:37   ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-24  8:02   ` Lee Jones
2014-03-24  8:02     ` [lm-sensors] " Lee Jones
2014-03-24  8:28     ` Opensource [Steve Twiss]
2014-03-24  8:28       ` [lm-sensors] " Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 3/3] Documentation: hwmon: New information for DA9063 Opensource [Steve Twiss]
2014-03-23 20:37   ` [lm-sensors] " Opensource [Steve Twiss]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532FA8ED.2090201@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=broonie@linaro.org \
    --cc=david.chen@diasemi.com \
    --cc=jdelvare@suse.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rob@landley.net \
    --cc=sameo@linux.intel.com \
    --cc=stwiss.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.