Re: mcp25xxfd: missing cerrif

[Marc Kleine-Budde <mkl@pengutronix.de>]

On 2/11/20 2:31 PM, Thomas.Kopp@microchip.com wrote:
>>> - The transmitter or receiver transitions from Error Passive to Error
>>>   Active state

>> I don't see this interrupt, neither on the mcp2517fd nor on the
>> mcp2518fd rev0.0.
> 
> What do you mean you don't see the interrupt?

If the chip transitions from Error Passive to Error Active state the
CERRIF is not set.

> I just did a quick test (non linux environment but with our test
> board and I do see CERRIF being set and it's possible to clear via
> SPI). What exactly are you checking?
Below code is from the driver and illustrates the problem:

> 		/* On the MCP2527FD and MCP2518FD, we don't get a
> 		 * CERRIF IRQ on the transition TX ERROR_WARNING -> TX
> 		 * ERROR_ACTIVE.
> 		 */
> 		if (intf_pending & MCP25XXFD_CAN_INT_CERRIF ||
> 		    priv->can.state > CAN_STATE_ERROR_ACTIVE) {
> 			err = mcp25xxfd_handle(priv, cerrif);
> 			if (err)
> 				goto out_fail;
> 		}

On the transition from "TX ERROR_WARNING -> TX ERROR_ACTIVE" the CERRIF
is not set.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |