All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Thomas.Kopp@microchip.com>
To: mkl@pengutronix.de, linux-can@vger.kernel.org
Subject: RE: mcp25xxfd: missing cerrif
Date: Wed, 12 Feb 2020 09:59:17 +0000	[thread overview]
Message-ID: <MN2PR11MB36458E1696285A0196B6E46FFB1B0@MN2PR11MB3645.namprd11.prod.outlook.com> (raw)
In-Reply-To: <532b4fed-a984-0875-d933-43c6a90fcc1a@pengutronix.de>

> On the transition from "TX ERROR_WARNING -> TX ERROR_ACTIVE" the
> CERRIF
> is not set.

Mhm, do I misunderstand your point here? The Transition TX ERROR_WARNING -> TX ERROR_ACTIVE isn't covered by the CERRIF interrupt (which matches the documentation). The interrupt bit gets set on ERROR_Passive to ERROR_ACTIVE (TEC/REC goes from 128 to 127). At that transition I do see the CERRIF bit. It is correct and intended (though maybe not 100% intuitive) that going from ERROR_WARNING to ERROR_ACTIVE TEC/REC 96 to 95 CERRIF is NOT being set.

Best Regards,
Thomas

  reply	other threads:[~2020-02-12  9:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 12:53 mcp25xxfd: missing cerrif Marc Kleine-Budde
2020-02-11 13:31 ` Thomas.Kopp
2020-02-11 13:51   ` Marc Kleine-Budde
2020-02-12  9:59     ` Thomas.Kopp [this message]
2020-02-14 13:59       ` Marc Kleine-Budde
2020-02-18 11:44         ` Thomas.Kopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB36458E1696285A0196B6E46FFB1B0@MN2PR11MB3645.namprd11.prod.outlook.com \
    --to=thomas.kopp@microchip.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.