* [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant
@ 2016-01-12 1:15 Antonio Quartulli
2016-01-13 8:40 ` Sven Eckelmann
2016-01-17 8:49 ` Marek Lindner
0 siblings, 2 replies; 3+ messages in thread
From: Antonio Quartulli @ 2016-01-12 1:15 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
of the bat_neigh_is_similar_or_better() API function.
Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
constant.
Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
constant.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
net/batman-adv/main.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 32dfc9e..8c01f54 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -100,11 +100,6 @@
*/
#define BATADV_TQ_SIMILARITY_THRESHOLD 50
-/* how much worse secondary interfaces may be to be considered as bonding
- * candidates
- */
-#define BATADV_BONDING_TQ_THRESHOLD 50
-
/* should not be bigger than 512 bytes or change the size of
* forw_packet->direct_link_flags
*/
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant
2016-01-12 1:15 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant Antonio Quartulli
@ 2016-01-13 8:40 ` Sven Eckelmann
2016-01-17 8:49 ` Marek Lindner
1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2016-01-13 8:40 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Tuesday 12 January 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
>
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Just in case somebody else is interested since when it is not used anymore:
a64108267584 ("batman-adv: adapt bonding to use the new API functions")
This is in v2014.0.0/v3.13. So it should be fine to remove it :)
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant
2016-01-12 1:15 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant Antonio Quartulli
2016-01-13 8:40 ` Sven Eckelmann
@ 2016-01-17 8:49 ` Marek Lindner
1 sibling, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2016-01-17 8:49 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Tuesday, January 12, 2016 09:15:25 Antonio Quartulli wrote:
> BATADV_BONDING_TQ_THRESHOLD is not used anymore since the implementation
> of the bat_neigh_is_similar_or_better() API function.
> Such function uses the more generic BATADV_TQ_SIMILARITY_THRESHOLD
> constant.
>
> Therefore, remove definition of the unused BATADV_BONDING_TQ_THRESHOLD
> constant.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/main.h | 5 -----
> 1 file changed, 5 deletions(-)
Applied in revision 82b7d70.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-17 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 1:15 [B.A.T.M.A.N.] [PATCH] batman-adv: remove unused BATADV_BONDING_TQ_THRESHOLD constant Antonio Quartulli
2016-01-13 8:40 ` Sven Eckelmann
2016-01-17 8:49 ` Marek Lindner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.