From: Tomasz Figa <t.figa@samsung.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Cc: jic23@kernel.org, ch.naveen@samsung.com, kgene.kim@samsung.com, linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kyungmin Park <kyungmin.park@samsung.com> Subject: Re: [PATCH] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Date: Fri, 11 Apr 2014 12:56:17 +0200 [thread overview] Message-ID: <5347CA51.8020003@samsung.com> (raw) In-Reply-To: <18632148.yOYlTYattA@amdc1032> Hi, On 11.04.2014 11:41, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, April 11, 2014 11:00:40 AM Chanwoo Choi wrote: >> This patch control special clock for ADC in Exynos series's FSYS block. > > s/control/controls/ > >> If special clock of ADC is registerd on clock list of common clk framework, >> Exynos ADC drvier have to control this clock. > > s/drvier/driver/ > >> Exynos3250/Exynos4/Exynos5 has 'adc' clock as following: >> - 'adc' clock: bus clock for ADC >> >> Exynos3250 has additional 'sclk_tsadc' clock as following: >> - 'sclk_tsadc' clock: special clock for ADC which provide clock to internal ADC >> >> Exynos 4210/4212/4412 and Exynos5250/5420 has not included 'sclk_tsadc' clock >> in FSYS_BLK. But, Exynos3250 based on Cortex-A7 has only included 'sclk_tsadc' >> clock in FSYS_BLK. >> >> Cc: Jonathan Cameron <jic23@kernel.org> >> Cc: Kukjin Kim <kgene.kim@samsung.com> >> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: linux-iio@vger.kernel.org >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> drivers/iio/adc/exynos_adc.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) This change alters DT bindings for Exynos ADC, so documentation must be modified appropriately. >> >> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c >> index d25b262..4cd1975 100644 >> --- a/drivers/iio/adc/exynos_adc.c >> +++ b/drivers/iio/adc/exynos_adc.c >> @@ -88,6 +88,7 @@ struct exynos_adc { >> void __iomem *regs; >> void __iomem *enable_reg; >> struct clk *clk; >> + struct clk *sclk; >> unsigned int irq; >> struct regulator *vdd; >> >> @@ -308,6 +309,13 @@ static int exynos_adc_probe(struct platform_device *pdev) >> goto err_irq; >> } >> >> + info->sclk = devm_clk_get(&pdev->dev, "sclk_tsadc"); >> + if (IS_ERR(info->sclk)) { >> + dev_warn(&pdev->dev, "failed getting sclk clock, err = %ld\n", >> + PTR_ERR(info->sclk)); >> + info->sclk = NULL; >> + } >> + Is there any reason why we should have a warning on SoCs which don't have this clock? I think this clock should be acquired only for affected SoCs. Best regards, Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Date: Fri, 11 Apr 2014 12:56:17 +0200 [thread overview] Message-ID: <5347CA51.8020003@samsung.com> (raw) In-Reply-To: <18632148.yOYlTYattA@amdc1032> Hi, On 11.04.2014 11:41, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Friday, April 11, 2014 11:00:40 AM Chanwoo Choi wrote: >> This patch control special clock for ADC in Exynos series's FSYS block. > > s/control/controls/ > >> If special clock of ADC is registerd on clock list of common clk framework, >> Exynos ADC drvier have to control this clock. > > s/drvier/driver/ > >> Exynos3250/Exynos4/Exynos5 has 'adc' clock as following: >> - 'adc' clock: bus clock for ADC >> >> Exynos3250 has additional 'sclk_tsadc' clock as following: >> - 'sclk_tsadc' clock: special clock for ADC which provide clock to internal ADC >> >> Exynos 4210/4212/4412 and Exynos5250/5420 has not included 'sclk_tsadc' clock >> in FSYS_BLK. But, Exynos3250 based on Cortex-A7 has only included 'sclk_tsadc' >> clock in FSYS_BLK. >> >> Cc: Jonathan Cameron <jic23@kernel.org> >> Cc: Kukjin Kim <kgene.kim@samsung.com> >> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: linux-iio at vger.kernel.org >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> drivers/iio/adc/exynos_adc.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) This change alters DT bindings for Exynos ADC, so documentation must be modified appropriately. >> >> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c >> index d25b262..4cd1975 100644 >> --- a/drivers/iio/adc/exynos_adc.c >> +++ b/drivers/iio/adc/exynos_adc.c >> @@ -88,6 +88,7 @@ struct exynos_adc { >> void __iomem *regs; >> void __iomem *enable_reg; >> struct clk *clk; >> + struct clk *sclk; >> unsigned int irq; >> struct regulator *vdd; >> >> @@ -308,6 +309,13 @@ static int exynos_adc_probe(struct platform_device *pdev) >> goto err_irq; >> } >> >> + info->sclk = devm_clk_get(&pdev->dev, "sclk_tsadc"); >> + if (IS_ERR(info->sclk)) { >> + dev_warn(&pdev->dev, "failed getting sclk clock, err = %ld\n", >> + PTR_ERR(info->sclk)); >> + info->sclk = NULL; >> + } >> + Is there any reason why we should have a warning on SoCs which don't have this clock? I think this clock should be acquired only for affected SoCs. Best regards, Tomasz
next prev parent reply other threads:[~2014-04-11 10:56 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-11 2:00 [PATCH] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Chanwoo Choi 2014-04-11 2:00 ` Chanwoo Choi 2014-04-11 2:00 ` Chanwoo Choi 2014-04-11 9:41 ` Bartlomiej Zolnierkiewicz 2014-04-11 9:41 ` Bartlomiej Zolnierkiewicz 2014-04-11 9:41 ` Bartlomiej Zolnierkiewicz 2014-04-11 10:56 ` Tomasz Figa [this message] 2014-04-11 10:56 ` Tomasz Figa 2014-04-11 22:52 ` 최찬우 2014-04-11 22:52 ` 최찬우 2014-04-11 22:45 ` 최찬우 2014-04-11 22:45 ` 최찬우 2014-04-11 22:45 ` 최찬우 2014-04-12 7:49 ` Jonathan Cameron 2014-04-12 7:49 ` Jonathan Cameron 2014-04-12 7:49 ` Jonathan Cameron 2014-04-14 0:58 ` Chanwoo Choi 2014-04-14 0:58 ` Chanwoo Choi 2014-04-14 0:58 ` Chanwoo Choi 2014-04-11 10:05 ` Sylwester Nawrocki 2014-04-11 10:05 ` Sylwester Nawrocki 2014-04-11 22:49 ` 최찬우 2014-04-11 22:49 ` 최찬우
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5347CA51.8020003@samsung.com \ --to=t.figa@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=ch.naveen@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=jic23@kernel.org \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.