* [PATCH] MIPS: Fix 'write_msa_##' inline macro.
@ 2014-04-11 14:57 Steven J. Hill
2014-04-11 15:01 ` Markos Chandras
0 siblings, 1 reply; 3+ messages in thread
From: Steven J. Hill @ 2014-04-11 14:57 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
The 'write_msa_##' macro incorrectly uses the 'cfcmsa'
instruction, which should be the 'ctcmmsa' instruction.
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
Reviewed-by: Paul Burton <Paul.Burton@imgtec.com>
---
arch/mips/include/asm/msa.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/msa.h b/arch/mips/include/asm/msa.h
index a2aba6c..baddc5f 100644
--- a/arch/mips/include/asm/msa.h
+++ b/arch/mips/include/asm/msa.h
@@ -84,7 +84,7 @@ static inline void write_msa_##name(unsigned int val) \
__asm__ __volatile__( \
" .set push\n" \
" .set msa\n" \
- " cfcmsa $" #cs ", %0\n" \
+ " ctcmsa $" #cs ", %0\n" \
" .set pop\n" \
: : "r"(val)); \
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix 'write_msa_##' inline macro.
@ 2014-04-11 15:01 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2014-04-11 15:01 UTC (permalink / raw)
To: linux-mips
Hi Steven,
On 04/11/2014 03:57 PM, Steven J. Hill wrote:
> instruction, which should be the 'ctcmmsa' instruction.
I guess this is a typo? ^^^ (double 'mm' in 'ctcmmsa')
--
markos
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix 'write_msa_##' inline macro.
@ 2014-04-11 15:01 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2014-04-11 15:01 UTC (permalink / raw)
To: linux-mips
Hi Steven,
On 04/11/2014 03:57 PM, Steven J. Hill wrote:
> instruction, which should be the 'ctcmmsa' instruction.
I guess this is a typo? ^^^ (double 'mm' in 'ctcmmsa')
--
markos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-11 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11 14:57 [PATCH] MIPS: Fix 'write_msa_##' inline macro Steven J. Hill
2014-04-11 15:01 ` Markos Chandras
2014-04-11 15:01 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.