[PATCH] gpio: kempld: Fix autoloading of module

[PATCH] gpio: kempld: Fix autoloading of module

[Axel Lin]

Make the module alias match the platform device name, so gpio-kempld module
should now autoload correctly.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/gpio-kempld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
index c6d8817..ebe1023 100644
--- a/drivers/gpio/gpio-kempld.c
+++ b/drivers/gpio/gpio-kempld.c
@@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
 MODULE_DESCRIPTION("KEM PLD GPIO Driver");
 MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:gpio-kempld");
+MODULE_ALIAS("platform:kempld-gpio");
-- 
1.8.3.2

Re: [PATCH] gpio: kempld: Fix autoloading of module

[Guenter Roeck]

On 04/11/2014 09:45 PM, Axel Lin wrote:
> Make the module alias match the platform device name, so gpio-kempld module
> should now autoload correctly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/gpio/gpio-kempld.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
> index c6d8817..ebe1023 100644
> --- a/drivers/gpio/gpio-kempld.c
> +++ b/drivers/gpio/gpio-kempld.c
> @@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
>   MODULE_DESCRIPTION("KEM PLD GPIO Driver");
>   MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:gpio-kempld");
> +MODULE_ALIAS("platform:kempld-gpio");
>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Wonder though if the module alias is necessary in the first place,
as the driver is instantiated from the mfd driver.

Guenter

Re: [PATCH] gpio: kempld: Fix autoloading of module

[Axel Lin]

2014-04-13 0:58 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
> On 04/11/2014 09:45 PM, Axel Lin wrote:
>>
>> Make the module alias match the platform device name, so gpio-kempld
>> module
>> should now autoload correctly.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>>   drivers/gpio/gpio-kempld.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
>> index c6d8817..ebe1023 100644
>> --- a/drivers/gpio/gpio-kempld.c
>> +++ b/drivers/gpio/gpio-kempld.c
>> @@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
>>   MODULE_DESCRIPTION("KEM PLD GPIO Driver");
>>   MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
>>   MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:gpio-kempld");
>> +MODULE_ALIAS("platform:kempld-gpio");
>>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Wonder though if the module alias is necessary in the first place,
> as the driver is instantiated from the mfd driver.

The mfd driver calls mfd_add_devices() to add kempld-gpio device.
In the case if kempld-gpio driver is built as a module and not yet
be loaded to the system, the module alias is required to make module
autoloading work.

Regards,
Axel

Re: [PATCH] gpio: kempld: Fix autoloading of module

[Linus Walleij]

On Sat, Apr 12, 2014 at 6:45 AM, Axel Lin <axel.lin@ingics.com> wrote:

> Make the module alias match the platform device name, so gpio-kempld module
> should now autoload correctly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied with Günther's Review tag.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html