All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	"t.figa@samsung.com" <t.figa@samsung.com>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"thomas.abraham@linaro.org" <thomas.abraham@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Inki Dae <inki.dae@samsung.com>, Rob Herring <robh+dt@kernel.org>,
	"ben-linux@fluff.org" <ben-linux@fluff.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"hyunhee.kim@samsung.com" <hyunhee.kim@samsung.com>,
	"sw0312.kim@samsung.com" <sw0312.kim@samsung.com>,
	linux-ker
Subject: Re: [PATCHv2 8/8] ARM: dts: Add device tree sources for Exynos3250
Date: Tue, 15 Apr 2014 10:24:39 +0100	[thread overview]
Message-ID: <534CFAD7.4030508@arm.com> (raw)
In-Reply-To: <534CF9B4.306@samsung.com>

On 15/04/14 10:19, Chanwoo Choi wrote:
> On 04/15/2014 06:13 PM, Marc Zyngier wrote:
>> On 15/04/14 09:27, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 04/15/2014 05:15 PM, Marc Zyngier wrote:
>>>> On 15/04/14 02:59, Chanwoo Choi wrote:
>>>>> From: Tomasz Figa <t.figa@samsung.com>
>>>>>
>>>>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on Cortex-A7
>>>>> dual core and includes following dt nodes:
>>>>>
>>>>> - GIC interrupt controller
>>>>> - Pinctrl to control GPIOs
>>>>> - Clock controller
>>>>> - CPU information (Cortex-A7 dual core)
>>>>> - UART to support serial port
>>>>> - MCT (Multi Core Timer)
>>>>> - ADC (Analog Digital Converter)
>>>>> - I2C/SPI bus
>>>>> - Power domain
>>>>> - PMU (Performance Monitoring Unit)
>>>>> - MSHC (Mobile Storage Host Controller)
>>>>> - PWM (Pluse Width Modulation)
>>>>> - AMBA bus
>>>>
>>>> [...]
>>>>
>>>> Where is the arch timer node?
>>>
>>> Exynos3250 uses MCT (Multi Core Timer) instead of ARM_ARCH_TIMER.
>>> - in drivers/clocksource/exynos_mct.c
>>
>> Don't you have a Cortex-A7? If so, you have the arch timer.
> 
> Do you means that 'arch timer" is ARM_ARCH_TIMER?

Yes.

> As I knew, ARM_ARCH_TIMER is clocksource driver for system timer.
> But, Exynos SoC used MCT clocksource for system timer.
> 
> Exynos dts file didn't include arch timer node but only include mct node.

Well, it is a bug, and a recurrent one. A Cortex-A7 has the arch timers
implemented. Always.

http://infocenter.arm.com/help/topic/com.arm.doc.ddi0464f/BABFEBJJ.html

All Cortex-A7 have it, and so do A12, A15, A17, A53, A57.

Cheers,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 8/8] ARM: dts: Add device tree sources for Exynos3250
Date: Tue, 15 Apr 2014 10:24:39 +0100	[thread overview]
Message-ID: <534CFAD7.4030508@arm.com> (raw)
In-Reply-To: <534CF9B4.306@samsung.com>

On 15/04/14 10:19, Chanwoo Choi wrote:
> On 04/15/2014 06:13 PM, Marc Zyngier wrote:
>> On 15/04/14 09:27, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 04/15/2014 05:15 PM, Marc Zyngier wrote:
>>>> On 15/04/14 02:59, Chanwoo Choi wrote:
>>>>> From: Tomasz Figa <t.figa@samsung.com>
>>>>>
>>>>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on Cortex-A7
>>>>> dual core and includes following dt nodes:
>>>>>
>>>>> - GIC interrupt controller
>>>>> - Pinctrl to control GPIOs
>>>>> - Clock controller
>>>>> - CPU information (Cortex-A7 dual core)
>>>>> - UART to support serial port
>>>>> - MCT (Multi Core Timer)
>>>>> - ADC (Analog Digital Converter)
>>>>> - I2C/SPI bus
>>>>> - Power domain
>>>>> - PMU (Performance Monitoring Unit)
>>>>> - MSHC (Mobile Storage Host Controller)
>>>>> - PWM (Pluse Width Modulation)
>>>>> - AMBA bus
>>>>
>>>> [...]
>>>>
>>>> Where is the arch timer node?
>>>
>>> Exynos3250 uses MCT (Multi Core Timer) instead of ARM_ARCH_TIMER.
>>> - in drivers/clocksource/exynos_mct.c
>>
>> Don't you have a Cortex-A7? If so, you have the arch timer.
> 
> Do you means that 'arch timer" is ARM_ARCH_TIMER?

Yes.

> As I knew, ARM_ARCH_TIMER is clocksource driver for system timer.
> But, Exynos SoC used MCT clocksource for system timer.
> 
> Exynos dts file didn't include arch timer node but only include mct node.

Well, it is a bug, and a recurrent one. A Cortex-A7 has the arch timers
implemented. Always.

http://infocenter.arm.com/help/topic/com.arm.doc.ddi0464f/BABFEBJJ.html

All Cortex-A7 have it, and so do A12, A15, A17, A53, A57.

Cheers,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2014-04-15  9:24 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  1:59 [PATCHv2 0/8] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-15  1:59 ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 1/8] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 2/8] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM of Exynos3250 Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 3/8] ARM: EXYNOS: Add IO mapping for PMU " Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  8:11   ` Arnd Bergmann
2014-04-15  8:11     ` Arnd Bergmann
2014-04-15  8:11     ` Arnd Bergmann
2014-04-15  8:32     ` Chanwoo Choi
2014-04-15  8:32       ` Chanwoo Choi
2014-04-15  8:32       ` Chanwoo Choi
2014-04-15  8:39       ` Vikas Sajjan
2014-04-15  8:39         ` Vikas Sajjan
2014-04-15  8:39         ` Vikas Sajjan
2014-04-15  8:41         ` Chanwoo Choi
2014-04-15  8:41           ` Chanwoo Choi
2014-04-15  8:41           ` Chanwoo Choi
2014-04-15  8:46       ` Arnd Bergmann
2014-04-15  8:46         ` Arnd Bergmann
2014-04-15  8:46         ` Arnd Bergmann
2014-04-15  8:51         ` Chanwoo Choi
2014-04-15  8:51           ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 4/8] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 5/8] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  5:09   ` Tushar Behera
2014-04-15  5:09     ` Tushar Behera
2014-04-15  5:09     ` Tushar Behera
2014-04-17 10:15     ` Chanwoo Choi
2014-04-17 10:15       ` Chanwoo Choi
2014-04-16 14:28   ` Tomasz Figa
2014-04-16 14:28     ` Tomasz Figa
2014-04-17  8:04     ` Chanwoo Choi
2014-04-17  8:04       ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 6/8] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-16 14:35   ` Tomasz Figa
2014-04-16 14:35     ` Tomasz Figa
2014-04-16 14:35     ` Tomasz Figa
2014-04-16 14:39     ` Chanwoo Choi
2014-04-16 14:39       ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 7/8] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  1:59 ` [PATCHv2 8/8] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-15  1:59   ` Chanwoo Choi
2014-04-15  8:15   ` Marc Zyngier
2014-04-15  8:15     ` Marc Zyngier
2014-04-15  8:27     ` Chanwoo Choi
2014-04-15  8:27       ` Chanwoo Choi
2014-04-15  9:13       ` Marc Zyngier
2014-04-15  9:13         ` Marc Zyngier
2014-04-15  9:19         ` Chanwoo Choi
2014-04-15  9:19           ` Chanwoo Choi
2014-04-15  9:24           ` Marc Zyngier [this message]
2014-04-15  9:24             ` Marc Zyngier
2014-04-16  8:22             ` Chanwoo Choi
2014-04-16  8:22               ` Chanwoo Choi
2014-04-16  8:34               ` Marc Zyngier
2014-04-16  8:34                 ` Marc Zyngier
2014-04-16  8:45                 ` Chanwoo Choi
2014-04-16  8:45                   ` Chanwoo Choi
2014-04-16 10:23                 ` Chanwoo Choi
2014-04-16 10:23                   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534CFAD7.4030508@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hyunhee.kim@samsung.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=sw0312.kim@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.