From: Stephen Warren <swarren@wwwdotorg.org> To: Chen-Yu Tsai <wens@csie.org>, Linus Walleij <linus.walleij@linaro.org>, Johannes Berg <johannes@sipsolutions.net>, "John W. Linville" <linville@tuxdriver.com>, Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Alexandre Courbot <gnurou@gmail.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Mika Westerberg <mika.westerberg@linux.intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] net: rfkill: gpio: add device tree support Date: Tue, 15 Apr 2014 15:00:01 -0600 [thread overview] Message-ID: <534D9DD1.2070004@wwwdotorg.org> (raw) In-Reply-To: <1397544101-18135-6-git-send-email-wens@csie.org> On 04/15/2014 12:41 AM, Chen-Yu Tsai wrote: Patch description? > diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt > +Required properties: > +- gpios : At most two GPIO phandles > +- gpio-names : Shall be "reset" or "shutdown", matching gpios. > + If both are provided, the "reset" GPIO is toggled first. As Maxime mentioned, this is an unusual way of defining GPIOs. If this new way is acceptable, then I'd suggest more precise wording, e.g.: - gpios: Must contain an entry for each entry in gpio-names. See ../gpio/gpio.txt for details. - gpio-names: May contain any or all of the following entries: - reset - shutdown > +- rfkill-type : Type of RFKILL device: 1 for WiFi, 2 for BlueTooth, etc. > + See include/uapi/linux/rfkill.h for all valid values It would be nice if include/dt-bindings/rfkill-gpio.h existed and contained e.g.: #define RFKILL_TYPE_BLUETOOTH 2 So that: > +Example: > + > + rfkill_bt { ... > + rfkill-type = <2>; Could be written as: rfkill-type = <RFKILL_TYPE_BLUETOOTH>;
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/7] net: rfkill: gpio: add device tree support Date: Tue, 15 Apr 2014 15:00:01 -0600 [thread overview] Message-ID: <534D9DD1.2070004@wwwdotorg.org> (raw) In-Reply-To: <1397544101-18135-6-git-send-email-wens@csie.org> On 04/15/2014 12:41 AM, Chen-Yu Tsai wrote: Patch description? > diff --git a/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt b/Documentation/devicetree/bindings/rfkill/rfkill-gpio.txt > +Required properties: > +- gpios : At most two GPIO phandles > +- gpio-names : Shall be "reset" or "shutdown", matching gpios. > + If both are provided, the "reset" GPIO is toggled first. As Maxime mentioned, this is an unusual way of defining GPIOs. If this new way is acceptable, then I'd suggest more precise wording, e.g.: - gpios: Must contain an entry for each entry in gpio-names. See ../gpio/gpio.txt for details. - gpio-names: May contain any or all of the following entries: - reset - shutdown > +- rfkill-type : Type of RFKILL device: 1 for WiFi, 2 for BlueTooth, etc. > + See include/uapi/linux/rfkill.h for all valid values It would be nice if include/dt-bindings/rfkill-gpio.h existed and contained e.g.: #define RFKILL_TYPE_BLUETOOTH 2 So that: > +Example: > + > + rfkill_bt { ... > + rfkill-type = <2>; Could be written as: rfkill-type = <RFKILL_TYPE_BLUETOOTH>;
next prev parent reply other threads:[~2014-04-15 21:00 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-15 6:41 [PATCH 0/7] net: rfkill: gpio: Add device tree support Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` [PATCH 1/7] gpiolib: gpiolib-of: Implement device tree gpio-names based lookup Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 14:20 ` Maxime Ripard 2014-04-15 14:20 ` Maxime Ripard 2014-04-15 14:20 ` Maxime Ripard 2014-04-16 6:12 ` Alexandre Courbot 2014-04-16 6:12 ` Alexandre Courbot 2014-04-16 6:12 ` Alexandre Courbot 2014-04-16 6:12 ` Alexandre Courbot 2014-04-16 7:06 ` Alexandre Courbot 2014-04-16 7:06 ` Alexandre Courbot 2014-04-16 7:06 ` Alexandre Courbot 2014-04-16 7:06 ` Alexandre Courbot 2014-04-16 9:56 ` Chen-Yu Tsai 2014-04-16 9:56 ` Chen-Yu Tsai 2014-04-16 9:56 ` Chen-Yu Tsai 2014-04-16 9:56 ` Chen-Yu Tsai 2014-04-22 15:02 ` Linus Walleij 2014-04-22 15:02 ` Linus Walleij 2014-04-22 15:02 ` Linus Walleij 2014-04-22 15:02 ` Linus Walleij 2014-04-23 1:49 ` Alexandre Courbot 2014-04-23 1:49 ` Alexandre Courbot 2014-04-23 1:49 ` Alexandre Courbot 2014-04-23 1:49 ` Alexandre Courbot 2014-04-28 16:19 ` [linux-sunxi] " Chen-Yu Tsai 2014-04-28 16:19 ` Chen-Yu Tsai 2014-04-28 16:19 ` Chen-Yu Tsai 2014-04-28 16:19 ` Chen-Yu Tsai 2014-04-15 6:41 ` [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-22 15:00 ` Linus Walleij 2014-04-22 15:00 ` Linus Walleij 2014-04-22 15:00 ` Linus Walleij 2014-04-22 15:00 ` Linus Walleij 2014-04-22 15:18 ` Maxime Ripard 2014-04-22 15:18 ` Maxime Ripard 2014-04-22 15:18 ` Maxime Ripard 2014-04-22 15:18 ` Maxime Ripard 2014-04-23 13:55 ` Linus Walleij 2014-04-23 13:55 ` Linus Walleij 2014-04-23 13:55 ` Linus Walleij 2014-04-23 13:55 ` Linus Walleij 2014-04-15 6:41 ` [PATCH 3/7] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 14:26 ` Maxime Ripard 2014-04-15 14:26 ` Maxime Ripard 2014-04-15 6:41 ` [PATCH 4/7] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 14:27 ` Maxime Ripard 2014-04-15 14:27 ` Maxime Ripard 2014-04-15 14:27 ` Maxime Ripard 2014-04-15 6:41 ` [PATCH 5/7] net: rfkill: gpio: add device tree support Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 21:00 ` Stephen Warren [this message] 2014-04-15 21:00 ` Stephen Warren 2014-04-15 21:01 ` Stephen Warren 2014-04-15 21:01 ` Stephen Warren 2014-04-15 6:41 ` [PATCH 6/7] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 14:44 ` Maxime Ripard 2014-04-15 14:44 ` Maxime Ripard 2014-04-15 14:44 ` Maxime Ripard 2014-04-15 6:41 ` [PATCH 7/7] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 6:41 ` Chen-Yu Tsai 2014-04-15 14:42 ` Maxime Ripard 2014-04-15 14:42 ` Maxime Ripard 2014-04-15 14:42 ` Maxime Ripard 2014-04-15 16:06 ` [linux-sunxi] " Chen-Yu Tsai 2014-04-15 16:06 ` Chen-Yu Tsai 2014-04-15 16:06 ` Chen-Yu Tsai 2014-04-15 16:18 ` [linux-sunxi] " One Thousand Gnomes 2014-04-15 16:18 ` One Thousand Gnomes 2014-04-16 9:44 ` Maxime Ripard 2014-04-16 9:44 ` Maxime Ripard 2014-04-16 9:44 ` Maxime Ripard 2014-04-16 10:39 ` [linux-sunxi] " Chen-Yu Tsai 2014-04-16 10:39 ` Chen-Yu Tsai 2014-04-16 10:39 ` Chen-Yu Tsai [not found] ` <CAGb2v67HzB22a3huRRZyufXkdTFE410MhXqAHyC-MmVo0-GCFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-04-16 13:09 ` Hans de Goede 2014-04-16 13:09 ` [linux-sunxi] " Hans de Goede 2014-04-16 13:09 ` Hans de Goede [not found] ` <534E8102.4070404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2014-04-17 7:43 ` Arend van Spriel 2014-04-17 7:43 ` [linux-sunxi] " Arend van Spriel 2014-04-17 7:43 ` Arend van Spriel 2014-04-18 17:49 ` [linux-sunxi] " maxime.ripard 2014-04-18 17:49 ` maxime.ripard 2014-04-18 17:49 ` maxime.ripard 2014-04-18 17:49 ` maxime.ripard 2014-04-18 17:47 ` [linux-sunxi] " maxime.ripard 2014-04-18 17:47 ` maxime.ripard 2014-04-18 17:47 ` maxime.ripard 2014-04-16 13:08 ` [linux-sunxi] " Hans de Goede 2014-04-16 13:08 ` Hans de Goede 2014-04-16 13:08 ` Hans de Goede 2014-04-22 15:06 ` [PATCH 0/7] net: rfkill: gpio: Add device tree support Johannes Berg 2014-04-22 15:06 ` Johannes Berg 2014-04-22 15:06 ` Johannes Berg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=534D9DD1.2070004@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=gnurou@gmail.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=johannes@sipsolutions.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=maxime.ripard@free-electrons.com \ --cc=mika.westerberg@linux.intel.com \ --cc=netdev@vger.kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.