All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stefano Stabellini <stefanos@xilinx.com>,
	Achin.Gupta@arm.com, andrii_anisov@epam.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v5 25/25] xen/arm: split domain_build.c
Date: Wed, 31 Oct 2018 13:44:46 +0000	[thread overview]
Message-ID: <5352bc4c-9bb5-64b6-f46c-d3b129662e8b@arm.com> (raw)
In-Reply-To: <1540260184-11294-25-git-send-email-sstabellini@kernel.org>

On 10/23/18 3:03 AM, Stefano Stabellini wrote:
> domain_build.c is too large.
> 
> Move all the ACPI specific device tree generating functions from
> domain_build.c to acpi/domain_build.c.
> 
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> 
> ---
> 
> Changes in v4:
> - rename acpi_dt_build to domain_build.c
> - add copyright header
> - remove useless #include
> - remove acpi_dt_build.h, add domain_build.h
> ---
>   xen/arch/arm/acpi/Makefile         |   1 +
>   xen/arch/arm/acpi/domain_build.c   | 592 +++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/domain_build.c        | 585 +-----------------------------------
>   xen/include/asm-arm/domain_build.h |  31 ++
>   4 files changed, 629 insertions(+), 580 deletions(-)
>   create mode 100644 xen/arch/arm/acpi/domain_build.c
>   create mode 100644 xen/include/asm-arm/domain_build.h
> 
> diff --git a/xen/arch/arm/acpi/Makefile b/xen/arch/arm/acpi/Makefile
> index 23963f8..94ae249 100644
> --- a/xen/arch/arm/acpi/Makefile
> +++ b/xen/arch/arm/acpi/Makefile
> @@ -1,2 +1,3 @@
>   obj-y += lib.o
> +obj-y += domain_build.o
>   obj-y += boot.init.o
> diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c
> new file mode 100644
> index 0000000..44d3ad1
> --- /dev/null
> +++ b/xen/arch/arm/acpi/domain_build.c
> @@ -0,0 +1,592 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

I was about to ack the patch when I noticed the license is not correct 
here. This is GPLv2+ license while Xen is GPLv2 only. I know that some 
of Xen code contain such license, but this is not the case for 
domain_build.c. As there as no copyright license, we should then assume 
GPLv2.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-10-31 13:44 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  2:02 [PATCH v5 00/25] dom0less step1: boot multiple domains from device tree Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 01/25] xen: allow console_io hypercalls from certain DomUs Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 02/25] xen/arm: extend device tree based multiboot protocol Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 03/25] xen/arm: document dom0less Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 04/25] xen/arm: increase MAX_MODULES Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 05/25] xen/arm: check for multiboot nodes only under /chosen Stefano Stabellini
2018-10-26 19:25   ` Julien Grall
2018-10-26 21:12     ` Stefano Stabellini
2018-10-26 21:27       ` Julien Grall
2018-10-26 21:32         ` Julien Grall
2018-10-27  0:42           ` Stefano Stabellini
2018-10-28 17:28             ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 06/25] xen/arm: introduce bootcmdlines Stefano Stabellini
2018-10-26 19:44   ` Julien Grall
2018-10-27  0:34     ` Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 07/25] xen/arm: don't add duplicate boot modules, introduce domU flag Stefano Stabellini
2018-10-30 11:50   ` Julien Grall
2018-11-02 20:15     ` Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 08/25] xen/arm: probe domU kernels and initrds Stefano Stabellini
2018-10-30 12:03   ` Julien Grall
2018-11-02 20:41     ` Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 09/25] xen/arm: rename get_11_allocation_size to get_allocation_size Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 10/25] xen/arm: rename allocate_memory to allocate_memory_11 Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 11/25] xen/arm: introduce allocate_memory Stefano Stabellini
2018-10-30 12:24   ` Julien Grall
2018-11-02 22:20     ` Stefano Stabellini
2018-10-30 20:56   ` Julien Grall
2018-11-02 21:15     ` Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 12/25] xen/arm: refactor construct_dom0 Stefano Stabellini
2018-10-30 16:32   ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 13/25] xen/arm: move unregister_init_virtual_region to init_done Stefano Stabellini
2018-10-30 16:33   ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 14/25] xen/arm: introduce create_domUs Stefano Stabellini
2018-10-30 16:38   ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 15/25] xen/arm: implement construct_domU Stefano Stabellini
2018-10-30 20:56   ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 16/25] xen/arm: generate a simple device tree for domUs Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 17/25] xen/arm: make set_interrupt_ppi able to handle non-PPI Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 18/25] xen/arm: generate vpl011 node on device tree for domU Stefano Stabellini
2018-10-30 20:58   ` Julien Grall
2018-10-23  2:02 ` [PATCH v5 19/25] xen/arm: introduce a union in vpl011 Stefano Stabellini
2018-10-23  2:02 ` [PATCH v5 20/25] xen/arm: refactor vpl011_data_avail Stefano Stabellini
2018-10-23  2:03 ` [PATCH v5 21/25] xen: support console_switching between Dom0 and DomUs on ARM Stefano Stabellini
2018-10-24 14:55   ` Oleksandr Andrushchenko
2018-10-29 20:00     ` Stefano Stabellini
2018-10-29 20:01       ` Julien Grall
2018-10-26 14:29   ` Jan Beulich
2018-10-29 19:56     ` Stefano Stabellini
2018-10-23  2:03 ` [PATCH v5 22/25] xen/arm: Allow vpl011 to be used by DomU Stefano Stabellini
2018-10-24 17:14   ` Oleksandr Tyshchenko
2018-10-29 20:03     ` Stefano Stabellini
2018-10-30 11:04       ` Oleksandr Tyshchenko
2018-10-23  2:03 ` [PATCH v5 23/25] xen/vpl011: buffer out chars when the backend is xen Stefano Stabellini
2018-10-24 14:46   ` Oleksandr Andrushchenko
2018-10-29 20:09     ` Stefano Stabellini
2018-10-31 13:27   ` Julien Grall
2018-10-23  2:03 ` [PATCH v5 24/25] xen/arm: move kernel.h to asm-arm/ Stefano Stabellini
2018-10-31 13:28   ` Julien Grall
2018-10-23  2:03 ` [PATCH v5 25/25] xen/arm: split domain_build.c Stefano Stabellini
2018-10-31 13:44   ` Julien Grall [this message]
2018-11-01 20:37     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5352bc4c-9bb5-64b6-f46c-d3b129662e8b@arm.com \
    --to=julien.grall@arm.com \
    --cc=Achin.Gupta@arm.com \
    --cc=andrii_anisov@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanos@xilinx.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.