All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] i2c: rcar_i2c: Remove the driver
Date: Tue, 8 May 2018 10:14:52 +0200	[thread overview]
Message-ID: <535814a6-545b-0b83-2af5-3d33422af17d@denx.de> (raw)
In-Reply-To: <20180501070335.1815-1-marek.vasut+renesas@gmail.com>

Hello Marek,

Am 01.05.2018 um 09:03 schrieb Marek Vasut:
> Remove the rcar_i2c driver, since it's no longer used by any
> board and will be superseded by a DM and DT capable variant.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>   drivers/i2c/Makefile   |   1 -
>   drivers/i2c/rcar_i2c.c | 293 -------------------------------------------------
>   2 files changed, 294 deletions(-)
>   delete mode 100644 drivers/i2c/rcar_i2c.c

checkpatch says:

2018-05-08 03:12:02,870:CON    :tbotlib   # tb_ctrl: ^[[33mWARNING:^[[0m added, moved or deleted 
file(s), does MAINTAINERS need updating?
#41:
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
       mechanically convert to the typical style using --fix or --fix-inplace.

mbox has style problems, please review.

And applying patch to current mainline fails:

2018-05-08 03:12:04,014:CON    :tbotlib   # tb_ctrl: git am -3 mbox
2018-05-08 03:12:04,156:CON    :tbotlib   # tb_ctrl: Applying: i2c: rcar_i2c: Remove the driver
Using index info to reconstruct a base tree...
M	drivers/i2c/Makefile
M	drivers/i2c/rcar_i2c.c
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): drivers/i2c/rcar_i2c.c deleted in i2c: rcar_i2c: Remove the driver and 
modified in HEAD. Version HEAD of drivers/i2c/rcar_i2c.c left in tree.
Auto-merging drivers/i2c/Makefile
error: Failed to merge in the changes.
Patch failed at 0001 i2c: rcar_i2c: Remove the driver
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
hs at pollux [ 5:12:04] ttbott>

see full log:
http://xeidos.ddns.net/tbot/id_740/tbot.txt

Before I make a dummy mistake, can you please rebase your patchset?

Thanks!

Hmm.. why do you remove the driver in this patch, and add it again
in patch 2 ?

Isn;t it better to squash this 2 patches into one, so we see your
changes?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

  parent reply	other threads:[~2018-05-08  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  7:03 [U-Boot] [PATCH 1/4] i2c: rcar_i2c: Remove the driver Marek Vasut
2018-05-01  7:03 ` [U-Boot] [PATCH 2/4] i2c: rcar_i2c: Add DM and DT capable I2C driver Marek Vasut
2018-05-10  7:20   ` Heiko Schocher
2018-05-01  7:03 ` [U-Boot] [PATCH 3/4] ARM: rmobile: Enable DM capable RCar I2C driver on Lager Marek Vasut
2018-05-10  7:23   ` Heiko Schocher
2018-05-10 10:23     ` Marek Vasut
2018-05-01  7:03 ` [U-Boot] [PATCH 4/4] ARM: rmobile: Enable DM capable RCar I2C driver on Silk Marek Vasut
2018-05-08  8:14 ` Heiko Schocher [this message]
2018-05-08  9:28   ` [U-Boot] [PATCH 1/4] i2c: rcar_i2c: Remove the driver Marek Vasut
2018-05-12 21:15 Marek Vasut
2018-05-15  7:53 ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535814a6-545b-0b83-2af5-3d33422af17d@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.