All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Chanho Park <chanho61.park@samsung.com>,
	kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org
Cc: k.debski@samsung.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node
Date: Thu, 24 Apr 2014 18:07:03 +0200	[thread overview]
Message-ID: <535936A7.9050003@samsung.com> (raw)
In-Reply-To: <1397479700-15864-2-git-send-email-chanho61.park@samsung.com>

Hi Chanho,

On 14.04.2014 14:48, Chanho Park wrote:
> This patch adds a PMU(Power Management Unit) syscon node. This
> should be required for USB Phy syscon regmap I/F.
>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   arch/arm/boot/dts/exynos4.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 2f8bcd0..e565b86 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -110,6 +110,11 @@
>   		reg = <0x10010000 0x400>;
>   	};
>
> +	pmu_reg: syscon@10020000 {
> +		compatible = "samsung,exynos4-pmureg", "syscon";

This compatible string doesn't seem to be defined in [1], please add it 
there,

[1] Documentation/devicetree/bindings/arm/samsung/pmu.txt

Otherwise looks good, so after fixing that you may add my

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node
Date: Thu, 24 Apr 2014 18:07:03 +0200	[thread overview]
Message-ID: <535936A7.9050003@samsung.com> (raw)
In-Reply-To: <1397479700-15864-2-git-send-email-chanho61.park@samsung.com>

Hi Chanho,

On 14.04.2014 14:48, Chanho Park wrote:
> This patch adds a PMU(Power Management Unit) syscon node. This
> should be required for USB Phy syscon regmap I/F.
>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   arch/arm/boot/dts/exynos4.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 2f8bcd0..e565b86 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -110,6 +110,11 @@
>   		reg = <0x10010000 0x400>;
>   	};
>
> +	pmu_reg: syscon at 10020000 {
> +		compatible = "samsung,exynos4-pmureg", "syscon";

This compatible string doesn't seem to be defined in [1], please add it 
there,

[1] Documentation/devicetree/bindings/arm/samsung/pmu.txt

Otherwise looks good, so after fixing that you may add my

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

  reply	other threads:[~2014-04-24 16:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 12:48 [PATCH 0/4] Enable usbphy and hsotg for exynos4 Chanho Park
2014-04-14 12:48 ` Chanho Park
2014-04-14 12:48 ` [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:07   ` Tomasz Figa [this message]
2014-04-24 16:07     ` Tomasz Figa
2014-04-25  8:05     ` Vikas Sajjan
2014-04-25  8:05       ` Vikas Sajjan
2014-04-25 23:52       ` Tomasz Figa
2014-04-25 23:52         ` Tomasz Figa
2014-04-26  2:33         ` Pankaj Dubey
2014-04-26  2:33           ` Pankaj Dubey
2014-04-14 12:48 ` [PATCH 2/4] ARM: dts: exynos4: add exynos_usbphy node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:09   ` Tomasz Figa
2014-04-24 16:09     ` Tomasz Figa
2014-04-14 12:48 ` [PATCH 3/4] ARM: dts: exynos4: add hsotg device node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:16   ` Tomasz Figa
2014-04-24 16:16     ` Tomasz Figa
2014-04-14 12:48 ` [PATCH 4/4] ARM: dts: exynos4412-trats2: enable usb nodes Chanho Park
2014-04-14 12:48   ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535936A7.9050003@samsung.com \
    --to=t.figa@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.