* [PATCH] perf tools: Remove extra '/' character in events file path
@ 2014-04-26 7:55 xiakaixu
2014-04-28 0:14 ` Namhyung Kim
2014-05-01 6:32 ` [tip:perf/core] " tip-bot for Xia Kaixu
0 siblings, 2 replies; 6+ messages in thread
From: xiakaixu @ 2014-04-26 7:55 UTC (permalink / raw)
To: linux-kernel
Cc: paulus, Ingo Molnar, a.p.zijlstra, Arnaldo Carvalho de Melo,
Namhyung Kim, Xia Kaixu, Huxinwei, Genghui
The array debugfs_known_mountpoints[] will cause extra '/'
character output.
Remove it.
pre:
$ perf probe -l
/sys/kernel/debug//tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
post:
$ perf probe -l
/sys/kernel/debug/tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
---
tools/lib/api/fs/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
index 7c43479..a74fba6 100644
--- a/tools/lib/api/fs/debugfs.c
+++ b/tools/lib/api/fs/debugfs.c
@@ -12,8 +12,8 @@
char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
static const char * const debugfs_known_mountpoints[] = {
- "/sys/kernel/debug/",
- "/debug/",
+ "/sys/kernel/debug",
+ "/debug",
0,
};
-- 1.8.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] perf tools: Remove extra '/' character in events file path
2014-04-26 7:55 [PATCH] perf tools: Remove extra '/' character in events file path xiakaixu
@ 2014-04-28 0:14 ` Namhyung Kim
2014-04-28 2:01 ` xiakaixu
2014-05-01 6:32 ` [tip:perf/core] " tip-bot for Xia Kaixu
1 sibling, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2014-04-28 0:14 UTC (permalink / raw)
To: xiakaixu
Cc: linux-kernel, paulus, Ingo Molnar, a.p.zijlstra,
Arnaldo Carvalho de Melo, Huxinwei, Genghui, jolsa, bp
Hi xiakaixu,
(Adding Jiri and Boris to CC)
> The array debugfs_known_mountpoints[] will cause extra '/'
> character output.
> Remove it.
>
> pre:
> $ perf probe -l
> /sys/kernel/debug//tracing/uprobe_events file does not exist -
> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>
> post:
> $ perf probe -l
> /sys/kernel/debug/tracing/uprobe_events file does not exist -
> please rebuild kernel with CONFIG_UPROBE_EVENTS.
Looks like all of its callers already provide a '/' after the debugfs
mountpoint, so
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
> ---
> tools/lib/api/fs/debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
> index 7c43479..a74fba6 100644
> --- a/tools/lib/api/fs/debugfs.c
> +++ b/tools/lib/api/fs/debugfs.c
> @@ -12,8 +12,8 @@
> char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
>
> static const char * const debugfs_known_mountpoints[] = {
> - "/sys/kernel/debug/",
> - "/debug/",
> + "/sys/kernel/debug",
> + "/debug",
> 0,
> };
>
> -- 1.8.5.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] perf tools: Remove extra '/' character in events file path
2014-04-28 0:14 ` Namhyung Kim
@ 2014-04-28 2:01 ` xiakaixu
2014-04-28 7:53 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: xiakaixu @ 2014-04-28 2:01 UTC (permalink / raw)
To: Namhyung Kim
Cc: linux-kernel, paulus, Ingo Molnar, a.p.zijlstra,
Arnaldo Carvalho de Melo, Huxinwei, Genghui, jolsa, bp,
Jiri Olsa, Borislav Petkov, peifeiyue
于 2014/4/28 8:14, Namhyung Kim 写道:
> Hi xiakaixu,
>
> (Adding Jiri and Boris to CC)
OK.
thanks,
>
>> The array debugfs_known_mountpoints[] will cause extra '/'
>> character output.
>> Remove it.
>>
>> pre:
>> $ perf probe -l
>> /sys/kernel/debug//tracing/uprobe_events file does not exist -
>> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>>
>> post:
>> $ perf probe -l
>> /sys/kernel/debug/tracing/uprobe_events file does not exist -
>> please rebuild kernel with CONFIG_UPROBE_EVENTS.
>
> Looks like all of its callers already provide a '/' after the debugfs
> mountpoint, so
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>
>>
>> Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
>> ---
>> tools/lib/api/fs/debugfs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
>> index 7c43479..a74fba6 100644
>> --- a/tools/lib/api/fs/debugfs.c
>> +++ b/tools/lib/api/fs/debugfs.c
>> @@ -12,8 +12,8 @@
>> char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
>>
>> static const char * const debugfs_known_mountpoints[] = {
>> - "/sys/kernel/debug/",
>> - "/debug/",
>> + "/sys/kernel/debug",
>> + "/debug",
>> 0,
>> };
>>
>> -- 1.8.5.5
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] perf tools: Remove extra '/' character in events file path
2014-04-28 2:01 ` xiakaixu
@ 2014-04-28 7:53 ` Borislav Petkov
0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2014-04-28 7:53 UTC (permalink / raw)
To: xiakaixu, Namhyung Kim
Cc: linux-kernel, paulus, Ingo Molnar, a.p.zijlstra,
Arnaldo Carvalho de Melo, Huxinwei, Genghui, jolsa, peifeiyue
On Mon, Apr 28, 2014 at 10:01:30AM +0800, xiakaixu wrote:
> >> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
> >> index 7c43479..a74fba6 100644
> >> --- a/tools/lib/api/fs/debugfs.c
> >> +++ b/tools/lib/api/fs/debugfs.c
> >> @@ -12,8 +12,8 @@
> >> char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
> >>
> >> static const char * const debugfs_known_mountpoints[] = {
> >> - "/sys/kernel/debug/",
> >> - "/debug/",
> >> + "/sys/kernel/debug",
> >> + "/debug",
Right, fs/debugfs.c needs to get merged with fs/fs.c at some point.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:perf/core] perf tools: Remove extra '/' character in events file path
2014-04-26 7:55 [PATCH] perf tools: Remove extra '/' character in events file path xiakaixu
2014-04-28 0:14 ` Namhyung Kim
@ 2014-05-01 6:32 ` tip-bot for Xia Kaixu
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Xia Kaixu @ 2014-05-01 6:32 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jolsa, xiakaixu, tglx, namhyung
Commit-ID: 603940b6b8b1347ec13a628165c00194ebc17ed2
Gitweb: http://git.kernel.org/tip/603940b6b8b1347ec13a628165c00194ebc17ed2
Author: Xia Kaixu <xiakaixu@huawei.com>
AuthorDate: Sat, 26 Apr 2014 15:55:12 +0800
Committer: Jiri Olsa <jolsa@kernel.org>
CommitDate: Wed, 30 Apr 2014 17:02:24 +0200
perf tools: Remove extra '/' character in events file path
The array debugfs_known_mountpoints[] will cause extra '/'
character output.
Remove it.
pre:
$ perf probe -l
/sys/kernel/debug//tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
post:
$ perf probe -l
/sys/kernel/debug/tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/535B6660.2060001@huawei.com
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/lib/api/fs/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
index 7c43479..a74fba6 100644
--- a/tools/lib/api/fs/debugfs.c
+++ b/tools/lib/api/fs/debugfs.c
@@ -12,8 +12,8 @@
char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
static const char * const debugfs_known_mountpoints[] = {
- "/sys/kernel/debug/",
- "/debug/",
+ "/sys/kernel/debug",
+ "/debug",
0,
};
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <5354E37E.9060700@huawei.com>]
* [PATCH] perf tools: Remove extra '/' character in events file path
[not found] <5354E37E.9060700@huawei.com>
@ 2014-04-22 3:24 ` xiakaixu
0 siblings, 0 replies; 6+ messages in thread
From: xiakaixu @ 2014-04-22 3:24 UTC (permalink / raw)
To: paulus, Ingo Molnar, a.p.zijlstra, Arnaldo Carvalho de Melo,
Namhyung Kim
Cc: linux-kernel, Huxinwei, Genghui, peifeiyue, Xia Kaixu
The array debugfs_known_mountpoints[] will cause extra '/'
character output.
Remove it.
pre:
$ perf probe -l
/sys/kernel/debug//tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
post:
$ perf probe -l
/sys/kernel/debug/tracing/uprobe_events file does not exist -
please rebuild kernel with CONFIG_UPROBE_EVENTS.
Signed-off-by: Xia Kaixu <xiakaixu@huawei.com>
---
tools/lib/api/fs/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c
index 7c43479..a74fba6 100644
--- a/tools/lib/api/fs/debugfs.c
+++ b/tools/lib/api/fs/debugfs.c
@@ -12,8 +12,8 @@
char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug";
static const char * const debugfs_known_mountpoints[] = {
- "/sys/kernel/debug/",
- "/debug/",
+ "/sys/kernel/debug",
+ "/debug",
0,
};
--
1.8.5.5
.
.
_______________________________________________
kernel.openeuler mailing list
kernel.openeuler@huawei.com
http://rnd-openeuler.huawei.com/mailman/listinfo/kernel.openeuler
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-01 6:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-26 7:55 [PATCH] perf tools: Remove extra '/' character in events file path xiakaixu
2014-04-28 0:14 ` Namhyung Kim
2014-04-28 2:01 ` xiakaixu
2014-04-28 7:53 ` Borislav Petkov
2014-05-01 6:32 ` [tip:perf/core] " tip-bot for Xia Kaixu
[not found] <5354E37E.9060700@huawei.com>
2014-04-22 3:24 ` [PATCH] " xiakaixu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.