* [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers
@ 2014-04-26 18:57 Fabian Frederick
2014-04-28 8:48 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-04-26 18:57 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Steven Whitehouse
Sparse warning: fs/gfs2/lops.c:78:29:
"warning: Using plain integer as NULL pointer"
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/gfs2/lops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index a294d8d..2c1ae86 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -75,7 +75,7 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
unsigned int index = bd->bd_bh->b_blocknr - gl->gl_name.ln_number;
struct gfs2_bitmap *bi = rgd->rd_bits + index;
- if (bi->bi_clone == 0)
+ if (bi->bi_clone == NULL)
return;
if (sdp->sd_args.ar_discard)
gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bd->bd_bh, bi, 1, NULL);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers
2014-04-26 18:57 [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers Fabian Frederick
@ 2014-04-28 8:48 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-04-28 8:48 UTC (permalink / raw)
To: Fabian Frederick, linux-kernel; +Cc: akpm
Hi,
On 26/04/14 19:57, Fabian Frederick wrote:
> Sparse warning: fs/gfs2/lops.c:78:29:
> "warning: Using plain integer as NULL pointer"
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/lops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Now in the GFS2 -nmw tree. Thanks,
Steve.
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index a294d8d..2c1ae86 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -75,7 +75,7 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
> unsigned int index = bd->bd_bh->b_blocknr - gl->gl_name.ln_number;
> struct gfs2_bitmap *bi = rgd->rd_bits + index;
>
> - if (bi->bi_clone == 0)
> + if (bi->bi_clone == NULL)
> return;
> if (sdp->sd_args.ar_discard)
> gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bd->bd_bh, bi, 1, NULL);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-28 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-26 18:57 [PATCH 1/1] fs/gfs2/lops.c: replace 0 by NULL for pointers Fabian Frederick
2014-04-28 8:48 ` Steven Whitehouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.