From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
avagin@openvz.org, oleg@redhat.com, mikey@neuling.org,
benh@kernel.crashing.org
Subject: Re: [PATCH 2/3] powerpc, ptrace: Add new ptrace request macros for transactional memory
Date: Mon, 28 Apr 2014 16:00:33 +0530 [thread overview]
Message-ID: <535E2DC9.7080602@linux.vnet.ibm.com> (raw)
In-Reply-To: <535AF2E9.1000005@redhat.com>
On 04/26/2014 05:12 AM, Pedro Alves wrote:
> On 04/02/2014 08:02 AM, Anshuman Khandual wrote:
>> This patch adds following new sets of ptrace request macros for transactional
>> memory expanding the existing ptrace ABI on PowerPC.
>>
>> /* TM special purpose registers */
>> PTRACE_GETTM_SPRREGS
>> PTRACE_SETTM_SPRREGS
>>
>> /* TM checkpointed GPR registers */
>> PTRACE_GETTM_CGPRREGS
>> PTRACE_SETTM_CGPRREGS
>>
>> /* TM checkpointed FPR registers */
>> PTRACE_GETTM_CFPRREGS
>> PTRACE_SETTM_CFPRREGS
>>
>> /* TM checkpointed VMX registers */
>> PTRACE_GETTM_CVMXREGS
>> PTRACE_SETTM_CVMXREGS
>
> Urgh, we're _still_ adding specialized register specific calls?
> Why aren't these exported as new register sets, accessible through
> PTRACE_GETREGSET / PTRACE_SETREGSET? That's supposed to be the
> Modern Way to do things.
All these new register sets can be accessed through PTRACE_GETREGSET
/SETREGSET requests with the new NT_PPC_* core note types added in the
previous patch. PowerPC already has some register specific ptrace
requests, so thought of adding some new requests for transactional
memory purpose. But yes these are redundant and can be dropped.
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: mikey@neuling.org, avagin@openvz.org, oleg@redhat.com,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] powerpc, ptrace: Add new ptrace request macros for transactional memory
Date: Mon, 28 Apr 2014 16:00:33 +0530 [thread overview]
Message-ID: <535E2DC9.7080602@linux.vnet.ibm.com> (raw)
In-Reply-To: <535AF2E9.1000005@redhat.com>
On 04/26/2014 05:12 AM, Pedro Alves wrote:
> On 04/02/2014 08:02 AM, Anshuman Khandual wrote:
>> This patch adds following new sets of ptrace request macros for transactional
>> memory expanding the existing ptrace ABI on PowerPC.
>>
>> /* TM special purpose registers */
>> PTRACE_GETTM_SPRREGS
>> PTRACE_SETTM_SPRREGS
>>
>> /* TM checkpointed GPR registers */
>> PTRACE_GETTM_CGPRREGS
>> PTRACE_SETTM_CGPRREGS
>>
>> /* TM checkpointed FPR registers */
>> PTRACE_GETTM_CFPRREGS
>> PTRACE_SETTM_CFPRREGS
>>
>> /* TM checkpointed VMX registers */
>> PTRACE_GETTM_CVMXREGS
>> PTRACE_SETTM_CVMXREGS
>
> Urgh, we're _still_ adding specialized register specific calls?
> Why aren't these exported as new register sets, accessible through
> PTRACE_GETREGSET / PTRACE_SETREGSET? That's supposed to be the
> Modern Way to do things.
All these new register sets can be accessed through PTRACE_GETREGSET
/SETREGSET requests with the new NT_PPC_* core note types added in the
previous patch. PowerPC already has some register specific ptrace
requests, so thought of adding some new requests for transactional
memory purpose. But yes these are redundant and can be dropped.
next prev parent reply other threads:[~2014-04-28 10:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 7:02 [PATCH 0/3] Add new ptrace request macros on PowerPC Anshuman Khandual
2014-04-02 7:02 ` Anshuman Khandual
2014-04-02 7:02 ` [PATCH 1/3] elf: Add some new PowerPC specifc note sections Anshuman Khandual
2014-04-02 7:02 ` Anshuman Khandual
2014-04-02 7:02 ` [PATCH 2/3] powerpc, ptrace: Add new ptrace request macros for transactional memory Anshuman Khandual
2014-04-02 7:02 ` Anshuman Khandual
2014-04-25 23:42 ` Pedro Alves
2014-04-25 23:42 ` Pedro Alves
2014-04-28 10:30 ` Anshuman Khandual [this message]
2014-04-28 10:30 ` Anshuman Khandual
2014-05-01 13:41 ` Pedro Alves
2014-05-01 13:41 ` Pedro Alves
2014-04-02 7:02 ` [PATCH 3/3] powerpc, ptrace: Add new ptrace request macro for miscellaneous registers Anshuman Khandual
2014-04-02 7:02 ` Anshuman Khandual
2014-04-02 9:32 ` [PATCH 0/3] Add new ptrace request macros on PowerPC Anshuman Khandual
2014-04-02 9:32 ` Anshuman Khandual
2014-04-29 7:00 ` Anshuman Khandual
2014-04-29 7:00 ` Anshuman Khandual
2014-04-29 7:06 ` Michael Neuling
2014-04-29 7:59 ` Anshuman Khandual
2014-04-29 7:59 ` Anshuman Khandual
2014-04-29 8:22 ` Michael Neuling
2014-04-29 12:22 ` Anshuman Khandual
2014-04-29 12:22 ` Anshuman Khandual
2014-04-30 0:29 ` Michael Neuling
2014-04-30 0:29 ` Michael Neuling
2014-04-30 8:16 ` Anshuman Khandual
2014-04-30 8:16 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E2DC9.7080602@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=oleg@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.