[PATCH v3 0/2] Add peach-pit board support

[PATCH v3 0/2] Add peach-pit board support

[Arun Kumar K]

Changes from v2
--------------
- Use reference based node addressing in board dts file
  as suggested by Tomasz.
- Included patch to update 5420.dtsi with node references
  for all existing nodes.

Changes from v1
--------------
- Addressed review comments from Doug, Sachin & Tushar
- Removed adc and lid-switch nodes

Arun Kumar K (2):
  ARM: dts: Add node references to 5420
  ARM: dts: Add peach-pit board support

 arch/arm/boot/dts/Makefile                 |    1 +
 arch/arm/boot/dts/exynos5420-peach-pit.dts |  156 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5420.dtsi          |   26 ++---
 3 files changed, 170 insertions(+), 13 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5420-peach-pit.dts

-- 
1.7.9.5

[PATCH v3 1/2] ARM: dts: Add node references to 5420

[Arun Kumar K]

Adding references to nodes which do not have it yet
in exynos5420.dtsi. This is done so as to use reference
based node updation in board files.

Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
 arch/arm/boot/dts/exynos5420.dtsi |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index c3a9a66..2058276 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -125,7 +125,7 @@
 		clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in";
 	};
 
-	codec@11000000 {
+	codec: codec@11000000 {
 		compatible = "samsung,mfc-v7";
 		reg = <0x11000000 0x10000>;
 		interrupts = <0 96 0>;
@@ -169,7 +169,7 @@
 		status = "disabled";
 	};
 
-	mct@101C0000 {
+	mct: mct@101C0000 {
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
 		interrupt-controller;
@@ -270,7 +270,7 @@
 		interrupts = <0 47 0>;
 	};
 
-	rtc@101E0000 {
+	rtc: rtc@101E0000 {
 		clocks = <&clock CLK_RTC>;
 		clock-names = "rtc";
 		status = "disabled";
@@ -430,22 +430,22 @@
 		status = "disabled";
 	};
 
-	serial@12C00000 {
+	serial_0: serial@12C00000 {
 		clocks = <&clock CLK_UART0>, <&clock CLK_SCLK_UART0>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
 
-	serial@12C10000 {
+	serial_1: serial@12C10000 {
 		clocks = <&clock CLK_UART1>, <&clock CLK_SCLK_UART1>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
 
-	serial@12C20000 {
+	serial_2: serial@12C20000 {
 		clocks = <&clock CLK_UART2>, <&clock CLK_SCLK_UART2>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
 
-	serial@12C30000 {
+	serial_3: serial@12C30000 {
 		clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
@@ -465,14 +465,14 @@
 		#phy-cells = <0>;
 	};
 
-	dp-controller@145B0000 {
+	dp: dp-controller@145B0000 {
 		clocks = <&clock CLK_DP1>;
 		clock-names = "dp";
 		phys = <&dp_phy>;
 		phy-names = "dp";
 	};
 
-	fimd@14400000 {
+	fimd: fimd@14400000 {
 		samsung,power-domain = <&disp_pd>;
 		clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
 		clock-names = "sclk_fimd", "fimd";
@@ -632,7 +632,7 @@
 		status = "disabled";
 	};
 
-	hdmi@14530000 {
+	hdmi: hdmi@14530000 {
 		compatible = "samsung,exynos4212-hdmi";
 		reg = <0x14530000 0x70000>;
 		interrupts = <0 95 0>;
@@ -644,7 +644,7 @@
 		status = "disabled";
 	};
 
-	mixer@14450000 {
+	mixer: mixer@14450000 {
 		compatible = "samsung,exynos5420-mixer";
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
@@ -715,7 +715,7 @@
 		clock-names = "tmu_apbif", "tmu_triminfo_apbif";
 	};
 
-        watchdog@101D0000 {
+        watchdog: watchdog@101D0000 {
 		compatible = "samsung,exynos5420-wdt";
 		reg = <0x101D0000 0x100>;
 		interrupts = <0 42 0>;
@@ -724,7 +724,7 @@
 		samsung,syscon-phandle = <&pmu_system_controller>;
         };
 
-	sss@10830000 {
+	sss: sss@10830000 {
 		compatible = "samsung,exynos4210-secss";
 		reg = <0x10830000 0x10000>;
 		interrupts = <0 112 0>;
-- 
1.7.9.5

Re: [PATCH v3 1/2] ARM: dts: Add node references to 5420

[Doug Anderson]

Arun,

On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Adding references to nodes which do not have it yet
> in exynos5420.dtsi. This is done so as to use reference
> based node updation in board files.
>
> Signed-off-by: Arun Kumar K <arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)

This looks reasonable to me.

Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/2] ARM: dts: Add node references to 5420

[Tomasz Figa]

Hi Arun,

Looks mostly fine, just some minor nits to improve readability.

On 30.04.2014 13:08, Arun Kumar K wrote:
> Adding references to nodes which do not have it yet
> in exynos5420.dtsi. This is done so as to use reference
> based node updation in board files.

To stick to correct terminology, the handle that lets you reference a 
node is called "label", so this patch adds labels to nodes that don't 
have them yet.

>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5420.dtsi |   26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index c3a9a66..2058276 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -125,7 +125,7 @@
>   		clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in";
>   	};
>
> -	codec@11000000 {
> +	codec: codec@11000000 {

IMHO "mfc" would be a more convenient label.

>   		compatible = "samsung,mfc-v7";
>   		reg = <0x11000000 0x10000>;
>   		interrupts = <0 96 0>;
> @@ -169,7 +169,7 @@
>   		status = "disabled";
>   	};
>
> -	mct@101C0000 {
> +	mct: mct@101C0000 {
>   		compatible = "samsung,exynos4210-mct";
>   		reg = <0x101C0000 0x800>;
>   		interrupt-controller;
> @@ -270,7 +270,7 @@
>   		interrupts = <0 47 0>;
>   	};
>
> -	rtc@101E0000 {
> +	rtc: rtc@101E0000 {
>   		clocks = <&clock CLK_RTC>;
>   		clock-names = "rtc";
>   		status = "disabled";
> @@ -430,22 +430,22 @@
>   		status = "disabled";
>   	};
>
> -	serial@12C00000 {
> +	serial_0: serial@12C00000 {

To match with our hardware naming conventions, uart0 would probably be a 
better label. Similarly for remaining serial ports.

With those fixed, feel free to add my Reviewed-by tag.

Best regards,
Tomasz

Re: [PATCH v3 1/2] ARM: dts: Add node references to 5420

[Arun Kumar K]

Hi Tomasz,

Will make these changes.

Thanks & Regards
Arun

On 05/01/14 22:55, Tomasz Figa wrote:
> Hi Arun,
> 
> Looks mostly fine, just some minor nits to improve readability.
> 
> On 30.04.2014 13:08, Arun Kumar K wrote:
>> Adding references to nodes which do not have it yet
>> in exynos5420.dtsi. This is done so as to use reference
>> based node updation in board files.
> 
> To stick to correct terminology, the handle that lets you reference a 
> node is called "label", so this patch adds labels to nodes that don't 
> have them yet.
> 
>>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420.dtsi |   26 +++++++++++++-------------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index c3a9a66..2058276 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -125,7 +125,7 @@
>>   		clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in";
>>   	};
>>
>> -	codec@11000000 {
>> +	codec: codec@11000000 {
> 
> IMHO "mfc" would be a more convenient label.
> 
>>   		compatible = "samsung,mfc-v7";
>>   		reg = <0x11000000 0x10000>;
>>   		interrupts = <0 96 0>;
>> @@ -169,7 +169,7 @@
>>   		status = "disabled";
>>   	};
>>
>> -	mct@101C0000 {
>> +	mct: mct@101C0000 {
>>   		compatible = "samsung,exynos4210-mct";
>>   		reg = <0x101C0000 0x800>;
>>   		interrupt-controller;
>> @@ -270,7 +270,7 @@
>>   		interrupts = <0 47 0>;
>>   	};
>>
>> -	rtc@101E0000 {
>> +	rtc: rtc@101E0000 {
>>   		clocks = <&clock CLK_RTC>;
>>   		clock-names = "rtc";
>>   		status = "disabled";
>> @@ -430,22 +430,22 @@
>>   		status = "disabled";
>>   	};
>>
>> -	serial@12C00000 {
>> +	serial_0: serial@12C00000 {
> 
> To match with our hardware naming conventions, uart0 would probably be a 
> better label. Similarly for remaining serial ports.
> 
> With those fixed, feel free to add my Reviewed-by tag.
> 
> Best regards,
> Tomasz
> 

[PATCH v3 2/2] ARM: dts: Add peach-pit board support

[Arun Kumar K]

Adds the google peach-pit board dts file which uses
exynos5420 SoC.

Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 arch/arm/boot/dts/Makefile                 |    1 +
 arch/arm/boot/dts/exynos5420-peach-pit.dts |  156 ++++++++++++++++++++++++++++
 2 files changed, 157 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5420-peach-pit.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 35c146f..3220e29 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -74,6 +74,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos5250-smdk5250.dtb \
 	exynos5250-snow.dtb \
 	exynos5420-arndale-octa.dtb \
+	exynos5420-peach-pit.dtb \
 	exynos5420-smdk5420.dtb \
 	exynos5440-sd5v1.dtb \
 	exynos5440-ssdk5440.dtb
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
new file mode 100644
index 0000000..03ef094
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -0,0 +1,156 @@
+/*
+ * Google Peach Pit Rev 6+ board device tree source
+ *
+ * Copyright (c) 2014 Google, Inc
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/gpio/gpio.h>
+#include "exynos5420.dtsi"
+
+/ {
+	model = "Google Peach Pit Rev 6+";
+
+	compatible = "google,pit-rev16",
+		"google,pit-rev15", "google,pit-rev14",
+		"google,pit-rev13", "google,pit-rev12",
+		"google,pit-rev11", "google,pit-rev10",
+		"google,pit-rev9", "google,pit-rev8",
+		"google,pit-rev7", "google,pit-rev6",
+		"google,pit", "google,peach","samsung,exynos5420",
+		"samsung,exynos5";
+
+	memory {
+		reg = <0x20000000 0x80000000>;
+	};
+
+	fixed-rate-clocks {
+		oscclk {
+			compatible = "samsung,exynos5420-oscclk";
+			clock-frequency = <24000000>;
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&power_key_irq>;
+
+		power {
+			label = "Power";
+			gpios = <&gpx1 2 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_POWER>;
+			gpio-key,wakeup;
+		};
+	};
+
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 0 1000000 0>;
+		brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
+		default-brightness-level = <7>;
+		pinctrl-0 = <&backlight_pwm>;
+		pinctrl-names = "default";
+	};
+};
+
+&pinctrl_0 {
+	tpm_irq: tpm-irq {
+		samsung,pins = "gpx1-0";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+
+	power_key_irq: power-key-irq {
+		samsung,pins = "gpx1-2";
+		samsung,pin-function = <0>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};
+
+&pinctrl_3 {
+	backlight_pwm: backlight-pwm {
+		samsung,pins = "gpb2-0";
+		samsung,pin-function = <2>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};
+
+&rtc {
+	status = "okay";
+};
+
+&serial_3 {
+	status = "okay";
+};
+
+&mmc_0 {
+	status = "okay";
+	num-slots = <1>;
+	broken-cd;
+	caps2-mmc-hs200-1_8v;
+	supports-highspeed;
+	non-removable;
+	card-detect-delay = <200>;
+	clock-frequency = <400000000>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <0 4>;
+	samsung,dw-mshc-ddr-timing = <0 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>;
+
+	slot@0 {
+		reg = <0>;
+		bus-width = <8>;
+	};
+};
+
+&mmc_2 {
+	status = "okay";
+	num-slots = <1>;
+	supports-highspeed;
+	card-detect-delay = <200>;
+	clock-frequency = <400000000>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <2 3>;
+	samsung,dw-mshc-ddr-timing = <1 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
+
+	slot@0 {
+		reg = <0>;
+		bus-width = <4>;
+	};
+};
+
+&hsi2c_9 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	tpm@20 {
+		compatible = "infineon,slb9645tt";
+		reg = <0x20>;
+
+		/* Unused irq; but still need to configure the pins */
+		pinctrl-names = "default";
+		pinctrl-0 = <&tpm_irq>;
+	};
+};
+
+/*
+ * Use longest HW watchdog in SoC (32 seconds) since the hardware
+ * watchdog provides no debugging information (compared to soft/hard
+ * lockup detectors) and so should be last resort.
+ */
+&watchdog {
+	timeout-sec = <32>;
+};
-- 
1.7.9.5

Re: [PATCH v3 2/2] ARM: dts: Add peach-pit board support

[Doug Anderson]

Arun,

On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun.kk@samsung.com> wrote:
> +       memory {
> +               reg = <0x20000000 0x80000000>;

As mentioned in the other thread, I think this should be 0 0

> +&pinctrl_0 {
> +       tpm_irq: tpm-irq {
> +               samsung,pins = "gpx1-0";
> +               samsung,pin-function = <0>;
> +               samsung,pin-pud = <0>;

Is there any way to use the #defines PIN_PULL_NONE here?

> +&pinctrl_3 {
> +       backlight_pwm: backlight-pwm {
> +               samsung,pins = "gpb2-0";
> +               samsung,pin-function = <2>;
> +               samsung,pin-pud = <0>;
> +               samsung,pin-drv = <0>;
> +       };

The PWM probably belongs in exynos5420-pinctrl.dtsi (though you'd need
to call it by a more generic name since it could be used for something
other than a backlight).

Re: [PATCH v3 2/2] ARM: dts: Add peach-pit board support

[Tomasz Figa]

On 01.05.2014 17:40, Doug Anderson wrote:
> Arun,
>
> On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun.kk@samsung.com> wrote:
>> +       memory {
>> +               reg = <0x20000000 0x80000000>;
>
> As mentioned in the other thread, I think this should be 0 0

I guess it may depend on your boards, but DT might contain safe default 
configuration that would work on all variants, so if you have for 
example 1 GiB and 2 GiB variants, 1 GiB configuration here should be 
fine to get the board running even without a bootloader that could 
inject remaining data.

>
>> +&pinctrl_0 {
>> +       tpm_irq: tpm-irq {
>> +               samsung,pins = "gpx1-0";
>> +               samsung,pin-function = <0>;
>> +               samsung,pin-pud = <0>;
>
> Is there any way to use the #defines PIN_PULL_NONE here?

I wonder if we already have this kind of #define defined. Keep in mind 
that this value is specific for Exynos SoCs, so we would need to define 
it in Exynos-specific header, like include/dt-bindings/pinctrl/exynos.h.

>
>> +&pinctrl_3 {
>> +       backlight_pwm: backlight-pwm {
>> +               samsung,pins = "gpb2-0";
>> +               samsung,pin-function = <2>;
>> +               samsung,pin-pud = <0>;
>> +               samsung,pin-drv = <0>;
>> +       };
>
> The PWM probably belongs in exynos5420-pinctrl.dtsi (though you'd need
> to call it by a more generic name since it could be used for something
> other than a backlight).

Yes, please add generic pinctrl nodes for all PWM outputs on the SoC to 
exynos5420-pinctrl.dtsi, as done in exynos4x12-pinctrl.dtsi (see 
pwmX-out nodes).

Best regards,
Tomasz

Re: [PATCH v3 2/2] ARM: dts: Add peach-pit board support

[Doug Anderson]

Tomasz,

On Thu, May 1, 2014 at 10:30 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> On 01.05.2014 17:40, Doug Anderson wrote:
>>
>> Arun,
>>
>> On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun.kk@samsung.com> wrote:
>>>
>>> +       memory {
>>> +               reg = <0x20000000 0x80000000>;
>>
>>
>> As mentioned in the other thread, I think this should be 0 0
>
>
> I guess it may depend on your boards, but DT might contain safe default
> configuration that would work on all variants, so if you have for example 1
> GiB and 2 GiB variants, 1 GiB configuration here should be fine to get the
> board running even without a bootloader that could inject remaining data.

That was part of the debate yesterday, I thought.  Tom Rini (U-Boot
guy) said that right now U-Boot clobbers the memory node _always_ and
fills it in with whatever it detects.  He wasn't sure this was a good
idea.  Someone said they thought that it wasn't a good idea, but
someone could request U-Boot keep clobbering things by doing <0 0>

Tom: did I summarize that correctly?


>>> +&pinctrl_0 {
>>> +       tpm_irq: tpm-irq {
>>> +               samsung,pins = "gpx1-0";
>>> +               samsung,pin-function = <0>;
>>> +               samsung,pin-pud = <0>;
>>
>>
>> Is there any way to use the #defines PIN_PULL_NONE here?
>
>
> I wonder if we already have this kind of #define defined. Keep in mind that
> this value is specific for Exynos SoCs, so we would need to define it in
> Exynos-specific header, like include/dt-bindings/pinctrl/exynos.h.

I dunno.  I'd actually love to see function 0/1 defined (input /
output) too.  ...and drive strengths (since 0, 1, 2, 3 don't map
nicely to x1, x2, x3, x4).

I requested PIN_PULL_NONE though, since I saw it being used.

...oh, but it's a #define in a .dtsi.  Hrm.

arch/arm/boot/dts/s3c64xx-pinctrl.dtsi:#define PIN_PULL_NONE    0

I guess I'd say that it would be nice to do this properly for exynos,
but we could do it in a later patch.


-Doug