* [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412
@ 2014-05-02 6:38 Beomho Seo
2014-05-02 18:00 ` Tomasz Figa
0 siblings, 1 reply; 2+ messages in thread
From: Beomho Seo @ 2014-05-02 6:38 UTC (permalink / raw)
To: linux-samsung-soc, devicetree, Tomasz Figa, Kukjin Kim
Cc: Myungjoo Ham, Chanwoo Choi, Jaehoon Chung
This patch fixed gpio key device node.
First, fix incorrect gpio property.
And then, add ok-key node where locate bottom center.
I have tested on exynos4412-trats2 board.
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---
Changes in v2:
- None.
---
arch/arm/boot/dts/exynos4412-trats2.dts | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index d599215..41305e2 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -87,18 +87,18 @@
compatible = "gpio-keys";
key-down {
- interrupt-parent = <&gpj1>;
- interrupts = <2 0>;
- gpios = <&gpj1 2 1>;
+ interrupt-parent = <&gpx3>;
+ interrupts = <3 0>;
+ gpios = <&gpx3 3 1>;
linux,code = <114>;
label = "volume down";
debounce-interval = <10>;
};
key-up {
- interrupt-parent = <&gpj1>;
- interrupts = <1 0>;
- gpios = <&gpj1 1 1>;
+ interrupt-parent = <&gpx2>;
+ interrupts = <2 0>;
+ gpios = <&gpx2 2 1>;
linux,code = <115>;
label = "volume up";
debounce-interval = <10>;
@@ -113,6 +113,16 @@
debounce-interval = <10>;
gpio-key,wakeup;
};
+
+ key-ok {
+ interrupt-parent = <&gpx0>;
+ interrupts = <1 0>;
+ gpios = <&gpx0 1 1>;
+ linux,code = <139>;
+ label = "ok";
+ debounce-inteval = <10>;
+ gpio-key,wakeup;
+ };
};
adc: adc@126C0000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412
2014-05-02 6:38 [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412 Beomho Seo
@ 2014-05-02 18:00 ` Tomasz Figa
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Figa @ 2014-05-02 18:00 UTC (permalink / raw)
To: Beomho Seo, linux-samsung-soc, devicetree, Tomasz Figa, Kukjin Kim
Cc: Myungjoo Ham, Chanwoo Choi, Jaehoon Chung
Hi Beomho,
On 02.05.2014 08:38, Beomho Seo wrote:
> This patch fixed gpio key device node.
> First, fix incorrect gpio property.
> And then, add ok-key node where locate bottom center.
> I have tested on exynos4412-trats2 board.
While at it, could you also remove interrupt-parent and interrupts
properties from nodes of the keys? They have been added here by a
mistake and they are not part of the gpio-keys device tree bindings.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-02 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-02 6:38 [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412 Beomho Seo
2014-05-02 18:00 ` Tomasz Figa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.