All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>,
	"Alex Deucher" <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: Fix num_banks calculation for SI
Date: Fri, 02 May 2014 12:16:13 +0200	[thread overview]
Message-ID: <5363706D.3000604@vodafone.de> (raw)
In-Reply-To: <536300EC.3020701@daenzer.net>

Am 02.05.2014 04:20, schrieb Michel Dänzer:
> On 22.04.2014 21:51, Alex Deucher wrote:
>> On Tue, Apr 22, 2014 at 3:53 AM, Michel Dänzer <michel@daenzer.net> wrote:
>>> From: Michel Dänzer <michel.daenzer@amd.com>
>>>
>>> The way the tile mode array index was calculated only makes sense for
>>> the CIK specific macrotile mode array. For SI, we need to use one of the
>>> tile mode array indices reserved for displayable surfaces.
>>>
>>> This happened to result in correct display most if not all of the time
>>> because most of the SI tiling modes use the same number of banks.
>>>
>>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
>> Thanks for doing this.
>>
>> Reviewed-by:  Alex Deucher <alexander.deucher@amd.com>
> Thanks Alex.
>
>> Christian, can you cc stable when you pick this up?
> Actually, I deliberately left that out, as the previous code mostly
> seems to calculate the same result in practice, just not in the correct
> way. So I'm not sure it's worth taking any risk for stable, however
> small it may be. We can still nominate it for stable later if it turns
> out to fix an actual problem in practice.
>
>
> Anyway, I can't seem to find this patch in any DRM tree yet. Christian,
> did you see it?
I've seen this patch, but somehow thought that it was for libdrm and not 
the kernel module.

Nevermind I'm going to push it with the next drm-fixes.

Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2014-05-02 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  7:53 [PATCH] drm/radeon: Fix num_banks calculation for SI Michel Dänzer
2014-04-22 12:51 ` Alex Deucher
2014-05-02  2:20   ` Michel Dänzer
2014-05-02 10:16     ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5363706D.3000604@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.