All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George.Dunlap@eu.citrix.com, xen-devel@lists.xenproject.org,
	keir.xen@gmail.com, tim@xen.org
Subject: Re: [V10 PATCH 0/4] pvh dom0 patches...
Date: Fri, 2 May 2014 18:13:51 +0200	[thread overview]
Message-ID: <5363C43F.6050304@citrix.com> (raw)
In-Reply-To: <5363D8C8020000780000E9F7@mail.emea.novell.com>

On 02/05/14 17:41, Jan Beulich wrote:
>>>> On 02.05.14 at 16:35, <roger.pau@citrix.com> wrote:
>> On 02/05/14 16:16, Jan Beulich wrote:
>>>>>> On 02.05.14 at 16:06, <roger.pau@citrix.com> wrote:
>>>> My bad, I've incorrectly printed this as 0x%lu instead of %lx, the
>>>> following output is correct:
>>>>
>>>> SMAP type=01 base=0000000000000000 len=0000000000092400
>>>> SMAP type=02 base=00000000000f0000 len=0000000000010000
>>>> SMAP type=01 base=0000000000100000 len=000000003ff6e000
>>>> SMAP type=04 base=00000000dfdf9c00 len=0000000000052000
>>>> SMAP type=03 base=00000000dfe4bc00 len=0000000000002000
>>>> SMAP type=02 base=00000000dfe4dc00 len=00000000001b2400
>>>> SMAP type=02 base=00000000f8000000 len=0000000005000000
>>>> SMAP type=02 base=00000000fe000000 len=0000000000d00400
>>>> SMAP type=02 base=00000000fee00000 len=0000000000100000
>>>> SMAP type=02 base=00000000ffb00000 len=0000000000500000
>>>> SMAP type=02 base=0000000100000000 len=00000000a0000000
> 
> Considering the hypervisor view below, this range clearly is then
> wrong here too, ...
> 
>> Maybe the problem is on FreeBSD, and I'm not correctly clamping the e820
>> memory map returned by Xen. Right now I'm using start_info->nr_pages as
>> the number of valid RAM pages assigned to Dom0, but it is not clear if
>> start_info->nr_pages also takes into account the holes and invalid
>> regions in the e820 memory map.
> 
> i.e. yes, there must be some kind of problem in your handling in any
> case.
> 
>> This is the hw memory map reported by Xen:
>>
>> (XEN) Xen-e820 RAM map:
>> (XEN)  0000000000000000 - 0000000000092400 (usable)
>> (XEN)  00000000000f0000 - 0000000000100000 (reserved)
>> (XEN)  0000000000100000 - 00000000dfdf9c00 (usable)
>> (XEN)  00000000dfdf9c00 - 00000000dfe4bc00 (ACPI NVS)
>> (XEN)  00000000dfe4bc00 - 00000000dfe4dc00 (ACPI data)
>> (XEN)  00000000dfe4dc00 - 00000000e0000000 (reserved)
>> (XEN)  00000000f8000000 - 00000000fd000000 (reserved)
>> (XEN)  00000000fe000000 - 00000000fed00400 (reserved)
>> (XEN)  00000000fee00000 - 00000000fef00000 (reserved)
>> (XEN)  00000000ffb00000 - 0000000100000000 (reserved)
>> (XEN)  0000000100000000 - 00000001a0000000 (usable)
>>
>> And the Dom0 is assigned 1024M of RAM.
> 
> I.e. it can have pages at or beyond 0x40000000 only if some other
> region is unpopulated.

If I got this right, it means that the maximum populated gpfn on the
domain is (start_info->nr_pages << PAGE_SHIFT), which is kind of odd,
because on PVH Dom0 all the holes in the memory map are already set to
p2m_mmio_direct (see pvh_map_all_iomem in patch 1), so I don't think
there's anything I can unpopulate, and it means that the dom0_mem param
passed in the command line is not properly handled, because the actual
usable RAM assigned to the Dom0 will vary depending on the underlying
hardware e820 map.

Roger.

  reply	other threads:[~2014-05-02 16:13 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30  1:06 [V10 PATCH 0/4] pvh dom0 patches Mukesh Rathor
2014-04-30  1:06 ` [V10 PATCH 1/4] pvh dom0: construct_dom0 changes Mukesh Rathor
2014-05-06 15:18   ` Roger Pau Monné
2014-04-30  1:06 ` [V10 PATCH 2/4] pvh dom0: Add checks and restrictions for p2m_is_foreign Mukesh Rathor
2014-05-01 16:14   ` Tim Deegan
2014-04-30  1:06 ` [V10 PATCH 3/4] pvh dom0: Add and remove foreign pages Mukesh Rathor
2014-05-01 16:19   ` Tim Deegan
2014-05-02  1:45     ` Mukesh Rathor
2014-05-02  8:38       ` Jan Beulich
2014-05-02  8:55       ` Tim Deegan
2014-05-02 23:35         ` Mukesh Rathor
2014-05-05  7:46           ` Jan Beulich
2014-05-08 12:16           ` Tim Deegan
2014-05-08 13:25             ` Jan Beulich
2014-05-08 22:58             ` Mukesh Rathor
2014-04-30  1:06 ` [V10 PATCH 4/4] dom0: add opt_dom0pvh to setup.c Mukesh Rathor
2014-04-30 14:11 ` [V10 PATCH 0/4] pvh dom0 patches Roger Pau Monné
2014-04-30 18:12   ` Mukesh Rathor
2014-05-01  1:19     ` Mukesh Rathor
2014-05-02 11:05       ` Roger Pau Monné
2014-05-02 12:31         ` Jan Beulich
2014-05-02 14:06           ` Roger Pau Monné
2014-05-02 14:16             ` Jan Beulich
2014-05-02 14:35               ` Roger Pau Monné
2014-05-02 15:41                 ` Jan Beulich
2014-05-02 16:13                   ` Roger Pau Monné [this message]
2014-05-02 19:35                     ` Konrad Rzeszutek Wilk
2014-05-03  0:01         ` Mukesh Rathor
2014-05-05  8:52           ` Roger Pau Monné
2014-05-06  0:28             ` Mukesh Rathor
2014-05-06  7:13               ` Roger Pau Monné
2014-05-06  8:09                 ` Jan Beulich
2014-05-07  1:00                 ` Mukesh Rathor
2014-05-07  7:50                   ` Jan Beulich
2014-05-07  9:48                     ` Roger Pau Monné
2014-05-07 11:34                       ` Jan Beulich
2014-05-08 10:27                         ` Roger Pau Monné
2014-05-08 10:44                           ` Jan Beulich
2014-05-08 15:00                             ` Roger Pau Monné
2014-05-08 15:20                               ` Jan Beulich
2014-05-07 13:25                     ` Konrad Rzeszutek Wilk
2014-05-08  0:04                     ` Mukesh Rathor
2014-05-08  6:37                       ` Jan Beulich
2014-05-08 19:15                         ` Mukesh Rathor
2014-05-07 13:20                   ` Konrad Rzeszutek Wilk
2014-05-07 13:38                     ` Roger Pau Monné
2014-05-08  0:12                       ` Mukesh Rathor
2014-05-08 10:52                         ` George Dunlap
2014-05-08 13:15                         ` David Vrabel
2014-05-08 22:29                           ` Mukesh Rathor
2014-05-08  0:07                     ` Mukesh Rathor
2014-05-06 19:38               ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5363C43F.6050304@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.