* [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420
@ 2014-05-02 12:48 Arun Kumar K
2014-05-02 15:44 ` Doug Anderson
0 siblings, 1 reply; 4+ messages in thread
From: Arun Kumar K @ 2014-05-02 12:48 UTC (permalink / raw)
To: linux-samsung-soc, devicetree; +Cc: kgene.kim, t.figa, dianders, arunkk.samsung
Adds the PWM nodes to 5420 pinctrl dtsi file.
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
index e62c8eb..ba686e4 100644
--- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
@@ -624,6 +624,34 @@
samsung,pin-drv = <0>;
};
+ pwm0_out: pwm0-out {
+ samsung,pins = "gpb2-0";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ pwm1_out: pwm1-out {
+ samsung,pins = "gpb2-1";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ pwm2_out: pwm2-out {
+ samsung,pins = "gpb2-2";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ pwm3_out: pwm3-out {
+ samsung,pins = "gpb2-3";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
i2c7_hs_bus: i2c7-hs-bus {
samsung,pins = "gpb2-2", "gpb2-3";
samsung,pin-function = <3>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420
2014-05-02 12:48 [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420 Arun Kumar K
@ 2014-05-02 15:44 ` Doug Anderson
2014-05-02 17:32 ` Tomasz Figa
0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2014-05-02 15:44 UTC (permalink / raw)
To: Arun Kumar K
Cc: linux-samsung-soc, devicetree, Kukjin Kim, Tomasz Figa, Arun Kumar
Arun,
On Fri, May 2, 2014 at 5:48 AM, Arun Kumar K <arun.kk@samsung.com> wrote:
> Adds the PWM nodes to 5420 pinctrl dtsi file.
>
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> index e62c8eb..ba686e4 100644
> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> @@ -624,6 +624,34 @@
> samsung,pin-drv = <0>;
> };
>
> + pwm0_out: pwm0-out {
> + samsung,pins = "gpb2-0";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + pwm1_out: pwm1-out {
> + samsung,pins = "gpb2-1";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + pwm2_out: pwm2-out {
> + samsung,pins = "gpb2-2";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> + pwm3_out: pwm3-out {
> + samsung,pins = "gpb2-3";
> + samsung,pin-function = <2>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> i2c7_hs_bus: i2c7-hs-bus {
> samsung,pins = "gpb2-2", "gpb2-3";
> samsung,pin-function = <3>;
Possibly pwm3-out belongs below this one (since the start pin is
"larger" than the start pin of i2c7-hs-bus). Tomasz probably has a
definite opinion on this.
Otherwise, this looks great to me. Perhaps you could send up the 5250 one, too?
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420
2014-05-02 15:44 ` Doug Anderson
@ 2014-05-02 17:32 ` Tomasz Figa
[not found] ` <5363D6BD.6070001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Figa @ 2014-05-02 17:32 UTC (permalink / raw)
To: Doug Anderson, Arun Kumar K
Cc: linux-samsung-soc, devicetree, Kukjin Kim, Tomasz Figa, Arun Kumar
Hi,
On 02.05.2014 17:44, Doug Anderson wrote:
> Arun,
>
> On Fri, May 2, 2014 at 5:48 AM, Arun Kumar K <arun.kk@samsung.com> wrote:
>> Adds the PWM nodes to 5420 pinctrl dtsi file.
>>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> index e62c8eb..ba686e4 100644
>> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
>> @@ -624,6 +624,34 @@
>> samsung,pin-drv = <0>;
>> };
>>
>> + pwm0_out: pwm0-out {
>> + samsung,pins = "gpb2-0";
>> + samsung,pin-function = <2>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +
>> + pwm1_out: pwm1-out {
>> + samsung,pins = "gpb2-1";
>> + samsung,pin-function = <2>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +
>> + pwm2_out: pwm2-out {
>> + samsung,pins = "gpb2-2";
>> + samsung,pin-function = <2>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +
>> + pwm3_out: pwm3-out {
>> + samsung,pins = "gpb2-3";
>> + samsung,pin-function = <2>;
>> + samsung,pin-pud = <0>;
>> + samsung,pin-drv = <0>;
>> + };
>> +
>> i2c7_hs_bus: i2c7-hs-bus {
>> samsung,pins = "gpb2-2", "gpb2-3";
>> samsung,pin-function = <3>;
>
> Possibly pwm3-out belongs below this one (since the start pin is
> "larger" than the start pin of i2c7-hs-bus). Tomasz probably has a
> definite opinion on this.
Well, I'm not opposed to keeping it as is. Having all the pwm nodes
together might be even more readable.
So feel free to add my Reviewed-by tag.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420
[not found] ` <5363D6BD.6070001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2014-05-06 0:29 ` Kukjin Kim
0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2014-05-06 0:29 UTC (permalink / raw)
To: 'Tomasz Figa', 'Doug Anderson', 'Arun Kumar K'
Cc: 'linux-samsung-soc',
devicetree-u79uwXL29TY76Z2rM5mHXA, 'Tomasz Figa',
'Arun Kumar'
Tomasz Figa wrote:
>
> Hi,
>
Hi,
> On 02.05.2014 17:44, Doug Anderson wrote:
> > Arun,
> >
> > On Fri, May 2, 2014 at 5:48 AM, Arun Kumar K <arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> >> Adds the PWM nodes to 5420 pinctrl dtsi file.
> >>
> >> Signed-off-by: Arun Kumar K <arun.kk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> ---
> >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 28
> ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> index e62c8eb..ba686e4 100644
> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi
> >> @@ -624,6 +624,34 @@
> >> samsung,pin-drv = <0>;
> >> };
> >>
> >> + pwm0_out: pwm0-out {
> >> + samsung,pins = "gpb2-0";
> >> + samsung,pin-function = <2>;
> >> + samsung,pin-pud = <0>;
> >> + samsung,pin-drv = <0>;
> >> + };
> >> +
> >> + pwm1_out: pwm1-out {
> >> + samsung,pins = "gpb2-1";
> >> + samsung,pin-function = <2>;
> >> + samsung,pin-pud = <0>;
> >> + samsung,pin-drv = <0>;
> >> + };
> >> +
> >> + pwm2_out: pwm2-out {
> >> + samsung,pins = "gpb2-2";
> >> + samsung,pin-function = <2>;
> >> + samsung,pin-pud = <0>;
> >> + samsung,pin-drv = <0>;
> >> + };
> >> +
> >> + pwm3_out: pwm3-out {
> >> + samsung,pins = "gpb2-3";
> >> + samsung,pin-function = <2>;
> >> + samsung,pin-pud = <0>;
> >> + samsung,pin-drv = <0>;
> >> + };
> >> +
> >> i2c7_hs_bus: i2c7-hs-bus {
> >> samsung,pins = "gpb2-2", "gpb2-3";
> >> samsung,pin-function = <3>;
> >
> > Possibly pwm3-out belongs below this one (since the start pin is
> > "larger" than the start pin of i2c7-hs-bus). Tomasz probably has a
> > definite opinion on this.
>
> Well, I'm not opposed to keeping it as is. Having all the pwm nodes
> together might be even more readable.
>
+1 ;-)
> So feel free to add my Reviewed-by tag.
>
Thanks for you two guys' review.
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-06 0:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-02 12:48 [PATCH] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5420 Arun Kumar K
2014-05-02 15:44 ` Doug Anderson
2014-05-02 17:32 ` Tomasz Figa
[not found] ` <5363D6BD.6070001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-06 0:29 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.