Re: [Buildroot] [PATCH 1/1] Makefile: workaround make 4.3 issue for 'printvars and 'show-vars'

[Roosen Henri <Henri.Roosen@ginzinger.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1940 bytes --]

Hi Yann,

On Mon, 2022-08-01 at 17:30 +0200, Yann E. MORIN wrote:
> Henri, Quentin, All,
> 
> On 2022-08-01 14:49 +0000, Roosen Henri spake thusly:
> > On Mon, 2022-08-01 at 15:36 +0200, Quentin Schulz wrote:
> > > On 7/30/22 14:19, Yann E. MORIN wrote:
> > > > On 2022-07-29 21:49 +0000, Roosen Henri spake thusly:
> > > > > As the root cause seems the 'filter' command cannot handle
> > > > > large
> > > > > chunks of data, like .VARIABLES, we can workaround the
> > > > > problem by
> > > > > using a foreach command over .VARIABLES, then use the filter
> > > > > command.
> > > Just a heads-up that `make printvars` is broken (I've sent a
> > > patch
> > > for 
> > > it just now) and also that I get a segfault for `make show-vars`
> > > (`make 
> > > show-vars VARS="BUSYBOX_%" works just fine).
> > 
> > Thanks for the heads-up! I can reproduce your tests-results.
> > 
> > I made the workaround to get the 'make pkg-stats' functionality up
> > and
> > running again on recent systems with make 4.3. So I did my testing
> > for
> > 'make printvars' and 'make show-vars' with the VARS variable set
> > to:
> > 
> > "VARS=%_LICENSE %_LICENSE_FILES %_VERSION %_IGNORE_CVES %_CPE_ID"
> > 
> > Sorry I missed testing the empty VARS (=all).
> > 
> > We might revert the workaround for 'show-vars' and install the make
> > 4.3
> > check again. For 'printvars' we might keep the workaround, as until
> > now
> > no segfault could be reproduced and I think the 'pkg-stats'
> > functionality is a nice to have.
> > 
> > What do you think?
> 
> Yes, please partially revert the change to protect just show-vars, so
> that the autobuilders and plg-stats are still happy with printvars.

Or.. we might be able to fix show-vars; I guess the root-cause is the
first $(info ...).  If we would be able to bring it into the $(foreach
V ...)..

> 
> Thanks!
> 
> Regards,
> Yann E. MORIN.
> 


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 7961 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot