Re: [Buildroot] [PATCH 1/1] Makefile: workaround make 4.3 issue for 'printvars and 'show-vars'

[Roosen Henri <Henri.Roosen@ginzinger.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1801 bytes --]

On Mon, 2022-08-01 at 15:36 +0200, Quentin Schulz wrote:
> Hi all,
> 

Hi Quentin,

> On 7/30/22 14:19, Yann E. MORIN wrote:
> > Henri, All,
> > 
> > On 2022-07-29 21:49 +0000, Roosen Henri spake thusly:
> > > Event though the bug with make 4.3 has been reported and fixed,
> > > there
> > > has not been a release of make with the fix for a long time, see
> > > [1].
> > > 
> > > As the root cause seems the 'filter' command cannot handle large
> > > chunks of data, like .VARIABLES, we can workaround the problem by
> > > using a foreach command over .VARIABLES, then use the filter
> > > command.
> > > 
> > > It might not be logical to program it that way, but at least the
> > > functionality is now usable.
> > 
> > Awesome! Just awesome! 👍
> > 
> > I just added a small comment in the Makefile to explain that, and
> > reference the bug.
> > 
> 
> Just a heads-up that `make printvars` is broken (I've sent a patch
> for 
> it just now) and also that I get a segfault for `make show-vars`
> (`make 
> show-vars VARS="BUSYBOX_%" works just fine).

Thanks for the heads-up! I can reproduce your tests-results.

I made the workaround to get the 'make pkg-stats' functionality up and
running again on recent systems with make 4.3. So I did my testing for
'make printvars' and 'make show-vars' with the VARS variable set to:

"VARS=%_LICENSE %_LICENSE_FILES %_VERSION %_IGNORE_CVES %_CPE_ID"

Sorry I missed testing the empty VARS (=all).

We might revert the workaround for 'show-vars' and install the make 4.3
check again. For 'printvars' we might keep the workaround, as until now
no segfault could be reproduced and I think the 'pkg-stats'
functionality is a nice to have.

What do you think?

Thanks,
Henri

> 
> Cheers,
> Quentin


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 7961 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot