All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Vivek Gautam
	<gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shc_work-JGs/UdohzUI@public.gmane.org
Subject: Re: [PATCH v2 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap
Date: Mon, 12 May 2014 10:58:26 -0600	[thread overview]
Message-ID: <5370FDB2.40704@wwwdotorg.org> (raw)
In-Reply-To: <1399723210-21569-6-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On 05/10/2014 06:00 AM, Vivek Gautam wrote:
> Using devm_ioremap_resource() API should actually be preferred over
> devm_ioremap(), since the former request the mem region first and then
> gives back the ioremap'ed memory pointer.
> devm_ioremap_resource() calls request_mem_region(), therby preventing
> other drivers to make any overlapping call to the same region.

This patch on its own works OK on Tegra. However, if a similar patch
were to be applied to the Tegra PHY driver, then I expect that would
break USB on Tegra. The reason is that the Tegra USB controller and PHY
registers are interleaved a bit randomly within the same address range,
and rather than call out which individual addresses are relevant to the
controller and the PHY, the DT for both devices just specifies the same
whole range, and the drivers only touch the appropriate registers within
the range. Perhaps we should have described that as an MFD rather than
separate DT nodes and devices, but that's not what we ended up with.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Vivek Gautam <gautam.vivek@samsung.com>, linux-usb@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
	stern@rowland.harvard.edu, kgene.kim@samsung.com,
	thierry.reding@gmail.com, shc_work@mail.ru
Subject: Re: [PATCH v2 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap
Date: Mon, 12 May 2014 10:58:26 -0600	[thread overview]
Message-ID: <5370FDB2.40704@wwwdotorg.org> (raw)
In-Reply-To: <1399723210-21569-6-git-send-email-gautam.vivek@samsung.com>

On 05/10/2014 06:00 AM, Vivek Gautam wrote:
> Using devm_ioremap_resource() API should actually be preferred over
> devm_ioremap(), since the former request the mem region first and then
> gives back the ioremap'ed memory pointer.
> devm_ioremap_resource() calls request_mem_region(), therby preventing
> other drivers to make any overlapping call to the same region.

This patch on its own works OK on Tegra. However, if a similar patch
were to be applied to the Tegra PHY driver, then I expect that would
break USB on Tegra. The reason is that the Tegra USB controller and PHY
registers are interleaved a bit randomly within the same address range,
and rather than call out which individual addresses are relevant to the
controller and the PHY, the DT for both devices just specifies the same
whole range, and the drivers only touch the appropriate registers within
the range. Perhaps we should have described that as an MFD rather than
separate DT nodes and devices, but that's not what we ended up with.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap
Date: Mon, 12 May 2014 10:58:26 -0600	[thread overview]
Message-ID: <5370FDB2.40704@wwwdotorg.org> (raw)
In-Reply-To: <1399723210-21569-6-git-send-email-gautam.vivek@samsung.com>

On 05/10/2014 06:00 AM, Vivek Gautam wrote:
> Using devm_ioremap_resource() API should actually be preferred over
> devm_ioremap(), since the former request the mem region first and then
> gives back the ioremap'ed memory pointer.
> devm_ioremap_resource() calls request_mem_region(), therby preventing
> other drivers to make any overlapping call to the same region.

This patch on its own works OK on Tegra. However, if a similar patch
were to be applied to the Tegra PHY driver, then I expect that would
break USB on Tegra. The reason is that the Tegra USB controller and PHY
registers are interleaved a bit randomly within the same address range,
and rather than call out which individual addresses are relevant to the
controller and the PHY, the DT for both devices just specifies the same
whole range, and the drivers only touch the appropriate registers within
the range. Perhaps we should have described that as an MFD rather than
separate DT nodes and devices, but that's not what we ended up with.

  parent reply	other threads:[~2014-05-12 16:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 12:00 [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory Vivek Gautam
2014-05-10 12:00 ` Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 2/6] usb: host: ehci-msm: " Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 3/6] usb: host: ehci-mv: " Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 4/6] usb: host: ehci-spear: " Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 5/6] usb: host: ehci-tegra: " Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
     [not found]   ` <1399723210-21569-6-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-12 16:58     ` Stephen Warren [this message]
2014-05-12 16:58       ` Stephen Warren
2014-05-12 16:58       ` Stephen Warren
2014-05-10 12:00 ` [PATCH v2 6/6] usb: host: ohci-exynos: " Vivek Gautam
2014-05-10 12:00   ` Vivek Gautam
2014-06-04 10:11   ` Vivek Gautam
2014-06-04 10:11     ` Vivek Gautam
2014-06-04 10:11     ` Vivek Gautam
     [not found]     ` <CAFp+6iFufCh6SVEF-HQA62ZsJGJGSebDSs28eqcrMy1X8e5vjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 13:13       ` Thierry Reding
2014-06-04 13:13         ` Thierry Reding
2014-06-04 13:13         ` Thierry Reding
2014-06-06 13:02         ` Vivek Gautam
2014-06-06 13:02           ` Vivek Gautam
2014-06-06 13:02           ` Vivek Gautam
     [not found]           ` <CAFp+6iEe8fvxboG79=2s=oe4BkQJYAoVUPtYkPdjJHCe+bC=8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-06 22:52             ` Thierry Reding
2014-06-06 22:52               ` Thierry Reding
2014-06-06 22:52               ` Thierry Reding
2014-06-24  5:49               ` Vivek Gautam
2014-06-24  5:49                 ` Vivek Gautam
2014-06-24  5:49                 ` Vivek Gautam
2014-05-10 14:25 ` [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory Alexander Shiyan
2014-05-10 14:25   ` Alexander Shiyan
2014-05-10 14:25   ` Alexander Shiyan
2014-05-11 14:45   ` Vivek Gautam
2014-05-11 14:45     ` Vivek Gautam
2014-05-11 14:45     ` Vivek Gautam
     [not found] ` <1399723210-21569-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-12 14:08   ` Alan Stern
2014-05-12 14:08     ` Alan Stern
2014-05-12 14:08     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5370FDB2.40704@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shc_work-JGs/UdohzUI@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.