All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: shawnguo@kernel.org, stefan@agner.ch, robh+dt@kernel.org,
	srinivas.kandagatla@linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform
Date: Thu, 07 Jul 2016 09:22:43 +0200	[thread overview]
Message-ID: <5371423.yp5pHjKp9V@wuerfel> (raw)
In-Reply-To: <f600ac1c747813b26c80149b6fdf32d42b114235.1467872014.git.maitysanchayan@gmail.com>

On Thursday, July 7, 2016 12:09:29 PM CEST Sanchayan Maity wrote:
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat family
> Freescale Vybrid VF610
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat machine
> Freescale Vybrid
> 

I only have one very high-level comment: I think that "family"
is generally supposed to be the more generic one than "machine",
so maybe swap the contents of the two?

Can you have a look at the other users of soc_device and see how
they handle it? I realize that we are already inconsistent about
how we handle it, just try to make it do what the majority of the
others have.

Aside from that, it all looks reasonable.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	stefan-XLVq0VzYD2Y@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform
Date: Thu, 07 Jul 2016 09:22:43 +0200	[thread overview]
Message-ID: <5371423.yp5pHjKp9V@wuerfel> (raw)
In-Reply-To: <f600ac1c747813b26c80149b6fdf32d42b114235.1467872014.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Thursday, July 7, 2016 12:09:29 PM CEST Sanchayan Maity wrote:
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat family
> Freescale Vybrid VF610
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat machine
> Freescale Vybrid
> 

I only have one very high-level comment: I think that "family"
is generally supposed to be the more generic one than "machine",
so maybe swap the contents of the two?

Can you have a look at the other users of soc_device and see how
they handle it? I realize that we are already inconsistent about
how we handle it, just try to make it do what the majority of the
others have.

Aside from that, it all looks reasonable.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform
Date: Thu, 07 Jul 2016 09:22:43 +0200	[thread overview]
Message-ID: <5371423.yp5pHjKp9V@wuerfel> (raw)
In-Reply-To: <f600ac1c747813b26c80149b6fdf32d42b114235.1467872014.git.maitysanchayan@gmail.com>

On Thursday, July 7, 2016 12:09:29 PM CEST Sanchayan Maity wrote:
> root at colibri-vf:/sys/bus/soc/devices/soc0# cat family
> Freescale Vybrid VF610
> root at colibri-vf:/sys/bus/soc/devices/soc0# cat machine
> Freescale Vybrid
> 

I only have one very high-level comment: I think that "family"
is generally supposed to be the more generic one than "machine",
so maybe swap the contents of the two?

Can you have a look at the other users of soc_device and see how
they handle it? I realize that we are already inconsistent about
how we handle it, just try to make it do what the majority of the
others have.

Aside from that, it all looks reasonable.

	Arnd

  reply	other threads:[~2016-07-07  7:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  6:39 [PATCH v4 0/5] Implement SoC driver for Vybrid Sanchayan Maity
2016-07-07  6:39 ` Sanchayan Maity
2016-07-07  6:39 ` [PATCH v4 1/5] ARM: dts: vfxxx: Add device tree node for OCOTP Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  6:39 ` [PATCH v4 2/5] ARM: dts: vfxxx: Add On-Chip ROM node for Vybrid Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  6:39 ` [PATCH v4 3/5] nvmem: core: Add consumer API to get nvmem cell from node Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  9:18   ` Srinivas Kandagatla
2016-07-07  9:18     ` Srinivas Kandagatla
2016-07-07  9:18     ` Srinivas Kandagatla
2016-07-07 12:33     ` maitysanchayan
2016-07-07 12:33       ` maitysanchayan at gmail.com
2016-07-07 12:33       ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
2016-07-07 13:16       ` Srinivas Kandagatla
2016-07-07 13:16         ` Srinivas Kandagatla
2016-07-07 13:48         ` maitysanchayan
2016-07-07 13:48           ` maitysanchayan at gmail.com
2016-07-07 13:48           ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
2016-07-08 15:41           ` Srinivas Kandagatla
2016-07-08 15:41             ` Srinivas Kandagatla
2016-07-08 15:41             ` Srinivas Kandagatla
2016-07-08 16:42             ` Stefan Agner
2016-07-08 16:42               ` Stefan Agner
2016-07-08 16:42               ` Stefan Agner
2016-07-08 17:23               ` Srinivas Kandagatla
2016-07-08 17:23                 ` Srinivas Kandagatla
2016-07-14  5:28                 ` Stefan Agner
2016-07-14  5:28                   ` Stefan Agner
2016-07-14  5:28                   ` Stefan Agner
2016-08-02  5:34                 ` maitysanchayan
2016-08-02  5:34                   ` maitysanchayan at gmail.com
2016-08-02  5:34                   ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
2016-07-07  6:39 ` [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity
2016-07-07  7:22   ` Arnd Bergmann [this message]
2016-07-07  7:22     ` Arnd Bergmann
2016-07-07  7:22     ` Arnd Bergmann
2016-07-07 22:25   ` kbuild test robot
2016-07-07 22:25     ` kbuild test robot
2016-07-07 22:25     ` kbuild test robot
2016-07-07  6:39 ` [PATCH v4 5/5] ARM: dts: vfxxx: Add a compatible binding for Vybrid SoC bus driver Sanchayan Maity
2016-07-07  6:39   ` Sanchayan Maity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5371423.yp5pHjKp9V@wuerfel \
    --to=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.