From: Alexander Holler <holler@ahsoftware.de> To: Tomasz Figa <tomasz.figa@gmail.com>, linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Russell King <linux@arm.linux.org.uk>, Jon Loeliger <jdl@jdl.com>, Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [RFC PATCH 1/9] dt: deps: dtc: Automatically add new property 'dependencies' which contains a list of referenced phandles Date: Mon, 19 May 2014 14:35:49 +0200 [thread overview] Message-ID: <5379FAA5.10404@ahsoftware.de> (raw) In-Reply-To: <53775334.3030704@gmail.com> Am 17.05.2014 14:16, schrieb Tomasz Figa: >> References to phandles of parent or child nodes will not be added to this >> property, because this information is already contained in the blob (in the >> form of the tree itself). > > I wonder if we shouldn't be including them too for consistency related > reasons, so we have all the necessary information in one place. > References to child nodes are great recipes for cycles, though... > > No strong opinion, though, just an idea. As said, they are already in the tree itself. And they are already included in the graph (these are the black edges), so they just don't appear in the property dependencies. > >> >> No dependencies to disabled nodes will be added. >> > > Same here. IMHO it might be wise to let the parsing entity (e.g. kernel) > decide whether to ignore a dependency to disabled node or not. > > Otherwise, I like the simplicity of compile-time dependency list > creation. Quite a nice work. Thanks. What's still questionable about the patches for dtc is if dependencies to devices and not just drivers should be included in the new property dependencies too. My current assumption is that all devices belonging to one and the same driver don't have dependencies between each other. In other words the order in which devices will be attached to one and the same driver isn't important. If that assumption is correct it would be possible to just attach all devices belonging to a driver after the driver was loaded (also I haven't that done in my patches). And thinking about that again, I think I was wrong and doing so have been some kind of evil premature optimization I did in order to spare a few dependencies/edges. But changing this can done by removing a few lines in the code for dtc (patch 1). Regards, Alexander Holler
WARNING: multiple messages have this Message-ID (diff)
From: holler@ahsoftware.de (Alexander Holler) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 1/9] dt: deps: dtc: Automatically add new property 'dependencies' which contains a list of referenced phandles Date: Mon, 19 May 2014 14:35:49 +0200 [thread overview] Message-ID: <5379FAA5.10404@ahsoftware.de> (raw) In-Reply-To: <53775334.3030704@gmail.com> Am 17.05.2014 14:16, schrieb Tomasz Figa: >> References to phandles of parent or child nodes will not be added to this >> property, because this information is already contained in the blob (in the >> form of the tree itself). > > I wonder if we shouldn't be including them too for consistency related > reasons, so we have all the necessary information in one place. > References to child nodes are great recipes for cycles, though... > > No strong opinion, though, just an idea. As said, they are already in the tree itself. And they are already included in the graph (these are the black edges), so they just don't appear in the property dependencies. > >> >> No dependencies to disabled nodes will be added. >> > > Same here. IMHO it might be wise to let the parsing entity (e.g. kernel) > decide whether to ignore a dependency to disabled node or not. > > Otherwise, I like the simplicity of compile-time dependency list > creation. Quite a nice work. Thanks. What's still questionable about the patches for dtc is if dependencies to devices and not just drivers should be included in the new property dependencies too. My current assumption is that all devices belonging to one and the same driver don't have dependencies between each other. In other words the order in which devices will be attached to one and the same driver isn't important. If that assumption is correct it would be possible to just attach all devices belonging to a driver after the driver was loaded (also I haven't that done in my patches). And thinking about that again, I think I was wrong and doing so have been some kind of evil premature optimization I did in order to spare a few dependencies/edges. But changing this can done by removing a few lines in the code for dtc (patch 1). Regards, Alexander Holler
next prev parent reply other threads:[~2014-05-19 12:36 UTC|newest] Thread overview: 258+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-12 16:47 [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 1/9] dt: deps: dtc: Automatically add new property 'dependencies' which contains a list of referenced phandles Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-17 12:16 ` Tomasz Figa 2014-05-17 12:16 ` Tomasz Figa 2014-05-17 12:16 ` Tomasz Figa 2014-05-19 12:35 ` Alexander Holler [this message] 2014-05-19 12:35 ` Alexander Holler 2014-05-19 15:38 ` Jon Loeliger 2014-05-19 15:49 ` Jon Loeliger 2014-05-19 17:26 ` Alexander Holler 2014-05-19 17:26 ` Alexander Holler 2014-05-19 17:26 ` Alexander Holler 2014-05-27 20:02 ` Grant Likely 2014-05-27 20:02 ` Grant Likely 2014-05-27 20:02 ` Grant Likely 2014-05-27 20:31 ` Alexander Holler 2014-05-27 20:31 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 2/9] dt: deps: dependency based device creation Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-14 14:05 ` Grant Likely 2014-05-14 14:05 ` Grant Likely 2014-05-14 14:05 ` Grant Likely 2014-05-14 14:49 ` Alexander Holler 2014-05-14 14:49 ` Alexander Holler 2014-05-14 14:49 ` Alexander Holler 2014-05-14 17:20 ` Alexander Holler 2014-05-14 17:20 ` Alexander Holler 2014-05-14 20:06 ` Grant Likely 2014-05-14 20:06 ` Grant Likely 2014-05-14 20:06 ` Grant Likely 2014-05-14 21:10 ` Alexander Holler 2014-05-14 21:10 ` Alexander Holler 2014-05-16 11:00 ` Grant Likely 2014-05-16 11:00 ` Grant Likely 2014-05-16 11:00 ` Grant Likely 2014-05-18 9:53 ` Alexander Holler 2014-05-18 9:53 ` Alexander Holler 2014-05-16 17:31 ` Alexander Shiyan 2014-05-16 17:31 ` Alexander Shiyan 2014-05-16 17:31 ` Alexander Shiyan [not found] ` <5373DBCF.1080503-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> 2014-05-16 17:31 ` Alexander Shiyan 2014-05-16 17:31 ` Alexander Shiyan 2014-05-14 15:51 ` Alexander Holler 2014-05-14 15:51 ` Alexander Holler 2014-05-17 14:24 ` Tomasz Figa 2014-05-17 14:24 ` Tomasz Figa 2014-05-18 14:59 ` Grant Likely 2014-05-18 14:59 ` Grant Likely 2014-05-19 8:41 ` Alexander Holler 2014-05-19 8:41 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 3/9] dt: deps: dtc: Add option to print initialization order Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 20:38 ` Jon Loeliger 2014-05-12 22:58 ` Alexander Holler 2014-05-12 22:58 ` Alexander Holler 2014-05-12 22:58 ` Alexander Holler [not found] ` <537151FF.8070104-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> 2014-05-13 8:54 ` [PATCH 0/3] add dependencies Alexander Holler [not found] ` <1399971243-18153-1-git-send-email-holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> 2014-05-13 8:54 ` [PATCH 1/3] deps: Automatically add new property 'dependencies' which contains a list of referenced phandles Alexander Holler 2014-05-13 8:54 ` [PATCH 2/3] deps: Add option to print initialization order Alexander Holler 2014-05-13 8:54 ` [PATCH 3/3] deps: Add option to print dependency graph as dot (Graphviz) Alexander Holler 2014-05-13 18:48 ` [PATCH] deps: introduce new (virtual) property no-dependencies Alexander Holler [not found] ` <1400006923-7950-1-git-send-email-holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> 2014-05-14 1:55 ` Alexander Holler [not found] ` <5372CD15.5020001-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> 2014-05-14 7:02 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 4/9] dt: deps: dtc: Add option to print dependency graph as dot (Graphviz) Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 5/9] dt: deps: register drivers based on the initialization order based on DT Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-14 14:13 ` Grant Likely 2014-05-14 14:13 ` Grant Likely 2014-05-14 14:13 ` Grant Likely 2014-05-14 14:58 ` Alexander Holler 2014-05-14 14:58 ` Alexander Holler 2014-05-14 14:58 ` Alexander Holler 2014-05-14 19:32 ` Grant Likely 2014-05-14 19:32 ` Grant Likely 2014-05-14 19:32 ` Grant Likely 2014-05-12 16:47 ` [RFC PATCH 6/9] dt: deps: WIP: well done drivers Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 7/9] dt: deps: kirkwood: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:47 ` [RFC PATCH 8/9] dt: deps: dts: kirkwood: dockstar: add dependency ehci -> usb power regulator Alexander Holler 2014-05-12 16:47 ` Alexander Holler 2014-05-12 16:48 ` [RFC PATCH 9/9] dt: deps: omap2: make it possible to use CONFIG_OF_DEPENDENCIES Alexander Holler 2014-05-12 16:48 ` Alexander Holler 2014-05-13 15:40 ` [PATCH 10/9] dt: deps: fix bug not registering late drivers when OF_DEPENDENCIES is disabled Alexander Holler 2014-05-13 15:40 ` Alexander Holler 2014-05-13 15:40 ` Alexander Holler 2014-05-13 19:27 ` [RFC PATCH 11/9] dt: deps: dtc: introduce new (virtual) property no-dependencies Alexander Holler 2014-05-13 19:27 ` Alexander Holler 2014-05-13 19:27 ` Alexander Holler 2014-05-14 8:20 ` dt: deps: some tips about how to debug/evaluate this feature Alexander Holler 2014-05-14 14:19 ` [RFC PATCH 0/9] dt: dependencies (for deterministic driver initialization order based on the DT) Grant Likely 2014-05-14 14:19 ` Grant Likely 2014-05-14 14:19 ` Grant Likely 2014-05-14 15:02 ` Alexander Holler 2014-05-14 15:02 ` Alexander Holler 2014-05-14 16:05 ` Grant Likely 2014-05-14 16:05 ` Grant Likely 2014-05-14 16:05 ` Grant Likely 2014-05-14 16:23 ` Alexander Holler 2014-05-14 16:23 ` Alexander Holler 2014-05-14 16:23 ` Alexander Holler 2014-05-14 17:30 ` Rob Herring 2014-05-14 17:30 ` Rob Herring 2014-05-14 17:30 ` Rob Herring 2014-05-14 17:45 ` Alexander Holler 2014-05-14 17:45 ` Alexander Holler 2014-05-14 17:45 ` Alexander Holler 2014-05-14 17:53 ` Alexander Holler 2014-05-14 17:53 ` Alexander Holler 2014-05-14 17:53 ` Alexander Holler 2014-05-14 18:16 ` Alexander Holler 2014-05-14 18:16 ` Alexander Holler 2014-05-14 18:16 ` Alexander Holler 2014-05-14 19:13 ` Alexander Holler 2014-05-14 19:13 ` Alexander Holler 2014-05-14 19:13 ` Alexander Holler 2014-05-14 19:06 ` Rob Herring 2014-05-14 19:06 ` Rob Herring 2014-05-14 19:06 ` Rob Herring 2014-05-14 19:24 ` Alexander Holler 2014-05-14 19:24 ` Alexander Holler 2014-05-14 19:24 ` Alexander Holler 2014-05-15 1:46 ` Alexander Holler 2014-05-15 1:46 ` Alexander Holler 2014-05-15 1:46 ` Alexander Holler 2014-05-14 23:00 ` Alexander Holler 2014-05-14 23:00 ` Alexander Holler 2014-05-14 23:00 ` Alexander Holler 2014-08-21 14:02 ` Thierry Reding 2014-08-21 14:02 ` Thierry Reding 2014-08-21 14:02 ` Thierry Reding 2014-08-21 19:19 ` Alexander Holler 2014-08-21 19:19 ` Alexander Holler 2014-08-21 19:19 ` Alexander Holler 2014-08-22 13:19 ` Mark Rutland 2014-08-22 13:19 ` Mark Rutland 2014-08-22 13:19 ` Mark Rutland 2014-08-22 15:45 ` Alexander Holler 2014-08-22 15:45 ` Alexander Holler 2014-08-22 15:45 ` Alexander Holler 2014-08-25 9:39 ` Thierry Reding 2014-08-25 9:39 ` Thierry Reding 2014-08-25 9:39 ` Thierry Reding 2014-08-25 13:08 ` Jon Loeliger 2014-08-25 13:08 ` Jon Loeliger 2014-08-25 13:08 ` Jon Loeliger 2014-08-25 13:37 ` Thierry Reding 2014-08-25 13:37 ` Thierry Reding 2014-08-25 13:37 ` Thierry Reding 2014-08-25 14:13 ` Jon Loeliger 2014-08-25 14:13 ` Jon Loeliger 2014-08-25 14:13 ` Jon Loeliger 2014-08-25 14:41 ` Thierry Reding 2014-08-25 14:41 ` Thierry Reding 2014-08-25 14:41 ` Thierry Reding 2014-08-26 8:42 ` Grant Likely 2014-08-26 8:42 ` Grant Likely 2014-08-26 8:42 ` Grant Likely 2014-08-26 8:49 ` Thierry Reding 2014-08-26 8:49 ` Thierry Reding 2014-08-26 8:49 ` Thierry Reding 2014-08-26 9:42 ` Alexander Holler 2014-08-26 9:42 ` Alexander Holler 2014-08-26 9:42 ` Alexander Holler 2014-08-26 10:11 ` Mark Rutland 2014-08-26 10:11 ` Mark Rutland 2014-08-26 10:11 ` Mark Rutland 2014-08-26 10:24 ` Thierry Reding 2014-08-26 10:24 ` Thierry Reding 2014-08-26 10:24 ` Thierry Reding 2014-08-27 10:34 ` Grant Likely 2014-08-27 10:34 ` Grant Likely 2014-08-27 10:34 ` Grant Likely 2014-08-27 14:44 ` Catalin Marinas 2014-08-27 14:44 ` Catalin Marinas 2014-08-27 14:44 ` Catalin Marinas 2014-08-27 16:22 ` Stephen Warren 2014-08-27 16:22 ` Stephen Warren 2014-08-27 16:22 ` Stephen Warren 2014-08-27 16:30 ` Alexander Holler 2014-08-27 16:30 ` Alexander Holler 2014-08-27 16:30 ` Alexander Holler 2014-08-27 16:37 ` Stephen Warren 2014-08-27 16:37 ` Stephen Warren 2014-08-27 16:37 ` Stephen Warren 2014-08-27 16:58 ` Alexander Holler 2014-08-27 16:58 ` Alexander Holler 2014-08-27 16:58 ` Alexander Holler 2014-08-27 17:52 ` Catalin Marinas 2014-08-27 17:52 ` Catalin Marinas 2014-08-27 17:52 ` Catalin Marinas 2014-08-27 18:14 ` Alexander Holler 2014-08-27 18:14 ` Alexander Holler 2014-08-27 18:14 ` Alexander Holler 2014-08-28 6:50 ` Alexander Holler 2014-08-28 6:50 ` Alexander Holler 2014-08-28 6:50 ` Alexander Holler 2014-08-28 9:23 ` Catalin Marinas 2014-08-28 9:23 ` Catalin Marinas 2014-08-28 9:23 ` Catalin Marinas 2014-08-29 1:43 ` Alexander Holler 2014-08-29 1:43 ` Alexander Holler 2014-08-29 1:43 ` Alexander Holler 2014-08-26 10:25 ` Thierry Reding 2014-08-26 10:25 ` Thierry Reding 2014-08-26 10:25 ` Thierry Reding 2014-08-26 10:44 ` Alexander Holler 2014-08-26 10:44 ` Alexander Holler 2014-08-26 10:44 ` Alexander Holler 2014-08-26 11:01 ` Alexander Holler 2014-08-26 11:01 ` Alexander Holler 2014-08-26 11:01 ` Alexander Holler 2014-08-26 11:08 ` Thierry Reding 2014-08-26 11:08 ` Thierry Reding 2014-08-26 11:08 ` Thierry Reding 2014-08-26 11:23 ` Alexander Holler 2014-08-26 11:23 ` Alexander Holler 2014-08-26 11:23 ` Alexander Holler 2014-08-26 11:47 ` Thierry Reding 2014-08-26 11:47 ` Thierry Reding 2014-08-26 11:47 ` Thierry Reding 2014-08-26 12:00 ` Alexander Holler 2014-08-26 12:00 ` Alexander Holler 2014-08-26 12:00 ` Alexander Holler 2014-08-26 13:58 ` Jon Loeliger 2014-08-26 13:58 ` Jon Loeliger 2014-08-26 13:58 ` Jon Loeliger 2014-08-26 14:17 ` Thierry Reding 2014-08-26 14:17 ` Thierry Reding 2014-08-26 14:17 ` Thierry Reding 2014-08-27 7:16 ` Alexander Holler 2014-08-27 7:16 ` Alexander Holler 2014-08-27 7:16 ` Alexander Holler 2014-08-27 9:26 ` Alexander Holler 2014-08-27 9:26 ` Alexander Holler 2014-08-27 9:26 ` Alexander Holler 2014-08-26 7:56 ` Alexander Holler 2014-08-26 7:56 ` Alexander Holler 2014-08-26 7:56 ` Alexander Holler 2014-08-26 8:51 ` Grant Likely 2014-08-26 8:51 ` Grant Likely 2014-08-26 8:51 ` Grant Likely 2014-08-26 9:56 ` Alexander Holler 2014-08-26 9:56 ` Alexander Holler 2014-08-26 9:56 ` Alexander Holler 2014-08-26 10:18 ` Alexander Holler 2014-08-26 10:18 ` Alexander Holler 2014-08-26 10:18 ` Alexander Holler 2014-08-26 9:54 ` Mark Rutland 2014-08-26 9:54 ` Mark Rutland 2014-08-26 9:54 ` Mark Rutland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5379FAA5.10404@ahsoftware.de \ --to=holler@ahsoftware.de \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jdl@jdl.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=robh+dt@kernel.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.