From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org, Stephen Boyd <sboyd@kernel.org>
Cc: kernel@esmil.dk, linux-clk@vger.kernel.org, mturquette@baylibre.com
Subject: Re: [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling
Date: Thu, 28 Oct 2021 01:20:17 +0200 [thread overview]
Message-ID: <5381956.U9aoDET0nm@diego> (raw)
In-Reply-To: <163536646616.15791.10163287623335903483@swboyd.mtv.corp.google.com>
Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > and subsequently allowing them to be built as modules introduced some
> > problems.
> >
> > These two patches try to correct them.
>
> By removing modular support? Ok.
It looked like the easiest way to go for now.
With all the clock-definitions as init-data still in both drivers, I don't think
anybody ever tested running this as a real module.
We could of course also remove all the __init + __initdata attributes, but
still wouldn't know if it actually runs as a module, without someone
building a real test environment for it.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org, Stephen Boyd <sboyd@kernel.org>
Cc: kernel@esmil.dk, linux-clk@vger.kernel.org, mturquette@baylibre.com
Subject: Re: [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling
Date: Thu, 28 Oct 2021 01:20:17 +0200 [thread overview]
Message-ID: <5381956.U9aoDET0nm@diego> (raw)
In-Reply-To: <163536646616.15791.10163287623335903483@swboyd.mtv.corp.google.com>
Am Mittwoch, 27. Oktober 2021, 22:27:46 CEST schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2021-10-27 06:26:14)
> > Recent conversions or inclusions of rk3399 and rk3568 as platform-drivers
> > and subsequently allowing them to be built as modules introduced some
> > problems.
> >
> > These two patches try to correct them.
>
> By removing modular support? Ok.
It looked like the easiest way to go for now.
With all the clock-definitions as init-data still in both drivers, I don't think
anybody ever tested running this as a real module.
We could of course also remove all the __init + __initdata attributes, but
still wouldn't know if it actually runs as a module, without someone
building a real test environment for it.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-10-27 23:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:26 [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling Heiko Stuebner
2021-10-27 13:26 ` Heiko Stuebner
2021-10-27 13:26 ` [PATCH 1/2] Revert "clk: rockchip: use module_platform_driver_probe" Heiko Stuebner
2021-10-27 13:26 ` Heiko Stuebner
2021-10-29 6:42 ` Stephen Boyd
2021-10-29 6:42 ` Stephen Boyd
2021-10-27 13:26 ` [PATCH 2/2] clk: rockchip: drop module parts from rk3399 and rk3568 drivers Heiko Stuebner
2021-10-27 13:26 ` Heiko Stuebner
2021-10-29 6:42 ` Stephen Boyd
2021-10-29 6:42 ` Stephen Boyd
2021-10-27 20:27 ` [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling Stephen Boyd
2021-10-27 20:27 ` Stephen Boyd
2021-10-27 23:20 ` Heiko Stübner [this message]
2021-10-27 23:20 ` Heiko Stübner
2021-10-29 6:43 ` Stephen Boyd
2021-10-29 6:43 ` Stephen Boyd
2021-10-29 12:37 ` Heiko Stübner
2021-10-29 12:37 ` Heiko Stübner
2021-11-03 0:59 ` Stephen Boyd
2021-11-03 0:59 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5381956.U9aoDET0nm@diego \
--to=heiko@sntech.de \
--cc=kernel@esmil.dk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.