All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hw: vmware_vga: don't return cursorx when the driver asks for cursory register
@ 2014-06-09  5:19 mischief
  2014-06-10 15:40 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
  0 siblings, 1 reply; 2+ messages in thread
From: mischief @ 2014-06-09  5:19 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

hello qemu-*@nongnu.org, this is my first contribution. apologies if
something is incorrect.

this patch fixes vmware_vga.c so that it actually returns the cursory
register when asked for, instead of cursorx.

Signed-off-by: Nicolas Owens <mischief@offblast.org>
---
 hw/display/vmware_vga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 9ba47e6..ab54b6f 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -863,7 +863,7 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t address)
         break;
 
     case SVGA_REG_CURSOR_Y:
-        ret = s->cursor.x;
+        ret = s->cursor.y;
         break;
 
     case SVGA_REG_CURSOR_ON:
-- 
2.0.0


[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: vmware_vga: don't return cursorx when the driver asks for cursory register
  2014-06-09  5:19 [Qemu-devel] [PATCH] hw: vmware_vga: don't return cursorx when the driver asks for cursory register mischief
@ 2014-06-10 15:40 ` Michael Tokarev
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2014-06-10 15:40 UTC (permalink / raw)
  To: mischief, qemu-devel; +Cc: qemu-trivial

09.06.2014 09:19, mischief wrote:
> hello qemu-*@nongnu.org, this is my first contribution. apologies if
> something is incorrect.
> 
> this patch fixes vmware_vga.c so that it actually returns the cursory
> register when asked for, instead of cursorx.

That's a good one.  Thank you, applied to -trivial.

/mjt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-10 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09  5:19 [Qemu-devel] [PATCH] hw: vmware_vga: don't return cursorx when the driver asks for cursory register mischief
2014-06-10 15:40 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.