All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: kgene.kim@samsung.com, linux@arm.linux.org.uk,
	chow.kim@samsung.com, yg1004.jang@samsung.com,
	vikas.sajjan@samsung.com
Subject: Re: [PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT
Date: Tue, 10 Jun 2014 19:10:35 +0200	[thread overview]
Message-ID: <53973C0B.2000903@samsung.com> (raw)
In-Reply-To: <1399704998-13321-7-git-send-email-pankaj.dubey@samsung.com>

Hi,

On 10.05.2014 08:56, Pankaj Dubey wrote:
> From: Young-Gun Jang <yg1004.jang@samsung.com>
> 
> Add support for mapping Samsung Power Management Unit (PMU)
> base address from device tree. This patch also adds helper
> function as "get_exynos_pmuregmap". This function can be used
> by other machine files such as "pm.c", "hotplug.c" for accessing
> PMU regmap handle.
> 

I don't think there is a need to use regmap to provide access to PMU to
such low level code such as pm.c or hotplug.c. Moreover, I believe that
it might be undesirable in some cases, e.g. very low level code running
at early resume or late suspend.

IMHO, based on what we now have for SYSRAM, you could simply map PMU
from device tree one time, before SMP init, and keep the address in some
globally accessible variable, like those for SYSRAM we have right now
(sysram_base_addr, sysram_ns_base_addr -> pmu_base_addr).

Then, registration of the normal syscon would happen through standard
platform driver mechanisms and no special early handling would be necessary.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT
Date: Tue, 10 Jun 2014 19:10:35 +0200	[thread overview]
Message-ID: <53973C0B.2000903@samsung.com> (raw)
In-Reply-To: <1399704998-13321-7-git-send-email-pankaj.dubey@samsung.com>

Hi,

On 10.05.2014 08:56, Pankaj Dubey wrote:
> From: Young-Gun Jang <yg1004.jang@samsung.com>
> 
> Add support for mapping Samsung Power Management Unit (PMU)
> base address from device tree. This patch also adds helper
> function as "get_exynos_pmuregmap". This function can be used
> by other machine files such as "pm.c", "hotplug.c" for accessing
> PMU regmap handle.
> 

I don't think there is a need to use regmap to provide access to PMU to
such low level code such as pm.c or hotplug.c. Moreover, I believe that
it might be undesirable in some cases, e.g. very low level code running
at early resume or late suspend.

IMHO, based on what we now have for SYSRAM, you could simply map PMU
from device tree one time, before SMP init, and keep the address in some
globally accessible variable, like those for SYSRAM we have right now
(sysram_base_addr, sysram_ns_base_addr -> pmu_base_addr).

Then, registration of the normal syscon would happen through standard
platform driver mechanisms and no special early handling would be necessary.

Best regards,
Tomasz

  reply	other threads:[~2014-06-10 17:10 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10  6:56 [PATCH v4 00/11] ARM: Exynos: PMU cleanup and refactoring for using DT Pankaj Dubey
2014-05-10  6:56 ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 01/11] ARM: EXYNOS: Make exynos machine_ops as static Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-10 11:43   ` Tomasz Figa
2014-06-10 11:43     ` Tomasz Figa
2014-05-10  6:56 ` [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-10 11:46   ` Tomasz Figa
2014-06-10 11:46     ` Tomasz Figa
2014-06-17  3:48     ` Pankaj Dubey
2014-06-17  3:48       ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 03/11] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 04/11] ARM: EXYNOS: Remove file path from comment section Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 05/11] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-10 17:10   ` Tomasz Figa [this message]
2014-06-10 17:10     ` Tomasz Figa
2014-06-17  6:43     ` Pankaj Dubey
2014-06-17  6:43       ` Pankaj Dubey
2014-06-17 15:26       ` Tomasz Figa
2014-06-17 15:26         ` Tomasz Figa
2014-06-17 15:32         ` [PATCH RFC] mfd: syscon: Decouple syscon interface from syscon devices Tomasz Figa
2014-06-17 15:32           ` Tomasz Figa
2014-06-17 15:42           ` Arnd Bergmann
2014-06-17 15:42             ` Arnd Bergmann
2014-06-17 21:26             ` Tomasz Figa
2014-06-17 21:26               ` Tomasz Figa
2014-06-18  8:26               ` Lee Jones
2014-06-18  8:26                 ` Lee Jones
2014-06-24 11:03                 ` Pankaj Dubey
2014-06-24 11:03                   ` Pankaj Dubey
2014-06-18 12:57               ` Arnd Bergmann
2014-06-18 12:57                 ` Arnd Bergmann
2014-06-19  0:06                 ` Michal Simek
2014-06-19  0:06                   ` Michal Simek
2014-07-28  4:15                 ` Pankaj Dubey
2014-07-28  4:15                   ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 07/11] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 08/11] ARM: EXYNOS: Refactored code for using PMU address via DT Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-17 16:02   ` Tomasz Figa
2014-06-17 16:02     ` Tomasz Figa
2014-05-10  6:56 ` [PATCH v4 09/11] ARM: EXYNOS: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-17 16:04   ` Tomasz Figa
2014-06-17 16:04     ` Tomasz Figa
2014-05-10  6:56 ` [PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-06-17 17:12   ` Tomasz Figa
2014-06-17 17:12     ` Tomasz Figa
2014-06-24 11:28     ` Pankaj Dubey
2014-06-24 11:28       ` Pankaj Dubey
2014-06-25  0:11       ` Tomasz Figa
2014-06-25  0:11         ` Tomasz Figa
2014-06-25  4:30         ` Pankaj Dubey
2014-06-25  4:30           ` Pankaj Dubey
2014-05-10  6:56 ` [PATCH v4 11/11] ARM: EXYNOS: Move PMU specific definitions from common.h Pankaj Dubey
2014-05-10  6:56   ` Pankaj Dubey
2014-05-27 11:26 ` [PATCH v4 00/11] ARM: Exynos: PMU cleanup and refactoring for using DT Vikas Sajjan
2014-05-27 11:26   ` Vikas Sajjan
2014-05-27 11:26   ` Vikas Sajjan
2014-05-30 11:58   ` Tomasz Figa
2014-05-30 11:58     ` Tomasz Figa
2014-05-30 11:58     ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53973C0B.2000903@samsung.com \
    --to=t.figa@samsung.com \
    --cc=chow.kim@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pankaj.dubey@samsung.com \
    --cc=vikas.sajjan@samsung.com \
    --cc=yg1004.jang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.