From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> To: Minchan Kim <minchan@kernel.org> Cc: Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Greg Thelen <gthelen@google.com>, Mel Gorman <mgorman@suse.de>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Michal Nazarewicz <mina86@mina86.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com> Subject: Re: [PATCH 07/10] mm: rename allocflags_to_migratetype for clarity Date: Wed, 11 Jun 2014 11:38:30 +0800 [thread overview] Message-ID: <5397CF36.1040103@cn.fujitsu.com> (raw) In-Reply-To: <20140611024109.GG15630@bbox> On 06/11/2014 10:41 AM, Minchan Kim wrote: > On Mon, Jun 09, 2014 at 11:26:19AM +0200, Vlastimil Babka wrote: >> From: David Rientjes <rientjes@google.com> >> >> The page allocator has gfp flags (like __GFP_WAIT) and alloc flags (like >> ALLOC_CPUSET) that have separate semantics. >> >> The function allocflags_to_migratetype() actually takes gfp flags, not alloc >> flags, and returns a migratetype. Rename it to gfpflags_to_migratetype(). >> >> Signed-off-by: David Rientjes <rientjes@google.com> >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > > I was one of person who got confused sometime. Some names in MM really make people confused. But sometimes thinking an appropriate name is also a hard thing. Like I once wanted to change the name of function nr_free_zone_pages() and also nr_free_buffer_pages(). But it is hard to name them, so at last Andrew suggested to add the detailed function description to make it clear only. Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > > Acked-by: Minchan Kim <minchan@kernel.org> > -- Thanks. Zhang Yanfei
WARNING: multiple messages have this Message-ID (diff)
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> To: Minchan Kim <minchan@kernel.org> Cc: Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Greg Thelen <gthelen@google.com>, Mel Gorman <mgorman@suse.de>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Michal Nazarewicz <mina86@mina86.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com> Subject: Re: [PATCH 07/10] mm: rename allocflags_to_migratetype for clarity Date: Wed, 11 Jun 2014 11:38:30 +0800 [thread overview] Message-ID: <5397CF36.1040103@cn.fujitsu.com> (raw) In-Reply-To: <20140611024109.GG15630@bbox> On 06/11/2014 10:41 AM, Minchan Kim wrote: > On Mon, Jun 09, 2014 at 11:26:19AM +0200, Vlastimil Babka wrote: >> From: David Rientjes <rientjes@google.com> >> >> The page allocator has gfp flags (like __GFP_WAIT) and alloc flags (like >> ALLOC_CPUSET) that have separate semantics. >> >> The function allocflags_to_migratetype() actually takes gfp flags, not alloc >> flags, and returns a migratetype. Rename it to gfpflags_to_migratetype(). >> >> Signed-off-by: David Rientjes <rientjes@google.com> >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > > I was one of person who got confused sometime. Some names in MM really make people confused. But sometimes thinking an appropriate name is also a hard thing. Like I once wanted to change the name of function nr_free_zone_pages() and also nr_free_buffer_pages(). But it is hard to name them, so at last Andrew suggested to add the detailed function description to make it clear only. Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > > Acked-by: Minchan Kim <minchan@kernel.org> > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-11 3:38 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-09 9:26 [PATCH 01/10] mm, compaction: do not recheck suitable_migration_target under lock Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-09 9:26 ` [PATCH 02/10] mm, compaction: report compaction as contended only due to lock contention Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-09 23:50 ` David Rientjes 2014-06-09 23:50 ` David Rientjes 2014-06-10 7:11 ` Vlastimil Babka 2014-06-10 7:11 ` Vlastimil Babka 2014-06-10 23:40 ` David Rientjes 2014-06-10 23:40 ` David Rientjes 2014-06-11 1:10 ` Minchan Kim 2014-06-11 1:10 ` Minchan Kim 2014-06-11 12:22 ` Vlastimil Babka 2014-06-11 12:22 ` Vlastimil Babka 2014-06-11 23:49 ` Minchan Kim 2014-06-11 23:49 ` Minchan Kim 2014-06-12 14:02 ` Vlastimil Babka 2014-06-12 14:02 ` Vlastimil Babka 2014-06-13 2:40 ` Minchan Kim 2014-06-13 2:40 ` Minchan Kim 2014-06-20 11:47 ` Vlastimil Babka 2014-06-20 11:47 ` Vlastimil Babka 2014-06-09 9:26 ` [PATCH 03/10] mm, compaction: periodically drop lock and restore IRQs in scanners Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-09 23:58 ` David Rientjes 2014-06-09 23:58 ` David Rientjes 2014-06-10 7:15 ` Vlastimil Babka 2014-06-10 7:15 ` Vlastimil Babka 2014-06-10 23:41 ` David Rientjes 2014-06-10 23:41 ` David Rientjes 2014-06-11 1:32 ` Minchan Kim 2014-06-11 1:32 ` Minchan Kim 2014-06-11 11:24 ` Vlastimil Babka 2014-06-11 11:24 ` Vlastimil Babka 2014-06-09 9:26 ` [PATCH 04/10] mm, compaction: skip rechecks when lock was already held Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-10 0:00 ` David Rientjes 2014-06-10 0:00 ` David Rientjes 2014-06-11 1:50 ` Minchan Kim 2014-06-11 1:50 ` Minchan Kim 2014-06-09 9:26 ` [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-10 0:07 ` David Rientjes 2014-06-10 0:07 ` David Rientjes 2014-06-11 2:12 ` Minchan Kim 2014-06-11 2:12 ` Minchan Kim 2014-06-11 8:16 ` Joonsoo Kim 2014-06-11 8:16 ` Joonsoo Kim 2014-06-11 11:41 ` Vlastimil Babka 2014-06-11 11:41 ` Vlastimil Babka 2014-06-11 11:33 ` Vlastimil Babka 2014-06-11 11:33 ` Vlastimil Babka 2014-06-11 3:29 ` Zhang Yanfei 2014-06-11 3:29 ` Zhang Yanfei 2014-06-09 9:26 ` [PATCH 06/10] mm, compaction: skip buddy pages by their order in the migrate scanner Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-10 0:08 ` David Rientjes 2014-06-10 0:08 ` David Rientjes 2014-06-09 9:26 ` [PATCH 07/10] mm: rename allocflags_to_migratetype for clarity Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-11 2:41 ` Minchan Kim 2014-06-11 2:41 ` Minchan Kim 2014-06-11 3:38 ` Zhang Yanfei [this message] 2014-06-11 3:38 ` Zhang Yanfei 2014-06-09 9:26 ` [PATCH 08/10] mm, compaction: pass gfp mask to compact_control Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-11 2:48 ` Minchan Kim 2014-06-11 2:48 ` Minchan Kim 2014-06-11 11:46 ` Vlastimil Babka 2014-06-11 11:46 ` Vlastimil Babka 2014-06-12 0:24 ` David Rientjes 2014-06-12 0:24 ` David Rientjes 2014-06-09 9:26 ` [RFC PATCH 09/10] mm, compaction: try to capture the just-created high-order freepage Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-11 14:56 ` Vlastimil Babka 2014-06-11 14:56 ` Vlastimil Babka 2014-06-12 2:20 ` Minchan Kim 2014-06-12 2:20 ` Minchan Kim 2014-06-12 8:21 ` Vlastimil Babka 2014-06-12 8:21 ` Vlastimil Babka 2014-06-09 9:26 ` [RFC PATCH 10/10] mm, compaction: do not migrate pages when that cannot satisfy page fault allocation Vlastimil Babka 2014-06-09 9:26 ` Vlastimil Babka 2014-06-09 23:41 ` [PATCH 01/10] mm, compaction: do not recheck suitable_migration_target under lock David Rientjes 2014-06-09 23:41 ` David Rientjes 2014-06-11 0:33 ` Minchan Kim 2014-06-11 0:33 ` Minchan Kim 2014-06-11 2:45 ` Zhang Yanfei 2014-06-11 2:45 ` Zhang Yanfei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5397CF36.1040103@cn.fujitsu.com \ --to=zhangyanfei@cn.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux.com \ --cc=gthelen@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mina86@mina86.com \ --cc=minchan@kernel.org \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=riel@redhat.com \ --cc=rientjes@google.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.