All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
Date: Thu, 12 Jun 2014 00:42:28 +0900	[thread overview]
Message-ID: <539878E4.8040005@samsung.com> (raw)
In-Reply-To: <5397242D.8040303@samsung.com>

On 06/11/14 00:28, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi Tomasz,

> On 30.05.2014 20:18, Kukjin Kim wrote:
>> On 05/30/14 20:41, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>>> to cover whole regions.
>>>>
>>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>>> ---
>>>>    arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>>> index b8ece4b..fbaf426 100644
>>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>>> @@ -113,7 +113,7 @@
>>>>    		compatible = "arm,cortex-a9-gic";
>>>>    		#interrupt-cells =<3>;
>>>>    		interrupt-controller;
>>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>>    	};
>>>>
>>>>    	combiner: interrupt-controller@10440000 {
>>>>
>>>
>>> Ping.
>>>
>> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT
>> support. Applied, but I need to check this is required for stable tree...
>
> Not sure if you already managed, but I think it might not be necessary
> in stable trees, as the (correct) static mapping is still there and it
> causes ioremap() to return correctly mapped area, ignoring the length
> specified in device tree.
>
Yes, agreed. this is not required for stable tree...

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
Date: Thu, 12 Jun 2014 00:42:28 +0900	[thread overview]
Message-ID: <539878E4.8040005@samsung.com> (raw)
In-Reply-To: <5397242D.8040303@samsung.com>

On 06/11/14 00:28, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi Tomasz,

> On 30.05.2014 20:18, Kukjin Kim wrote:
>> On 05/30/14 20:41, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>>> to cover whole regions.
>>>>
>>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>>> ---
>>>>    arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>>> index b8ece4b..fbaf426 100644
>>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>>> @@ -113,7 +113,7 @@
>>>>    		compatible = "arm,cortex-a9-gic";
>>>>    		#interrupt-cells =<3>;
>>>>    		interrupt-controller;
>>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>>    	};
>>>>
>>>>    	combiner: interrupt-controller at 10440000 {
>>>>
>>>
>>> Ping.
>>>
>> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT
>> support. Applied, but I need to check this is required for stable tree...
>
> Not sure if you already managed, but I think it might not be necessary
> in stable trees, as the (correct) static mapping is still there and it
> causes ioremap() to return correctly mapped area, ignoring the length
> specified in device tree.
>
Yes, agreed. this is not required for stable tree...

Thanks,
Kukjin

  reply	other threads:[~2014-06-11 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 14:39 [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC Tomasz Figa
2014-05-23 14:39 ` Tomasz Figa
2014-05-30 11:41 ` Tomasz Figa
2014-05-30 11:41   ` Tomasz Figa
2014-05-30 18:18   ` Kukjin Kim
2014-05-30 18:18     ` Kukjin Kim
2014-06-10 15:28     ` Tomasz Figa
2014-06-10 15:28       ` Tomasz Figa
2014-06-11 15:42       ` Kukjin Kim [this message]
2014-06-11 15:42         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539878E4.8040005@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.