[PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Guillaume Gardet]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
It fixes the following build error:
    FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.

Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>


Regards,

Guillaume


[-- Attachment #2: 0001-Fix-typo-in-drivers-phy-phy-exynos5250-sata.c-module.patch --]
[-- Type: text/x-patch, Size: 1035 bytes --]

>From d46b09fbf39bb8820b65e064482b923252379b8a Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <guillaume.gardet@opensuse.org>
Date: Thu, 12 Jun 2014 10:02:15 +0200
Subject: [PATCH] Fix typo in drivers/phy/phy-exynos5250-sata.c module
 license. It fixes the following error: FATAL: modpost:
 GPL-incompatible module phy-exynos5250-sata.ko uses
 GPL-only symbol 'platform_driver_unregister'

---
 drivers/phy/phy-exynos5250-sata.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-exynos5250-sata.c b/drivers/phy/phy-exynos5250-sata.c
index c9361b7..0568945 100644
--- a/drivers/phy/phy-exynos5250-sata.c
+++ b/drivers/phy/phy-exynos5250-sata.c
@@ -246,6 +246,6 @@ static struct platform_driver exynos_sata_phy_driver = {
 module_platform_driver(exynos_sata_phy_driver);
 
 MODULE_DESCRIPTION("Samsung SerDes PHY driver");
-MODULE_LICENSE("GPL V2");
+MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Girish K S <ks.giri@samsung.com>");
 MODULE_AUTHOR("Yuvaraj C D <yuvaraj.cd@samsung.com>");
-- 
1.7.10.4

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Sachin Kamat]

Hi Guillaume,


On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
<guillaume.gardet@free.fr> wrote:
> Hi,
>
> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
> It fixes the following build error:
>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
>
> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>

A similar patch has already been submitted by Arnd. Please see below:
https://lkml.org/lkml/2014/3/15/40

In general, sending an attachment is not the right way to submit a patch.
Please refer Documentation/SubmittingPatches in the kernel source for the
correct procedure.

Regards,
Sachin.

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Guillaume Gardet]

Le 12/06/2014 10:36, Sachin Kamat a écrit :
> Hi Guillaume,
>
>
> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
> <guillaume.gardet@free.fr> wrote:
>> Hi,
>>
>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
>> It fixes the following build error:
>>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
>>
>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
> A similar patch has already been submitted by Arnd. Please see below:
> https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

>
> In general, sending an attachment is not the right way to submit a patch.
> Please refer Documentation/SubmittingPatches in the kernel source for the
> correct procedure.

Sorry, I forgot to send it inline.


Guillaume

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Kishon Vijay Abraham I]

On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
> 
> Le 12/06/2014 10:36, Sachin Kamat a écrit :
>> Hi Guillaume,
>>
>>
>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
>> <guillaume.gardet@free.fr> wrote:
>>> Hi,
>>>
>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
>>> It fixes the following build error:
>>>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
>>>
>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
>> A similar patch has already been submitted by Arnd. Please see below:
>> https://lkml.org/lkml/2014/3/15/40
> 
> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

It's in mainline kernel already
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

-Kishon
> 
>>
>> In general, sending an attachment is not the right way to submit a patch.
>> Please refer Documentation/SubmittingPatches in the kernel source for the
>> correct procedure.
> 
> Sorry, I forgot to send it inline.
> 
> 
> Guillaume
> 

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Guillaume Gardet]

Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :
>
> On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
>> Le 12/06/2014 10:36, Sachin Kamat a écrit :
>>> Hi Guillaume,
>>>
>>>
>>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
>>> <guillaume.gardet@free.fr> wrote:
>>>> Hi,
>>>>
>>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
>>>> It fixes the following build error:
>>>>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
>>>>
>>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
>>>>
>>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
>>> A similar patch has already been submitted by Arnd. Please see below:
>>> https://lkml.org/lkml/2014/3/15/40
>> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.
> It's in mainline kernel already
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf

Ok. It is in mainline but not in 3.15.


Guillaume

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Kishon Vijay Abraham I]

On Thursday 12 June 2014 03:14 PM, Guillaume Gardet wrote:
> 
> Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :
>>
>> On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
>>> Le 12/06/2014 10:36, Sachin Kamat a écrit :
>>>> Hi Guillaume,
>>>>
>>>>
>>>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
>>>> <guillaume.gardet@free.fr> wrote:
>>>>> Hi,
>>>>>
>>>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
>>>>> It fixes the following build error:
>>>>>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
>>>>>
>>>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
>>>>>
>>>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
>>>> A similar patch has already been submitted by Arnd. Please see below:
>>>> https://lkml.org/lkml/2014/3/15/40
>>> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.
>> It's in mainline kernel already
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf
> 
> Ok. It is in mainline but not in 3.15.

hmm, yes. It went in this merge window.

-Kishon

> 
> 
> Guillaume
> 

Re: [PATCH] phy: Fix typo in drivers/phy/phy-exynos5250-sata.c module which fixes the build

[Jean Delvare]

Le Thursday 12 June 2014 à 11:44 +0200, Guillaume Gardet a écrit :
> Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :
> >
> > On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:
> >> Le 12/06/2014 10:36, Sachin Kamat a écrit :
> >>> Hi Guillaume,
> >>>
> >>>
> >>> On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet
> >>> <guillaume.gardet@free.fr> wrote:
> >>>> Hi,
> >>>>
> >>>> please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license.
> >>>> It fixes the following build error:
> >>>>     FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'
> >>>>
> >>>> Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.
> >>>>
> >>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
> >>> A similar patch has already been submitted by Arnd. Please see below:
> >>> https://lkml.org/lkml/2014/3/15/40
> >> Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.
> > It's in mainline kernel already
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/phy/phy-exynos5250-sata.c?id=fe04e4297e6eab014a2cf152319b9f361df07faf
> 
> Ok. It is in mainline but not in 3.15.

And as it stands, it won't be, because stable@vger.kernel.org was not
Cc'd. "Typo" in the subject makes it sound like a trivial and minor
change. "Fix module loading" would probably have made it clearer that it
fixes a real issue.

Guillaume, if this bothers you, please write to stable@vger.kernel.org
and kindly ask them to consider including this commit in future stable
releases.

-- 
Jean Delvare
SUSE L3 Support