Re: [PATCH v5 RFC 14/14] tools/libxc: noarch restore code

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 12/06/14 17:05, David Vrabel wrote:
> On 11/06/14 19:14, Andrew Cooper wrote:
>> --- a/tools/libxc/saverestore/common.h
>> +++ b/tools/libxc/saverestore/common.h
>> @@ -292,6 +292,12 @@ static inline int write_record(struct context *ctx, struct record *rec)
>>      return write_split_record(ctx, rec, NULL, 0);
>>  }
>>  
>> +/* TODO - find a better way of hiding this.  It should be private to
>> + * restore.c, but is needed by x86_pv_localise_page()
>> + */
>> +int populate_pfns(struct context *ctx, unsigned count,
>> +                  const xen_pfn_t *original_pfns, const uint32_t *types);
> I don't see a problem with this being here, if it's needed in those two
> places.
>
> David
>

I was hoping to find a way of making it disappear as it is the one ugly
lump in the otherwise clean partitioning of common and arch specific code.

I am however struggling...

~Andrew