From: Adam Baker <linux@baker-net.org.uk> To: Nick <xerofoify@gmail.com>, emilio@elopez.com.ar Cc: maxime.ripard@free-electrons.com, mturquette@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Frees gate after if statement in clk-sunxi.c Date: Sat, 14 Jun 2014 23:06:23 +0100 [thread overview] Message-ID: <539CC75F.2080105@baker-net.org.uk> (raw) In-Reply-To: <1402769508-3821-1-git-send-email-xerofoify@gmail.com> On 14/06/14 19:11, Nick wrote: > Signed-off-by: Nick <xerofoify@gmail.com> > --- > drivers/clk/sunxi/clk-sunxi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 4264834..6f4fc51 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node) > u32 rate; > > if (of_property_read_u32(node, "clock-frequency", &rate)) > + kree(gate); > return; There are no braces around this so the function of this code as written is an unconditional return and the return shouldn't be indented. I suspect, without reading the rest of the file, that that isn't what you intended. > > /* allocate fixed-rate and gate clock structs */ > Adam
WARNING: multiple messages have this Message-ID (diff)
From: linux@baker-net.org.uk (Adam Baker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] Frees gate after if statement in clk-sunxi.c Date: Sat, 14 Jun 2014 23:06:23 +0100 [thread overview] Message-ID: <539CC75F.2080105@baker-net.org.uk> (raw) In-Reply-To: <1402769508-3821-1-git-send-email-xerofoify@gmail.com> On 14/06/14 19:11, Nick wrote: > Signed-off-by: Nick <xerofoify@gmail.com> > --- > drivers/clk/sunxi/clk-sunxi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 4264834..6f4fc51 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node) > u32 rate; > > if (of_property_read_u32(node, "clock-frequency", &rate)) > + kree(gate); > return; There are no braces around this so the function of this code as written is an unconditional return and the return shouldn't be indented. I suspect, without reading the rest of the file, that that isn't what you intended. > > /* allocate fixed-rate and gate clock structs */ > Adam
next prev parent reply other threads:[~2014-06-14 22:12 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-14 18:11 [PATCH] Frees gate after if statement in clk-sunxi.c Nick 2014-06-14 18:11 ` Nick 2014-06-14 19:35 ` Sergei Shtylyov 2014-06-14 19:35 ` Sergei Shtylyov 2014-06-14 22:06 ` Adam Baker [this message] 2014-06-14 22:06 ` Adam Baker 2014-06-15 20:30 ` Maxime Ripard 2014-06-15 20:30 ` Maxime Ripard 2014-06-16 3:21 ` Nick Krause 2014-06-16 3:21 ` Nick Krause 2014-06-16 3:31 ` Nick Krause 2014-06-16 3:31 ` Nick Krause 2014-06-16 8:15 ` Russell King - ARM Linux 2014-06-16 8:15 ` Russell King - ARM Linux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=539CC75F.2080105@baker-net.org.uk \ --to=linux@baker-net.org.uk \ --cc=emilio@elopez.com.ar \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=mturquette@linaro.org \ --cc=xerofoify@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.