All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	rdunlap@infradead.org, linux@arm.linux.org.uk,
	grant.likely@linaro.org, thierry.reding@gmail.com,
	florian.vaussard@epfl.ch, jic23@kernel.org, jason@lakedaemon.net,
	andrew@lunn.ch, silvio.fricke@gmail.com, heiko.stuebner@bq.com,
	olof@lixom.net, sebastian.hesselbarth@gmail.com,
	sboyd@codeaurora.org, gregory.clement@free-electrons.com,
	arnd@arndb.de, robherring2@gmail.com, marc.zyngier@arm.com,
	maxime.ripard@free-electrons.com, soren.brinkmann@xilinx.com,
	shawn.guo@freescale.com, anders.berg@lsi.com,
	linus.walleij@linaro.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/7] clocksource: Add support for the Mediatek SoCs
Date: Sun, 15 Jun 2014 23:34:37 +0200	[thread overview]
Message-ID: <539E116D.6030002@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1406112012460.5170@nanos>

On 06/11/2014 08:14 PM, Thomas Gleixner wrote:
> On Wed, 11 Jun 2014, Matthias Brugger wrote:
>> +static void mtk_clkevt_mode(enum clock_event_mode mode,
>> +				struct clock_event_device *clk)
>> +{
>> +	struct mtk_clock_event_device *evt = to_mtk_clk(clk);
>> +
>> +	mtk_clkevt_time_stop(evt, GPT_CLK_EVT);
>> +
>> +	switch (mode) {
>> +	case CLOCK_EVT_MODE_PERIODIC:
>> +		mtk_clkevt_time_setup(evt, evt->ticks_per_jiffy, GPT_CLK_EVT);
>> +		mtk_clkevt_time_start(evt, true, GPT_CLK_EVT);
>> +		break;
>> +	case CLOCK_EVT_MODE_ONESHOT:
>> +		mtk_clkevt_time_start(evt, false, GPT_CLK_EVT);
>
> Why start the timer here? The code will call set next event right away.
>
>> +		break;
>> +	case CLOCK_EVT_MODE_UNUSED:
>> +	case CLOCK_EVT_MODE_SHUTDOWN:
>> +	default:
>> +		/* No more interrupts will occur as source is disabled */
>> +		break;
>> +	}
>> +}
>
> Looks good otherwise.

Hi Thomas,

Can I consider the 8.1 patch (the one taking into account your comment) 
as acked-by ?

Thanks

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 2/7] clocksource: Add support for the Mediatek SoCs
Date: Sun, 15 Jun 2014 23:34:37 +0200	[thread overview]
Message-ID: <539E116D.6030002@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1406112012460.5170@nanos>

On 06/11/2014 08:14 PM, Thomas Gleixner wrote:
> On Wed, 11 Jun 2014, Matthias Brugger wrote:
>> +static void mtk_clkevt_mode(enum clock_event_mode mode,
>> +				struct clock_event_device *clk)
>> +{
>> +	struct mtk_clock_event_device *evt = to_mtk_clk(clk);
>> +
>> +	mtk_clkevt_time_stop(evt, GPT_CLK_EVT);
>> +
>> +	switch (mode) {
>> +	case CLOCK_EVT_MODE_PERIODIC:
>> +		mtk_clkevt_time_setup(evt, evt->ticks_per_jiffy, GPT_CLK_EVT);
>> +		mtk_clkevt_time_start(evt, true, GPT_CLK_EVT);
>> +		break;
>> +	case CLOCK_EVT_MODE_ONESHOT:
>> +		mtk_clkevt_time_start(evt, false, GPT_CLK_EVT);
>
> Why start the timer here? The code will call set next event right away.
>
>> +		break;
>> +	case CLOCK_EVT_MODE_UNUSED:
>> +	case CLOCK_EVT_MODE_SHUTDOWN:
>> +	default:
>> +		/* No more interrupts will occur as source is disabled */
>> +		break;
>> +	}
>> +}
>
> Looks good otherwise.

Hi Thomas,

Can I consider the 8.1 patch (the one taking into account your comment) 
as acked-by ?

Thanks

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2014-06-15 21:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 12:34 [PATCH v8 0/7] arm: Add basic support for Mediatek Cortex-A7 SoCs Matthias Brugger
2014-06-11 12:34 ` Matthias Brugger
2014-06-11 12:34 ` [PATCH v8 1/7] of: Provide function to request and map memory Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34 ` [PATCH v8 2/7] clocksource: Add support for the Mediatek SoCs Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 18:14   ` Thomas Gleixner
2014-06-11 18:14     ` Thomas Gleixner
2014-06-12 18:43     ` [PATCH v8.1] " Matthias Brugger
2014-06-12 18:43       ` Matthias Brugger
2014-06-15 21:34     ` Daniel Lezcano [this message]
2014-06-15 21:34       ` [PATCH v8 2/7] " Daniel Lezcano
2014-06-16  7:43       ` Thomas Gleixner
2014-06-16  7:43         ` Thomas Gleixner
2014-06-11 12:34 ` [PATCH v8 3/7] dt-bindings: add mtk-timer bindings Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34 ` [PATCH v8 4/7] vendor-prefixes: add prefix for Mediaktek Inc Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:38   ` Geert Uytterhoeven
2014-06-11 12:38     ` Geert Uytterhoeven
2014-06-11 12:34 ` [PATCH v8 5/7] arm: add basic support for Mediatek MT6589 boards Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34 ` [PATCH v8 6/7] dt-bindings: add documentation for Mediatek SoC Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger
2014-06-11 12:34 ` [PATCH v8 7/7] arm: mediatek: add dts for Aquaris5 mobile phone Matthias Brugger
2014-06-11 12:34   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539E116D.6030002@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=anders.berg@lsi.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.vaussard@epfl.ch \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=heiko.stuebner@bq.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=jic23@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=olof@lixom.net \
    --cc=pawel.moll@arm.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=sboyd@codeaurora.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=shawn.guo@freescale.com \
    --cc=silvio.fricke@gmail.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.