All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_fat: use get_device_and_partition() during env save and load
Date: Mon, 16 Jun 2014 13:51:16 -0600	[thread overview]
Message-ID: <539F4AB4.3000108@wwwdotorg.org> (raw)
In-Reply-To: <1402906493-26723-1-git-send-email-josh.wu@atmel.com>

On 06/16/2014 02:14 AM, Josh Wu wrote:
> Use get_device_and_partition() is better since:
> 1. It will call the device initialize function internally. So we can
> remove the mmc intialization code to save many lines.
> 2. It is used by fatls/fatload/fatwrite. So saveenv & load env should
> use it too.
> 3. It can parse the "D:P", "D", "D:", "D:auto" string to get correct
> device and partition information by run-time.
> 
> Also we remove the FAT_ENV_DEVICE and FAT_ENV_PART. We use a string:
> FAT_ENV_DEVICE_AND_PART.
> For at91sam9m10g45ek, it is "0". That means use device 0 and if:
> a)device 0 has no partition table, use the whole device as a FAT file
> system.
> b)device 0 has partittion table, use the partition #1.
> 
> Refer to the commit: 10a37fd7a4 for details of device & partition string.

(briefly)
Reviewed-by: Stephen Warren <swarren@nvidia.com>

Questions though:

* Can we delete the implementation of fat_register_device() now it's not
used? If it is used, shouldn't the other uses be converted in a similar
fashion?

* Should the new config variable FAT_ENV_DEVICE_AND_PART be documented
in README?

  reply	other threads:[~2014-06-16 19:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16  8:14 [U-Boot] [PATCH] env_fat: use get_device_and_partition() during env save and load Josh Wu
2014-06-16 19:51 ` Stephen Warren [this message]
2014-06-19  2:35   ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539F4AB4.3000108@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.