All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jongsung Kim <neidhard.kim@lge.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Hayun Hwang <hwang.hayun@lge.com>,
	Youngkyu Choi <youngkyu7.choi@lge.com>
Subject: Re: [PATCH] net/cadence/macb: clear interrupts simply and correctly
Date: Tue, 17 Jun 2014 12:39:32 +0900	[thread overview]
Message-ID: <539FB874.1040003@lge.com> (raw)
In-Reply-To: <7e888b59-d27b-49dc-9ffc-1c7d56f11773@BN1AFFO11FD007.protection.gbl>

On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
> Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with 'MACB_RX_INT_FLAGS'
> to clear all the RX IRQ flags.

I'm afraid not.

You know, this driver initially targeted only GEMs configured with "gem_irq_clear_read."
For this implementation of GEM, the ISR is automatically cleared by reading. The driver
was designed to operate with the value read from ISR, not with the ISR itself.

However, there are other GEMs configured without "gem_irq_clear_read," people like you
and I working with. To support them, they insert similar codes conditionally clearing
the ISR here and there. Now they are found at 6 places. Not enough yet. Do you want to
insert another at the end of macb_reset_hw..? Maybe not.

Jongsung

  reply	other threads:[~2014-06-17  3:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  8:50 [PATCH] net/cadence/macb: clear interrupts simply and correctly Jongsung Kim
2014-06-12 15:44 ` Sören Brinkmann
2014-06-16  5:00   ` Jongsung Kim
2014-06-16 14:56     ` Sören Brinkmann
2014-06-17  2:38       ` Jongsung Kim
2014-06-17  3:50         ` Sören Brinkmann
2014-06-17  4:42           ` Jongsung Kim
2014-06-16 21:28 ` Sören Brinkmann
2014-06-17  3:39   ` Jongsung Kim [this message]
2014-06-17  7:54     ` Nicolas Ferre
2014-06-18  8:44       ` Jongsung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539FB874.1040003@lge.com \
    --to=neidhard.kim@lge.com \
    --cc=davem@davemloft.net \
    --cc=hwang.hayun@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=youngkyu7.choi@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.