From: Daniel Borkmann <dborkman@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jet Chen <jet.chen@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
lkp@01.org, Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [net] b58537a1f56: +89.2% netperf.Throughput_Mbps
Date: Wed, 18 Jun 2014 22:38:49 +0200 [thread overview]
Message-ID: <53A1F8D9.7070704@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406181328160.10339@chino.kir.corp.google.com>
On 06/18/2014 10:29 PM, David Rientjes wrote:
> On Wed, 18 Jun 2014, Jet Chen wrote:
>
>> Hi Daniel,
>>
>> FYI, we noticed the below changes on
>>
>> commit b58537a1f5629bdc98a8b9dc2051ce0e952f6b4b ("net: sctp: fix permissions
>> for rto_alpha and rto_beta knobs")
>
> There's no way this is legitimate, that commit cannot possibly affect the
> performance of netperf. I wouldn't bother to spend any time investigating
> this.
One assumption could be that netperf was setting this knob
internally and ignoring the result of it (error/success), but
that we might need to look up in netperf source to confirm.
Cheers,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: lkp@lists.01.org
Subject: Re: [net] b58537a1f56: +89.2% netperf.Throughput_Mbps
Date: Wed, 18 Jun 2014 22:38:49 +0200 [thread overview]
Message-ID: <53A1F8D9.7070704@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406181328160.10339@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On 06/18/2014 10:29 PM, David Rientjes wrote:
> On Wed, 18 Jun 2014, Jet Chen wrote:
>
>> Hi Daniel,
>>
>> FYI, we noticed the below changes on
>>
>> commit b58537a1f5629bdc98a8b9dc2051ce0e952f6b4b ("net: sctp: fix permissions
>> for rto_alpha and rto_beta knobs")
>
> There's no way this is legitimate, that commit cannot possibly affect the
> performance of netperf. I wouldn't bother to spend any time investigating
> this.
One assumption could be that netperf was setting this knob
internally and ignoring the result of it (error/success), but
that we might need to look up in netperf source to confirm.
Cheers,
Daniel
next prev parent reply other threads:[~2014-06-18 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 3:08 [net] b58537a1f56: +89.2% netperf.Throughput_Mbps Jet Chen
2014-06-18 3:08 ` Jet Chen
2014-06-18 20:29 ` David Rientjes
2014-06-18 20:29 ` David Rientjes
2014-06-18 20:38 ` Daniel Borkmann [this message]
2014-06-18 20:38 ` Daniel Borkmann
2014-06-18 20:41 ` David Rientjes
2014-06-18 20:41 ` David Rientjes
2014-06-19 8:15 ` Daniel Borkmann
2014-06-19 8:15 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1F8D9.7070704@redhat.com \
--to=dborkman@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.