From: zhangfei <zhangfei.gao@linaro.org> To: "Lothar Waßmann" <LW@KARO-electronics.de> Cc: tj@kernel.org, hdegoede@redhat.com, arnd@arndb.de, mark.rutland@arm.com, linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFC 1/2] libahci_platform: add ahci_platform_get_of_property Date: Thu, 19 Jun 2014 10:23:35 +0800 [thread overview] Message-ID: <53A249A7.2030807@linaro.org> (raw) In-Reply-To: <20140618093725.0f381633@ipc1.ka-ro> On 06/18/2014 03:37 PM, Lothar Waßmann wrote: > Hi, > > Zhangfei Gao wrote: >> Instead of setting hflags in different files, >> ahci_platform_get_of_property set hpriv->flags when ahci_platform_init_host >> according to property in dts. >> >> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> >> --- >> .../devicetree/bindings/ata/ahci-platform.txt | 9 +++++ >> drivers/ata/libahci_platform.c | 39 ++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> index c96d8dcf98fd..c0b9f6e76ba4 100644 >> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt >> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> @@ -26,6 +26,15 @@ Optional properties: >> - clocks : must contain the sata, sata_ref and ahb clocks >> - clock-names : must contain "ahb" for the ahb clock >> >> +- no-ncq: when present, controller can't do NCQ, turning off CAP_NCQ >> +- 32bit-only: when present, controller can't do 64bit DMA, forcing 32bit >> +- no-msi: when present, no PCI MSI >> +- no-pmp: when present, controller can't do PMP, turning off CAP_PMP >> +- yes-ncq: when present,controller can do NCQ, turning on CAP_NCQ >> +- no-suspend: when present, controller can't do suspend >> +- yes-fbs: when present, controller can do FBS, turning on CAP_FBS >> +- no-fbs: when present, controller can't do FBS, turning off CAP_FBS >> + > 'yes-...' sounds a bit silly to me. > What about 'force-...'? Yes, good idea, thanks for the suggestion. > That's also what the comment to the flag definitions in > drivers/ata/ahci.h says: > |AHCI_HFLAG_YES_NCQ = (1 << 9), /* force NCQ cap on */ > |AHCI_HFLAG_YES_FBS = (1 << 14), /* force FBS cap on */ > > > Lothar Waßmann >
WARNING: multiple messages have this Message-ID (diff)
From: zhangfei.gao@linaro.org (zhangfei) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC 1/2] libahci_platform: add ahci_platform_get_of_property Date: Thu, 19 Jun 2014 10:23:35 +0800 [thread overview] Message-ID: <53A249A7.2030807@linaro.org> (raw) In-Reply-To: <20140618093725.0f381633@ipc1.ka-ro> On 06/18/2014 03:37 PM, Lothar Wa?mann wrote: > Hi, > > Zhangfei Gao wrote: >> Instead of setting hflags in different files, >> ahci_platform_get_of_property set hpriv->flags when ahci_platform_init_host >> according to property in dts. >> >> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> >> --- >> .../devicetree/bindings/ata/ahci-platform.txt | 9 +++++ >> drivers/ata/libahci_platform.c | 39 ++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> index c96d8dcf98fd..c0b9f6e76ba4 100644 >> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt >> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt >> @@ -26,6 +26,15 @@ Optional properties: >> - clocks : must contain the sata, sata_ref and ahb clocks >> - clock-names : must contain "ahb" for the ahb clock >> >> +- no-ncq: when present, controller can't do NCQ, turning off CAP_NCQ >> +- 32bit-only: when present, controller can't do 64bit DMA, forcing 32bit >> +- no-msi: when present, no PCI MSI >> +- no-pmp: when present, controller can't do PMP, turning off CAP_PMP >> +- yes-ncq: when present,controller can do NCQ, turning on CAP_NCQ >> +- no-suspend: when present, controller can't do suspend >> +- yes-fbs: when present, controller can do FBS, turning on CAP_FBS >> +- no-fbs: when present, controller can't do FBS, turning off CAP_FBS >> + > 'yes-...' sounds a bit silly to me. > What about 'force-...'? Yes, good idea, thanks for the suggestion. > That's also what the comment to the flag definitions in > drivers/ata/ahci.h says: > |AHCI_HFLAG_YES_NCQ = (1 << 9), /* force NCQ cap on */ > |AHCI_HFLAG_YES_FBS = (1 << 14), /* force FBS cap on */ > > > Lothar Wa?mann >
next prev parent reply other threads:[~2014-06-19 2:23 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <xuwei5@hisilicon.com, kefeng.wang@linaro.org,> 2014-06-18 4:54 ` [PATCH 0/2] add ahci_platform_get_of_property Zhangfei Gao 2014-06-18 4:54 ` Zhangfei Gao 2014-06-18 4:54 ` [PATCH RFC 1/2] libahci_platform: " Zhangfei Gao 2014-06-18 4:54 ` Zhangfei Gao 2014-06-18 7:37 ` Lothar Waßmann 2014-06-18 7:37 ` Lothar Waßmann 2014-06-19 2:23 ` zhangfei [this message] 2014-06-19 2:23 ` zhangfei 2014-06-18 14:03 ` Mark Rutland 2014-06-18 14:03 ` Mark Rutland 2014-06-19 2:22 ` zhangfei 2014-06-19 2:22 ` zhangfei 2014-06-19 7:39 ` Hans de Goede 2014-06-19 7:39 ` Hans de Goede 2014-06-20 5:56 ` zhangfei 2014-06-20 5:56 ` zhangfei 2014-06-20 7:38 ` Hans de Goede 2014-06-20 7:38 ` Hans de Goede 2014-06-18 4:54 ` [PATCH RFC 2/2] ahci: remove AHCI_HFLAG_NO_FBS setting Zhangfei Gao 2014-06-18 4:54 ` Zhangfei Gao 2014-06-18 7:15 ` Zhangfei Gao 2014-06-18 7:15 ` Zhangfei Gao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53A249A7.2030807@linaro.org \ --to=zhangfei.gao@linaro.org \ --cc=LW@KARO-electronics.de \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=hdegoede@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.