All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Billauer <eli.billauer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: sdhci: Fixed timeout for sdhci_send_command()
Date: Thu, 19 Jun 2014 19:50:47 +0300	[thread overview]
Message-ID: <53A314E7.3020507@gmail.com> (raw)
In-Reply-To: <CAKWjMd7iefW-z5h_TU7tNJe-5r4-tOWYTGe9p0BcaAHfTHEFig@mail.gmail.com>

On 19/06/14 19:43, Andy Fleming wrote:
> On Thu, Jun 12, 2014 at 4:41 AM, Eli Billauer<eli.billauer@gmail.com>  wrote:
>    
>> The current wait loop just reads the status 10000 times, which makes the
>> actual timeout period platform-dependent. The udelay() call within the loop
>> makes the new timeout ~100 ms.
>>
>> [ snipped patch ]
>>      
>
> Hmmm...
>
> Is 100ms part of the spec? I like the idea of making the timeout more
> time-based, but it seems to me that this changes the timeout quite
> significantly. If it took N ms before, it now takes N + 100 ms.
>
> I think, if we want the timeout to be ~100ms, we should use a udelay
> of 100 or 1000, and then reduce "retry" accordingly.
>    
Hi,

As I said in the mail preceding this patch, I don't know what the 
timeout should be. Maybe someone with a better knowledge on MMC could 
come forward.

Regards,
    Eli
> Andy
>
>    

  reply	other threads:[~2014-06-19 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  9:41 [U-Boot] [PATCH] Timeout for SDHCI commands Eli Billauer
2014-06-12  9:41 ` [U-Boot] [PATCH] mmc: sdhci: Fixed timeout for sdhci_send_command() Eli Billauer
2014-06-19 16:43   ` Andy Fleming
2014-06-19 16:50     ` Eli Billauer [this message]
2014-06-27  9:37   ` Pantelis Antoniou
2014-07-01 18:11     ` Andy Fleming
2014-07-04 21:02     ` Steve Rae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A314E7.3020507@gmail.com \
    --to=eli.billauer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.