From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH] ARM: tegra: TN7: relax some regulators Date: Fri, 20 Jun 2014 19:33:25 +0900 [thread overview] Message-ID: <53A40DF5.1060904@nvidia.com> (raw) In-Reply-To: <20140620101618.GU5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> On 06/20/2014 07:16 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Fri, Jun 20, 2014 at 02:26:43PM +0900, Alexandre Courbot wrote: > >> So I can see three questions here: > >> 1) Why does _regulator_enable() on vdd_1v8 return 0 while everything >> suggests that it is enabled (this regulator powers lot of devices, like >> eMMC, which are working fine). This may be an issue with the palmas driver. > > Returning 0 is reporting success and you say it is enabled so I'm not > seeing any contradiction here... or do you mean regulator_is_enabled() > here? An always on regulator should report that it is enabled. I meant to write regulator_is_enabled() here, yes. Apologies for the confusion. > >> 2) When an always-on regulator that is not yet enabled is registered, >> shouldn't it be switched on by the regulator framework? > > This happens during set_machine_constraints(). > >> 3) When a boot-on regulator is registered and _regulator_is_enabled() >> returns contradictory information, what should be done? > > Same thing here (same check even). Indeed, everything is coherent here - I was confused by the fact the regulator was always reported as disabled, which led me to wrongly assume that the framework did not try to enable it. But of course we cannot ask the framework to account for drivers that return incorrect regulator state, as seems to be the case with Palmas here. So it all seems to come down to a bug in the Palmas driver introduced by dbabd624d. Reverting that change brings me back to normal. Thanks, Alex.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com> To: Mark Brown <broonie@kernel.org> Cc: Stephen Warren <swarren@wwwdotorg.org>, Thierry Reding <thierry.reding@gmail.com>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ARM: tegra: TN7: relax some regulators Date: Fri, 20 Jun 2014 19:33:25 +0900 [thread overview] Message-ID: <53A40DF5.1060904@nvidia.com> (raw) In-Reply-To: <20140620101618.GU5099@sirena.org.uk> On 06/20/2014 07:16 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Fri, Jun 20, 2014 at 02:26:43PM +0900, Alexandre Courbot wrote: > >> So I can see three questions here: > >> 1) Why does _regulator_enable() on vdd_1v8 return 0 while everything >> suggests that it is enabled (this regulator powers lot of devices, like >> eMMC, which are working fine). This may be an issue with the palmas driver. > > Returning 0 is reporting success and you say it is enabled so I'm not > seeing any contradiction here... or do you mean regulator_is_enabled() > here? An always on regulator should report that it is enabled. I meant to write regulator_is_enabled() here, yes. Apologies for the confusion. > >> 2) When an always-on regulator that is not yet enabled is registered, >> shouldn't it be switched on by the regulator framework? > > This happens during set_machine_constraints(). > >> 3) When a boot-on regulator is registered and _regulator_is_enabled() >> returns contradictory information, what should be done? > > Same thing here (same check even). Indeed, everything is coherent here - I was confused by the fact the regulator was always reported as disabled, which led me to wrongly assume that the framework did not try to enable it. But of course we cannot ask the framework to account for drivers that return incorrect regulator state, as seems to be the case with Palmas here. So it all seems to come down to a bug in the Palmas driver introduced by dbabd624d. Reverting that change brings me back to normal. Thanks, Alex.
next prev parent reply other threads:[~2014-06-20 10:33 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-19 7:49 [PATCH] ARM: tegra: TN7: relax some regulators Alexandre Courbot 2014-06-19 7:49 ` Alexandre Courbot 2014-06-19 15:59 ` Stephen Warren 2014-06-19 17:56 ` Mark Brown [not found] ` <20140619175643.GR5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2014-06-20 5:26 ` Alexandre Courbot 2014-06-20 5:26 ` Alexandre Courbot [not found] ` <53A3C613.8030207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-06-20 6:44 ` Alexandre Courbot 2014-06-20 6:44 ` Alexandre Courbot [not found] ` <53A3D85E.7030704-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2014-06-20 9:41 ` Mark Brown 2014-06-20 9:41 ` Mark Brown [not found] ` <20140620094119.GT5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2014-06-20 9:49 ` Alexandre Courbot 2014-06-20 9:49 ` Alexandre Courbot 2014-06-20 13:23 ` Palmas regulator broken (was Re: [PATCH] ARM: tegra: TN7: relax some regulators) Nishanth Menon 2014-06-20 13:23 ` Nishanth Menon 2014-06-20 13:54 ` Nishanth Menon 2014-06-20 13:54 ` Nishanth Menon 2014-06-20 14:14 ` Alexandre Courbot [not found] ` <CAAVeFuJ=JTNkwDKBvuoyL=ARQs_UJb_MHzL9S8gOc8EU98znPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-06-20 17:27 ` Nishanth Menon 2014-06-20 17:27 ` Nishanth Menon 2014-06-20 10:16 ` [PATCH] ARM: tegra: TN7: relax some regulators Mark Brown [not found] ` <20140620101618.GU5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2014-06-20 10:33 ` Alexandre Courbot [this message] 2014-06-20 10:33 ` Alexandre Courbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53A40DF5.1060904@nvidia.com \ --to=acourbot-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.