[Qemu-devel] [PATCH v4] configure: Enable TPM by default, add --disable-tpm

[Qemu-devel] [PATCH v4] configure: Enable TPM by default, add --disable-tpm

[Cole Robinson]

I don't see why tpm is disabled by default: it doesn't have any
external dependencies, or change default behavior. Leaving it disabled
is just going to cause it to bit rot.

Enable it by default, and add a --disable-tpm option.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
v4:
    Rebase to master

Previous posting in April didn't generate any complains, so seeing if
qemu-trivial can pick it up.

 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 27d84d9..fd4d1e9 100755
--- a/configure
+++ b/configure
@@ -330,7 +330,7 @@ virtio_blk_data_plane=""
 gtk=""
 gtkabi=""
 vte=""
-tpm="no"
+tpm="yes"
 libssh2=""
 vhdx=""
 quorum=""
@@ -1104,6 +1104,8 @@ for opt do
   ;;
   --enable-vte) vte="yes"
   ;;
+  --disable-tpm) tpm="no"
+  ;;
   --enable-tpm) tpm="yes"
   ;;
   --disable-libssh2) libssh2="no"
@@ -1377,6 +1379,7 @@ Advanced options (experts only):
   --disable-glusterfs      disable GlusterFS backend
   --enable-gcov            enable test coverage analysis with gcov
   --gcov=GCOV              use specified gcov [$gcov_tool]
+  --disable-tpm            disable TPM support
   --enable-tpm             enable TPM support
   --disable-libssh2        disable ssh block device support
   --enable-libssh2         enable ssh block device support
-- 
1.9.3

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] configure: Enable TPM by default, add --disable-tpm

[Michael Tokarev]

16.06.2014 23:32, Cole Robinson wrote:
> I don't see why tpm is disabled by default: it doesn't have any
> external dependencies, or change default behavior. Leaving it disabled
> is just going to cause it to bit rot.
> 
> Enable it by default, and add a --disable-tpm option.

Applied to -trivial, thank you!

/mjt