All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-06-30 18:45 ` Guenter Roeck
  0 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-06-30 18:45 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Paul Mackerras, linuxppc-dev, linux-kernel, Guenter Roeck

powerpc:allmodconfig has been failing for some time with the following
error.

arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1

A number of attempts to fix the problem by moving around code have been
unsuccessful and resulted in failed builds for some configurations and
the discovery of toolchain bugs.

Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
While this is less than perfect, it avoids substantial code changes
which would otherwise be necessary just to make COMPILE_TEST builds
happy and might have undesired side effects.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/powerpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index bd6dd6e..fefe7c8 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -414,7 +414,7 @@ config KEXEC
 config CRASH_DUMP
 	bool "Build a kdump crash kernel"
 	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
-	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
+	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
 	help
 	  Build a kernel suitable for use as a kdump capture kernel.
 	  The same kernel binary can be used as production kernel and dump
@@ -1017,6 +1017,7 @@ endmenu
 if PPC64
 config RELOCATABLE
 	bool "Build a relocatable kernel"
+	depends on !COMPILE_TEST
 	select NONSTATIC_KERNEL
 	help
 	  This builds a kernel image that is capable of running anywhere
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-06-30 18:45 ` Guenter Roeck
  0 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-06-30 18:45 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: linuxppc-dev, Paul Mackerras, linux-kernel, Guenter Roeck

powerpc:allmodconfig has been failing for some time with the following
error.

arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1

A number of attempts to fix the problem by moving around code have been
unsuccessful and resulted in failed builds for some configurations and
the discovery of toolchain bugs.

Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
While this is less than perfect, it avoids substantial code changes
which would otherwise be necessary just to make COMPILE_TEST builds
happy and might have undesired side effects.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/powerpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index bd6dd6e..fefe7c8 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -414,7 +414,7 @@ config KEXEC
 config CRASH_DUMP
 	bool "Build a kdump crash kernel"
 	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
-	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
+	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
 	help
 	  Build a kernel suitable for use as a kdump capture kernel.
 	  The same kernel binary can be used as production kernel and dump
@@ -1017,6 +1017,7 @@ endmenu
 if PPC64
 config RELOCATABLE
 	bool "Build a relocatable kernel"
+	depends on !COMPILE_TEST
 	select NONSTATIC_KERNEL
 	help
 	  This builds a kernel image that is capable of running anywhere
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-06-30 18:45 ` Guenter Roeck
@ 2014-07-01  0:55   ` Stephen Rothwell
  -1 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2014-07-01  0:55 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Benjamin Herrenschmidt, linuxppc-dev, Paul Mackerras, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Hi Guenter,

On Mon, 30 Jun 2014 11:45:30 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> powerpc:allmodconfig has been failing for some time with the following
> error.
> 
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
> 
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
> 
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I'll dump this in my "fixes" tree today and see how it goes.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-01  0:55   ` Stephen Rothwell
  0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2014-07-01  0:55 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linuxppc-dev, linux-kernel, Paul Mackerras

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Hi Guenter,

On Mon, 30 Jun 2014 11:45:30 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> powerpc:allmodconfig has been failing for some time with the following
> error.
> 
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
> 
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
> 
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I'll dump this in my "fixes" tree today and see how it goes.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-07-01  0:55   ` Stephen Rothwell
@ 2014-07-01  2:22     ` Guenter Roeck
  -1 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-01  2:22 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Benjamin Herrenschmidt, linuxppc-dev, Paul Mackerras, linux-kernel

On 06/30/2014 05:55 PM, Stephen Rothwell wrote:
> Hi Guenter,
>
> On Mon, 30 Jun 2014 11:45:30 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> powerpc:allmodconfig has been failing for some time with the following
>> error.
>>
>> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
>> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
>> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>>
>> A number of attempts to fix the problem by moving around code have been
>> unsuccessful and resulted in failed builds for some configurations and
>> the discovery of toolchain bugs.
>>
>> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.

s/Fix/Work around/

would probably be a better here.

>> While this is less than perfect, it avoids substantial code changes
>> which would otherwise be necessary just to make COMPILE_TEST builds
>> happy and might have undesired side effects.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> I'll dump this in my "fixes" tree today and see how it goes.
>

Would be great. Note that allyescconfig still fails with relocation errors
after this patch has been applied.

Thanks,
Guenter


^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-01  2:22     ` Guenter Roeck
  0 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-01  2:22 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linuxppc-dev, linux-kernel, Paul Mackerras

On 06/30/2014 05:55 PM, Stephen Rothwell wrote:
> Hi Guenter,
>
> On Mon, 30 Jun 2014 11:45:30 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> powerpc:allmodconfig has been failing for some time with the following
>> error.
>>
>> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
>> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
>> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>>
>> A number of attempts to fix the problem by moving around code have been
>> unsuccessful and resulted in failed builds for some configurations and
>> the discovery of toolchain bugs.
>>
>> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.

s/Fix/Work around/

would probably be a better here.

>> While this is less than perfect, it avoids substantial code changes
>> which would otherwise be necessary just to make COMPILE_TEST builds
>> happy and might have undesired side effects.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> I'll dump this in my "fixes" tree today and see how it goes.
>

Would be great. Note that allyescconfig still fails with relocation errors
after this patch has been applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-06-30 18:45 ` Guenter Roeck
@ 2014-07-04 19:51   ` Guenter Roeck
  -1 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-04 19:51 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: Paul Mackerras, linuxppc-dev, linux-kernel

ping ...

Guenter

On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/powerpc/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
>   config CRASH_DUMP
>   	bool "Build a kdump crash kernel"
>   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>   	help
>   	  Build a kernel suitable for use as a kdump capture kernel.
>   	  The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
>   if PPC64
>   config RELOCATABLE
>   	bool "Build a relocatable kernel"
> +	depends on !COMPILE_TEST
>   	select NONSTATIC_KERNEL
>   	help
>   	  This builds a kernel image that is capable of running anywhere
>


^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-04 19:51   ` Guenter Roeck
  0 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-04 19:51 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel

ping ...

Guenter

On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/powerpc/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
>   config CRASH_DUMP
>   	bool "Build a kdump crash kernel"
>   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>   	help
>   	  Build a kernel suitable for use as a kdump capture kernel.
>   	  The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
>   if PPC64
>   config RELOCATABLE
>   	bool "Build a relocatable kernel"
> +	depends on !COMPILE_TEST
>   	select NONSTATIC_KERNEL
>   	help
>   	  This builds a kernel image that is capable of running anywhere
>

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-06-30 18:45 ` Guenter Roeck
@ 2014-07-08  3:03   ` Guenter Roeck
  -1 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-08  3:03 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: Paul Mackerras, linuxppc-dev, linux-kernel, Nick

ping ...

Ben, I know this is not perfect, but on the other side it is simple
and would be easy to backport. With this in place, a complete/clean
fix would not be as urgent. Any chance to get it applied ?

Nick, this doesn't fix the allyesconfig build - it still fails with
relocation errors. But it does fix the allmodconfig build.

Thanks,
Guenter

On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/powerpc/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
>   config CRASH_DUMP
>   	bool "Build a kdump crash kernel"
>   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>   	help
>   	  Build a kernel suitable for use as a kdump capture kernel.
>   	  The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
>   if PPC64
>   config RELOCATABLE
>   	bool "Build a relocatable kernel"
> +	depends on !COMPILE_TEST
>   	select NONSTATIC_KERNEL
>   	help
>   	  This builds a kernel image that is capable of running anywhere
>


^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-08  3:03   ` Guenter Roeck
  0 siblings, 0 replies; 14+ messages in thread
From: Guenter Roeck @ 2014-07-08  3:03 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel, Nick

ping ...

Ben, I know this is not perfect, but on the other side it is simple
and would be easy to backport. With this in place, a complete/clean
fix would not be as urgent. Any chance to get it applied ?

Nick, this doesn't fix the allyesconfig build - it still fails with
relocation errors. But it does fix the allmodconfig build.

Thanks,
Guenter

On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/powerpc/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
>   config CRASH_DUMP
>   	bool "Build a kdump crash kernel"
>   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>   	help
>   	  Build a kernel suitable for use as a kdump capture kernel.
>   	  The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
>   if PPC64
>   config RELOCATABLE
>   	bool "Build a relocatable kernel"
> +	depends on !COMPILE_TEST
>   	select NONSTATIC_KERNEL
>   	help
>   	  This builds a kernel image that is capable of running anywhere
>

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-07-08  3:03   ` Guenter Roeck
@ 2014-07-08  3:10     ` Benjamin Herrenschmidt
  -1 siblings, 0 replies; 14+ messages in thread
From: Benjamin Herrenschmidt @ 2014-07-08  3:10 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Paul Mackerras, linuxppc-dev, linux-kernel, Nick

On Mon, 2014-07-07 at 20:03 -0700, Guenter Roeck wrote:
> ping ...
> 
> Ben, I know this is not perfect, but on the other side it is simple
> and would be easy to backport. With this in place, a complete/clean
> fix would not be as urgent. Any chance to get it applied ?

Yes, that definitely helps, I'll include it as a band aid.

Cheers,
Ben.

> Nick, this doesn't fix the allyesconfig build - it still fails with
> relocation errors. But it does fix the allmodconfig build.
> 
> Thanks,
> Guenter
> 
> On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> > powerpc:allmodconfig has been failing for some time with the following
> > error.
> >
> > arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> > arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
> >
> > A number of attempts to fix the problem by moving around code have been
> > unsuccessful and resulted in failed builds for some configurations and
> > the discovery of toolchain bugs.
> >
> > Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> > While this is less than perfect, it avoids substantial code changes
> > which would otherwise be necessary just to make COMPILE_TEST builds
> > happy and might have undesired side effects.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >   arch/powerpc/Kconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index bd6dd6e..fefe7c8 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -414,7 +414,7 @@ config KEXEC
> >   config CRASH_DUMP
> >   	bool "Build a kdump crash kernel"
> >   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> > -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> > +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
> >   	help
> >   	  Build a kernel suitable for use as a kdump capture kernel.
> >   	  The same kernel binary can be used as production kernel and dump
> > @@ -1017,6 +1017,7 @@ endmenu
> >   if PPC64
> >   config RELOCATABLE
> >   	bool "Build a relocatable kernel"
> > +	depends on !COMPILE_TEST
> >   	select NONSTATIC_KERNEL
> >   	help
> >   	  This builds a kernel image that is capable of running anywhere
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-08  3:10     ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 14+ messages in thread
From: Benjamin Herrenschmidt @ 2014-07-08  3:10 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel, Nick

On Mon, 2014-07-07 at 20:03 -0700, Guenter Roeck wrote:
> ping ...
> 
> Ben, I know this is not perfect, but on the other side it is simple
> and would be easy to backport. With this in place, a complete/clean
> fix would not be as urgent. Any chance to get it applied ?

Yes, that definitely helps, I'll include it as a band aid.

Cheers,
Ben.

> Nick, this doesn't fix the allyesconfig build - it still fails with
> relocation errors. But it does fix the allmodconfig build.
> 
> Thanks,
> Guenter
> 
> On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> > powerpc:allmodconfig has been failing for some time with the following
> > error.
> >
> > arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> > arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
> >
> > A number of attempts to fix the problem by moving around code have been
> > unsuccessful and resulted in failed builds for some configurations and
> > the discovery of toolchain bugs.
> >
> > Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> > While this is less than perfect, it avoids substantial code changes
> > which would otherwise be necessary just to make COMPILE_TEST builds
> > happy and might have undesired side effects.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >   arch/powerpc/Kconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index bd6dd6e..fefe7c8 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -414,7 +414,7 @@ config KEXEC
> >   config CRASH_DUMP
> >   	bool "Build a kdump crash kernel"
> >   	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> > -	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> > +	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
> >   	help
> >   	  Build a kernel suitable for use as a kdump capture kernel.
> >   	  The same kernel binary can be used as production kernel and dump
> > @@ -1017,6 +1017,7 @@ endmenu
> >   if PPC64
> >   config RELOCATABLE
> >   	bool "Build a relocatable kernel"
> > +	depends on !COMPILE_TEST
> >   	select NONSTATIC_KERNEL
> >   	help
> >   	  This builds a kernel image that is capable of running anywhere
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
  2014-07-08  3:10     ` Benjamin Herrenschmidt
@ 2014-07-13  6:02       ` Nick Krause
  -1 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-07-13  6:02 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Guenter Roeck, Paul Mackerras, linuxppc-dev, linux-kernel

On Mon, Jul 7, 2014 at 11:10 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Mon, 2014-07-07 at 20:03 -0700, Guenter Roeck wrote:
>> ping ...
>>
>> Ben, I know this is not perfect, but on the other side it is simple
>> and would be easy to backport. With this in place, a complete/clean
>> fix would not be as urgent. Any chance to get it applied ?
>
> Yes, that definitely helps, I'll include it as a band aid.
>
> Cheers,
> Ben.
>
>> Nick, this doesn't fix the allyesconfig build - it still fails with
>> relocation errors. But it does fix the allmodconfig build.
>>
>> Thanks,
>> Guenter
>>
>> On 06/30/2014 11:45 AM, Guenter Roeck wrote:
>> > powerpc:allmodconfig has been failing for some time with the following
>> > error.
>> >
>> > arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
>> > arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
>> > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>> >
>> > A number of attempts to fix the problem by moving around code have been
>> > unsuccessful and resulted in failed builds for some configurations and
>> > the discovery of toolchain bugs.
>> >
>> > Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
>> > While this is less than perfect, it avoids substantial code changes
>> > which would otherwise be necessary just to make COMPILE_TEST builds
>> > happy and might have undesired side effects.
>> >
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> > ---
>> >   arch/powerpc/Kconfig | 3 ++-
>> >   1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> > index bd6dd6e..fefe7c8 100644
>> > --- a/arch/powerpc/Kconfig
>> > +++ b/arch/powerpc/Kconfig
>> > @@ -414,7 +414,7 @@ config KEXEC
>> >   config CRASH_DUMP
>> >     bool "Build a kdump crash kernel"
>> >     depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
>> > -   select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
>> > +   select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>> >     help
>> >       Build a kernel suitable for use as a kdump capture kernel.
>> >       The same kernel binary can be used as production kernel and dump
>> > @@ -1017,6 +1017,7 @@ endmenu
>> >   if PPC64
>> >   config RELOCATABLE
>> >     bool "Build a relocatable kernel"
>> > +   depends on !COMPILE_TEST
>> >     select NONSTATIC_KERNEL
>> >     help
>> >       This builds a kernel image that is capable of running anywhere
>> >
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
Thanks for applying the patch. Works for me too.Sorry about the late
reply working on other build
issues and fix me messages.
Nick

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
@ 2014-07-13  6:02       ` Nick Krause
  0 siblings, 0 replies; 14+ messages in thread
From: Nick Krause @ 2014-07-13  6:02 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: linuxppc-dev, Paul Mackerras, linux-kernel, Guenter Roeck

On Mon, Jul 7, 2014 at 11:10 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Mon, 2014-07-07 at 20:03 -0700, Guenter Roeck wrote:
>> ping ...
>>
>> Ben, I know this is not perfect, but on the other side it is simple
>> and would be easy to backport. With this in place, a complete/clean
>> fix would not be as urgent. Any chance to get it applied ?
>
> Yes, that definitely helps, I'll include it as a band aid.
>
> Cheers,
> Ben.
>
>> Nick, this doesn't fix the allyesconfig build - it still fails with
>> relocation errors. But it does fix the allmodconfig build.
>>
>> Thanks,
>> Guenter
>>
>> On 06/30/2014 11:45 AM, Guenter Roeck wrote:
>> > powerpc:allmodconfig has been failing for some time with the following
>> > error.
>> >
>> > arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
>> > arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
>> > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>> >
>> > A number of attempts to fix the problem by moving around code have been
>> > unsuccessful and resulted in failed builds for some configurations and
>> > the discovery of toolchain bugs.
>> >
>> > Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
>> > While this is less than perfect, it avoids substantial code changes
>> > which would otherwise be necessary just to make COMPILE_TEST builds
>> > happy and might have undesired side effects.
>> >
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> > ---
>> >   arch/powerpc/Kconfig | 3 ++-
>> >   1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> > index bd6dd6e..fefe7c8 100644
>> > --- a/arch/powerpc/Kconfig
>> > +++ b/arch/powerpc/Kconfig
>> > @@ -414,7 +414,7 @@ config KEXEC
>> >   config CRASH_DUMP
>> >     bool "Build a kdump crash kernel"
>> >     depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
>> > -   select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
>> > +   select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
>> >     help
>> >       Build a kernel suitable for use as a kdump capture kernel.
>> >       The same kernel binary can be used as production kernel and dump
>> > @@ -1017,6 +1017,7 @@ endmenu
>> >   if PPC64
>> >   config RELOCATABLE
>> >     bool "Build a relocatable kernel"
>> > +   depends on !COMPILE_TEST
>> >     select NONSTATIC_KERNEL
>> >     help
>> >       This builds a kernel image that is capable of running anywhere
>> >
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
Thanks for applying the patch. Works for me too.Sorry about the late
reply working on other build
issues and fix me messages.
Nick

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-07-13  6:03 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 18:45 [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64 Guenter Roeck
2014-06-30 18:45 ` Guenter Roeck
2014-07-01  0:55 ` Stephen Rothwell
2014-07-01  0:55   ` Stephen Rothwell
2014-07-01  2:22   ` Guenter Roeck
2014-07-01  2:22     ` Guenter Roeck
2014-07-04 19:51 ` Guenter Roeck
2014-07-04 19:51   ` Guenter Roeck
2014-07-08  3:03 ` Guenter Roeck
2014-07-08  3:03   ` Guenter Roeck
2014-07-08  3:10   ` Benjamin Herrenschmidt
2014-07-08  3:10     ` Benjamin Herrenschmidt
2014-07-13  6:02     ` Nick Krause
2014-07-13  6:02       ` Nick Krause

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.