From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> To: Tushar Behera <trblinux@gmail.com>, Lee Jones <lee.jones@linaro.org> Cc: Samuel Ortiz <sameo@linux.intel.com>, Mark Brown <broonie@kernel.org>, Mike Turquette <mturquette@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Alessandro Zummo <a.zummo@towertech.it>, Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, Olof Johansson <olof@lixom.net>, Sjoerd Simons <sjoerd.simons@collabora.co.uk>, Daniel Stone <daniels@collabora.com>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Yadwinder Singh Brar <yadi.brar01@gmail.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Date: Wed, 02 Jul 2014 11:22:42 +0200 [thread overview] Message-ID: <53B3CF62.2020205@collabora.co.uk> (raw) In-Reply-To: <53B3CED8.4020808@gmail.com> Hello Tushar, Thanks a lot for your feedback. On 07/02/2014 11:20 AM, Tushar Behera wrote: > On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote: >> Peach pit and pi boards uses a Maxim 77802 power management >> IC to drive regulators and its Real Time Clock. This patch >> adds support for this chip. >> >> These are the device nodes and pinctrl configuration that >> are present on the Peach pit DeviceTree source file in the >> the Chrome OS kernel 3.8 tree. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> --- > > [ ... ] > >> + >> + regulators { >> + buck1_reg: BUCK1 { >> + regulator-name = "vdd_mif"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-ramp-delay = <12500>; >> + }; > > IMO, adding a blank line between sub-nodes would be better. > Ok >> + buck2_reg: BUCK2 { >> + regulator-name = "vdd_arm_real"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1500000>; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-ramp-delay = <12500>; >> + }; > > [ ... ] > >> + vqmmc_sdcard: ldo4_reg: LDO4 { >> + regulator-name = "vdd_sd"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + > > Blank line, can be removed. > Ok >> + }; > > [ ... ] >> + ldo23_reg: LDO23 { >> + regulator-name = "ld0_23"; > > ldo_23, 'o' in place of '0'. > Right, missed that. Thanks for pointing out. > Similar comments for peach-pi DTS file. > Best regards, Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Date: Wed, 02 Jul 2014 11:22:42 +0200 [thread overview] Message-ID: <53B3CF62.2020205@collabora.co.uk> (raw) In-Reply-To: <53B3CED8.4020808@gmail.com> Hello Tushar, Thanks a lot for your feedback. On 07/02/2014 11:20 AM, Tushar Behera wrote: > On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote: >> Peach pit and pi boards uses a Maxim 77802 power management >> IC to drive regulators and its Real Time Clock. This patch >> adds support for this chip. >> >> These are the device nodes and pinctrl configuration that >> are present on the Peach pit DeviceTree source file in the >> the Chrome OS kernel 3.8 tree. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> Tested-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> --- > > [ ... ] > >> + >> + regulators { >> + buck1_reg: BUCK1 { >> + regulator-name = "vdd_mif"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-ramp-delay = <12500>; >> + }; > > IMO, adding a blank line between sub-nodes would be better. > Ok >> + buck2_reg: BUCK2 { >> + regulator-name = "vdd_arm_real"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1500000>; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-ramp-delay = <12500>; >> + }; > > [ ... ] > >> + vqmmc_sdcard: ldo4_reg: LDO4 { >> + regulator-name = "vdd_sd"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + > > Blank line, can be removed. > Ok >> + }; > > [ ... ] >> + ldo23_reg: LDO23 { >> + regulator-name = "ld0_23"; > > ldo_23, 'o' in place of '0'. > Right, missed that. Thanks for pointing out. > Similar comments for peach-pi DTS file. > Best regards, Javier
next prev parent reply other threads:[~2014-07-02 9:22 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-26 18:15 [PATCH v5 00/14] Add Maxim 77802 PMIC support Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 01/14] mfd: max77686: Convert to use regmap_irq Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-27 9:21 ` Lee Jones 2014-06-27 9:21 ` Lee Jones 2014-06-27 9:32 ` Javier Martinez Canillas 2014-06-27 9:32 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-27 7:48 ` Andreas Färber 2014-06-27 7:48 ` Andreas Färber 2014-06-27 7:53 ` Javier Martinez Canillas 2014-06-27 7:53 ` Javier Martinez Canillas 2014-06-27 8:26 ` Andreas Färber 2014-06-27 8:26 ` Andreas Färber 2014-06-27 8:54 ` Javier Martinez Canillas 2014-06-27 8:54 ` Javier Martinez Canillas 2014-06-27 8:54 ` Javier Martinez Canillas 2014-07-01 17:30 ` Mike Turquette 2014-07-01 17:30 ` Mike Turquette 2014-07-01 17:30 ` Mike Turquette 2014-06-26 18:15 ` [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-07-01 17:29 ` Mike Turquette 2014-07-01 17:29 ` Mike Turquette 2014-07-01 17:29 ` Mike Turquette 2014-07-02 10:17 ` Javier Martinez Canillas 2014-07-02 10:17 ` Javier Martinez Canillas 2014-07-02 15:21 ` Mike Turquette 2014-07-02 15:21 ` Mike Turquette 2014-06-26 18:15 ` [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-30 4:01 ` Yadwinder Singh Brar 2014-06-30 4:01 ` Yadwinder Singh Brar 2014-06-30 4:01 ` Yadwinder Singh Brar 2014-06-30 10:58 ` Javier Martinez Canillas 2014-06-30 10:58 ` Javier Martinez Canillas 2014-06-30 10:58 ` Javier Martinez Canillas 2014-06-30 11:35 ` Russell King - ARM Linux 2014-06-30 11:35 ` Russell King - ARM Linux 2014-06-30 11:35 ` Russell King - ARM Linux 2014-06-30 16:00 ` Javier Martinez Canillas 2014-06-30 16:00 ` Javier Martinez Canillas 2014-06-30 16:00 ` Javier Martinez Canillas 2014-07-01 17:26 ` Mike Turquette 2014-07-01 17:26 ` Mike Turquette 2014-07-01 17:26 ` Mike Turquette 2014-07-02 10:13 ` Javier Martinez Canillas 2014-07-02 10:13 ` Javier Martinez Canillas 2014-07-02 10:13 ` Javier Martinez Canillas 2014-07-02 10:19 ` Krzysztof Kozlowski 2014-07-02 10:19 ` Krzysztof Kozlowski 2014-07-02 10:19 ` Krzysztof Kozlowski 2014-06-26 18:15 ` [PATCH v5 06/14] clk: max77686: Convert to the generic max clock driver Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 07/14] mfd: Add driver for Maxim 77802 Power Management IC Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-07-01 15:15 ` Lee Jones 2014-07-01 15:15 ` Lee Jones 2014-07-01 15:55 ` Javier Martinez Canillas 2014-07-01 15:55 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 08/14] mfd: max77802: Add DT binding documentation Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-27 8:06 ` Andreas Färber 2014-06-27 8:06 ` Andreas Färber 2014-06-27 8:50 ` Javier Martinez Canillas 2014-06-27 8:50 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 09/14] regmap: Add regmap_reg_copy function Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 10/14] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-27 9:26 ` Lee Jones 2014-06-27 9:26 ` Lee Jones 2014-06-27 9:42 ` Javier Martinez Canillas 2014-06-27 9:42 ` Javier Martinez Canillas 2014-06-27 9:42 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 11/14] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 12/14] clk: max77802: Add DT binding documentation Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-27 7:52 ` Andreas Färber 2014-06-27 7:52 ` Andreas Färber 2014-06-27 7:52 ` Andreas Färber 2014-06-27 7:55 ` Javier Martinez Canillas 2014-06-27 7:55 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-06-26 18:15 ` [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi Javier Martinez Canillas 2014-06-26 18:15 ` Javier Martinez Canillas 2014-07-02 9:20 ` Tushar Behera 2014-07-02 9:20 ` Tushar Behera 2014-07-02 9:22 ` Javier Martinez Canillas [this message] 2014-07-02 9:22 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53B3CF62.2020205@collabora.co.uk \ --to=javier.martinez@collabora.co.uk \ --cc=a.zummo@towertech.it \ --cc=broonie@kernel.org \ --cc=daniels@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=k.kozlowski@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=olof@lixom.net \ --cc=sameo@linux.intel.com \ --cc=sjoerd.simons@collabora.co.uk \ --cc=tomeu.vizoso@collabora.com \ --cc=trblinux@gmail.com \ --cc=yadi.brar01@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.